From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8632EC072B5 for ; Fri, 24 May 2019 14:13:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51B7A20665 for ; Fri, 24 May 2019 14:13:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="FxI/equ1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404105AbfEXONP (ORCPT ); Fri, 24 May 2019 10:13:15 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:56042 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403917AbfEXONP (ORCPT ); Fri, 24 May 2019 10:13:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/9dmYJZulcMPLnnMVDuzzMs5fmFA6/ZM62RgXCFhBYI=; b=FxI/equ1rCcR7ROW74hmHaIN8W a3sMPajtJWiA9+njTVE56NWYyVBEAiP0AYgQfgUHhsbDXbc2nLFQbR8vfrF2QUNbzUOlJpW9ir5Iq hedicBAbYCafl5/aPprnxcMjGEFL+21IjzSCp7ToryTa8nCwo8qQCdBpaK4OlT9YcOZ8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hUAwZ-0001Uf-L4; Fri, 24 May 2019 16:13:11 +0200 Date: Fri, 24 May 2019 16:13:11 +0200 From: Andrew Lunn To: Rasmus Villemoes Cc: Vivien Didelot , Florian Fainelli , "David S. Miller" , Rasmus Villemoes , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 1/5] net: dsa: mv88e6xxx: introduce support for two chips using direct smi addressing Message-ID: <20190524141311.GJ2979@lunn.ch> References: <20190501193126.19196-1-rasmus.villemoes@prevas.dk> <20190524085921.11108-1-rasmus.villemoes@prevas.dk> <20190524085921.11108-2-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190524085921.11108-2-rasmus.villemoes@prevas.dk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 24, 2019 at 09:00:24AM +0000, Rasmus Villemoes wrote: > The 88e6250 (as well as 6220, 6071, 6070, 6020) do not support > multi-chip (indirect) addressing. However, one can still have two of > them on the same mdio bus, since the device only uses 16 of the 32 > possible addresses, either addresses 0x00-0x0F or 0x10-0x1F depending > on the ADDR4 pin at reset [since ADDR4 is internally pulled high, the > latter is the default]. > > In order to prepare for supporting the 88e6250 and friends, introduce > mv88e6xxx_info::dual_chip to allow having a non-zero sw_addr while > still using direct addressing. > > Signed-off-by: Rasmus Villemoes Reviewed-by: Andrew Lunn Andrew