From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F742C282E1 for ; Fri, 24 May 2019 22:06:23 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id ABE42217F9 for ; Fri, 24 May 2019 22:06:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="aEtZKisP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABE42217F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6EA0CA69; Sat, 25 May 2019 00:06:21 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id A814C1D7 for ; Sat, 25 May 2019 00:06:20 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id z26so6080581pfg.6 for ; Fri, 24 May 2019 15:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EaoAa+xs8uUaVhxDQOYI4AhnvnP63FRHlypWsqnwQhI=; b=aEtZKisP+PdEcbpwrcBtQgkVBBdBH8iue8hDTim3gHdPR52IWcP2RWaE1Olr8wOtsp 4JpPyebZTuCx747UI4Z6neVCPdjPFLp/6B1gTCOmWQUEeuXNmP17ofLoM626ZLmLp7jg cds62bq8Bi98Mu0XfvrjmigM/5SpdZ8e9v0fbQ0ZifWqGQ61HtbC0osQQwc7OT/UoAez U1VDytkaXQSBOk7O1B2Mdfl40hpBRmvlnB6nehsazN3Q0cCX4Tpgd1WrkXv4H3PXcIQ2 IBBCSo9qD8HWMdXScZUaWsOTlrvXgLiPEIkU43xrUwfFU4VD/shBFxHD2nz05UfRDSrX wCcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EaoAa+xs8uUaVhxDQOYI4AhnvnP63FRHlypWsqnwQhI=; b=D1kXDiWutipAS+1Elkf8n+bpTiCQ2ZfbrSkq6maXEJLklFuKYKlcXB9T5fvv6C3A2E Eck6bp0QNt000FtxaRoU8Lsb4adRgjOtTuAyYfm+5R4TyhvXtRaG3L0JEs6/LXAw3xZc oHOwMH2SCmeXQpqU9FVNcsNHze5mttSeY7+OSCyNqRst82rAUXMwqJ/sLYBgnz0wm7/B Y0yVS3o6Qc/pGyzy3Vkw5P2YsO8S+lPIL3qn//VHHIbmnj/AuXQYBr6VPWKDqg6M3Az8 pq6vNJX0nPI+jnnc9BBaHXvXJDVtXybmz1mZdjvasZ4aVYNFwnqI5CNefLiIVFUFecbu NATw== X-Gm-Message-State: APjAAAUNOeZFqrGmIVCN1FkT0t8HIumDtgnXThlOAETUOH8sJEHK+Vzl 83b2yVXXC5/ZFS3BPIBNghm4CQ== X-Google-Smtp-Source: APXvYqyuxfRHRTS7BAzQwnhjdX3H3CS5sXPyaT5GV28MkQkGPbQYtVU+tNxkRdXs6Gu09DdbOnSMxQ== X-Received: by 2002:a17:90a:9dc1:: with SMTP id x1mr12604701pjv.102.1558735579612; Fri, 24 May 2019 15:06:19 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 140sm5984239pfw.123.2019.05.24.15.06.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 May 2019 15:06:19 -0700 (PDT) Date: Fri, 24 May 2019 15:06:17 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, Ferruh Yigit , matan@mellanox.com, Stephen Hemminger Message-ID: <20190524150617.6b0246ae@hermes.lan> In-Reply-To: <2097372.dQ5myFMioY@xps> References: <20190523220124.18818-1-stephen@networkplumber.org> <2341346.KjBqQsXUje@xps> <20190524101108.574621c8@hermes.lan> <2097372.dQ5myFMioY@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/vdev_netvsc: print warning if Mellanox devices are not configured X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 24 May 2019 19:32:14 +0200 Thomas Monjalon wrote: > 24/05/2019 19:11, Stephen Hemminger: > > On Fri, 24 May 2019 19:05:20 +0200 > > Thomas Monjalon wrote: > > > > > > > > device drivers on Hyper-V/Azure. If the build system supported dependencies > > > > > > (like Linux kbuild) this would not be necessary. Meson only does dynamic dependencies > > > > > > so that doesn't help. > > > > > > > > > > > > This is a warning and not fatal only because application will still at > > > > > > least run, and somebody may want to run with SR-IOV with Intel NIC's on Hyper-V. > > > > > > > > > > > > > > > > > > The warning is just to give users better immediate feedback rather than > > > > > > trying to diagnose poor performance or mystery device not found messages. > > > > > > > > > > > > > > > It really looks strange to me. > > > > > What you need is to fail at compilation if requested PMD is not built. > > > > > I would advise to work on a script to configure meson. > > > > > > > > None of the people that ran into this were using meson build. > > > > For example, VPP doesn't use meson. > > > > > > They will use meson when makefile will be removed :) > > > > > > Anyway, no matter the build system, what we want is a way > > > to guide users to a proper DPDK installation. > > > Your solution is to add some very specific logs. > > > My proposal is to guide the user with a script and some > > > specific parameters so it will fail if a required dependency is not met. > > > > Not familiar enough with meson magic syntax to make vdev_netvsc not build > > without MLX. But that would just be pushing the mystery failure further > > down the road. > > I think you did not understand my proposal. > Let's take an example. You give this instruction to build DPDK: > buildtools/build-require.sh vdev_netvsc mlx4 There is no build-require.sh now and introducing yet another tool is not going to help. > If mlx4 is not built then it will fail with this message: > librte_pmd_mlx4 failed to build > So the user knows what went wrong. No mystery. > > > > Another alternative would be to drop vdev_netvsc from the default Linux > > build. That way users would have to enable it manually. > > > > My preferred solution would be to just kill vdev_netvsc and go to only netvsc PMD > > but that is a couple releases away. Let's just fix the meson.build for now to skip vdev_netvsc unless both mlx4 and mlx5 are present. The Makefile can just remain untouched. The people with problem are on older releases anyway. So any attempt to fix the Makefiles won't help those on 18.02, etc.