All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gen Zhang <blackgod016574@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, alsa-devel@alsa-project.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tegra_wm9712: Fix a memory leaking bug in tegra_wm9712_driver_probe()
Date: Fri, 24 May 2019 23:42:52 +0800	[thread overview]
Message-ID: <20190524154252.GA10186@zhanggen-UX430UQ> (raw)
In-Reply-To: <1740686f-a466-430c-9d01-ab83ea6998ac@nvidia.com>

On Fri, May 24, 2019 at 04:36:54PM +0100, Jon Hunter wrote:
> There could well be cases where you need to explicitly call
> devm_kfree(), but having a quick glance at the example above, I don't
> see why you would call devm_kfree() here and yes looks like that code
> could be simplified significantly. Notice that hisi_sas_debugfs_exit()
> does not free any memory as it is not necessary to explicitly do so.
> 
> Cheers
> Jon
> 
> -- 
> nvpublic
Thanks for your suggestions, Jon! I think I need to e-mail to those
maintainers about this issue.

Thanks
Gen

      reply	other threads:[~2019-05-24 15:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24  0:50 [PATCH] tegra_wm9712: Fix a memory leaking bug in tegra_wm9712_driver_probe() Gen Zhang
2019-05-24  8:33 ` Jon Hunter
2019-05-24  8:33   ` Jon Hunter
2019-05-24 14:33   ` Gen Zhang
2019-05-24 14:47     ` Jon Hunter
2019-05-24 14:47       ` Jon Hunter
2019-05-24 15:00       ` Gen Zhang
2019-05-24 15:36         ` Jon Hunter
2019-05-24 15:36           ` Jon Hunter
2019-05-24 15:42           ` Gen Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190524154252.GA10186@zhanggen-UX430UQ \
    --to=blackgod016574@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jonathanh@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.