From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E168CC072B5 for ; Fri, 24 May 2019 16:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5E892184E for ; Fri, 24 May 2019 16:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558717191; bh=Y30ZYQTGIcn4G7VTREG4n5miS72jZJwD2+w5546D71A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=joRoB78gjWp8nOtP/6dPr3J055jsc48LmZ5rLVifzTWV68K9mJZFjyiZzr3RKpbDM yL/T1bdHeRK3hG9XJ/p2eejiJI+sgUuzjgccuyM/4NTTuaXKsHYu1mupJCZFo1BcXk JFD0Jo5TRdntF+erC4+oWOcnLrQGpJySwBdT6lnU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390910AbfEXQ7v (ORCPT ); Fri, 24 May 2019 12:59:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:43736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390210AbfEXQ7v (ORCPT ); Fri, 24 May 2019 12:59:51 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 68BCD217F9; Fri, 24 May 2019 16:59:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558717190; bh=Y30ZYQTGIcn4G7VTREG4n5miS72jZJwD2+w5546D71A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cx1/KWjIjXKjcGoyLv9yTcAVUFQS/6zTriY/jWgII8l5s5w3opnoWr1BtrhNRmfXH O6EqwzLn5ZXqHc9FIXm5dfNZ92JbUqLl9hyEYR8pzsms9/bRJCWiYdDbaF3VFUnZZ5 8h567rT7LqYWh5oA3R7UsfghUG0M6bEZzQW8p6gA= Date: Fri, 24 May 2019 18:59:48 +0200 From: Greg KH To: Allison Randal Cc: Thomas Gleixner , Richard Fontana , linux-spdx@vger.kernel.org Subject: Re: [Batch 6 - patch 08/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 133 Message-ID: <20190524165948.GA24037@kroah.com> References: <20190524100345.776412942@linutronix.de> <20190524100843.594454135@linutronix.de> <9f924d00-df10-cb76-3dec-0e60aaeb4f58@lohutok.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f924d00-df10-cb76-3dec-0e60aaeb4f58@lohutok.net> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-spdx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spdx@vger.kernel.org On Fri, May 24, 2019 at 12:50:37PM -0400, Allison Randal wrote: > On 5/24/19 12:02 PM, Thomas Gleixner wrote: > > On Fri, 24 May 2019, Richard Fontana wrote: > >> On Fri, May 24, 2019 at 6:12 AM Thomas Gleixner wrote: > >>> > >>> From: Thomas Gleixner tglx@linutronix.de > >>> > >>> Based on 1 normalized pattern(s): > >>> > >>> this program is free software you can redistribute it and or modify > >>> it under the terms of the gnu general public license as published by > >>> the free software foundation either version 2 of the license or at > >>> your option any later version this program is distributed in the > >>> hope that it will be useful but without any warranty without even > >>> the implied warranty of merchantability or fitness for a particular > >>> purpose see the gnu general public license for more details the full > >>> gnu general public license is in this distribution in the file > >>> called copying > >> > >> I just want to note that the final sentence/paragraph in this pattern, > >> alerting the user to the location of the license text ("The full GNU > >> General Public License is in this distribution in the file called > >> COPYING.") arguably raises its own sort of "keep intact" issue, > >> separate from the things we've been more focused on (notices of the > >> applicability of the license, and warranty/liability disclaimers > >> juxtaposed with the license notice). This may have come up in earlier > >> cases I looked at but if so I didn't think about it. > > > > The reference to the COPYING file is all over the place. But what's > > worrysome about that? I'd be worried if the boilerplate would be BSD and > > then point to the COPYING file in the kernel tree, but a plain GPL boiler > > plate? > > > > I can't see how that might change anything, the SPDX identifier is > > documented to be a placeholder for the full license text which is in the > > LICENSES directory and pointed to from the reworked COPYING file. > > Agreed with Thomas. And besides, it's actually inaccurate for the file > to say that the full text of the GPL is in the COPYING file, because in > the Kernel the COPYING file does not contain the text of the GPL, it > only contains a pointer to it. Originally it did, that changed only recently. thanks, greg k-h