All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
To: Eddie James <eajames@linux.ibm.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-aspeed@lists.ozlabs.org, linux-media@vger.kernel.org,
	Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Subject: [PATCH v2 05/11] media: aspeed: reduce noisy log printing outs
Date: Fri, 24 May 2019 16:17:19 -0700	[thread overview]
Message-ID: <20190524231725.12320-6-jae.hyun.yoo@linux.intel.com> (raw)
In-Reply-To: <20190524231725.12320-1-jae.hyun.yoo@linux.intel.com>

Currently, this driver prints out too much log messages when a
mode change happens, video turned off by screen saver and etc.
Actually, all cases are reported to user space properly. Also,
these are not critical errors but recoverable things, so this
commit changes the log level of some noisy printing outs.

Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Eddie James <eajames@linux.ibm.com>
---
v1 -> v2:
 None.

 drivers/media/platform/aspeed-video.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
index d1b541409544..92abdfc79e76 100644
--- a/drivers/media/platform/aspeed-video.c
+++ b/drivers/media/platform/aspeed-video.c
@@ -441,7 +441,7 @@ static int aspeed_video_start_frame(struct aspeed_video *video)
 
 	if (!(seq_ctrl & VE_SEQ_CTRL_COMP_BUSY) ||
 	    !(seq_ctrl & VE_SEQ_CTRL_CAP_BUSY)) {
-		dev_err(video->dev, "Engine busy; don't start frame\n");
+		dev_dbg(video->dev, "Engine busy; don't start frame\n");
 		return -EBUSY;
 	}
 
@@ -769,7 +769,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video)
 						      res_check(video),
 						      MODE_DETECT_TIMEOUT);
 		if (!rc) {
-			dev_err(video->dev, "Timed out; first mode detect\n");
+			dev_dbg(video->dev, "Timed out; first mode detect\n");
 			clear_bit(VIDEO_RES_DETECT, &video->flags);
 			return;
 		}
@@ -787,7 +787,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video)
 						      MODE_DETECT_TIMEOUT);
 		clear_bit(VIDEO_RES_DETECT, &video->flags);
 		if (!rc) {
-			dev_err(video->dev, "Timed out; second mode detect\n");
+			dev_dbg(video->dev, "Timed out; second mode detect\n");
 			return;
 		}
 
@@ -821,7 +821,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video)
 	} while (invalid_resolution && (tries++ < INVALID_RESOLUTION_RETRIES));
 
 	if (invalid_resolution) {
-		dev_err(video->dev, "Invalid resolution detected\n");
+		dev_dbg(video->dev, "Invalid resolution detected\n");
 		return;
 	}
 
@@ -1456,7 +1456,7 @@ static void aspeed_video_stop_streaming(struct vb2_queue *q)
 				!test_bit(VIDEO_FRAME_INPRG, &video->flags),
 				STOP_TIMEOUT);
 	if (!rc) {
-		dev_err(video->dev, "Timed out when stopping streaming\n");
+		dev_dbg(video->dev, "Timed out when stopping streaming\n");
 
 		/*
 		 * Need to force stop any DMA and try and get HW into a good
-- 
2.21.0


  parent reply	other threads:[~2019-05-24 23:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24 23:17 [PATCH v2 00/11] Improve stability and add bug fixes of Aspeed video engine driver Jae Hyun Yoo
2019-05-24 23:17 ` [PATCH v2 01/11] media: aspeed: fix a kernel warning on clk control Jae Hyun Yoo
2019-05-24 23:17 ` [PATCH v2 02/11] media: aspeed: refine clock control logic Jae Hyun Yoo
2019-05-24 23:17 ` [PATCH v2 03/11] media: aspeed: change irq to threaded irq Jae Hyun Yoo
2019-05-24 23:17 ` [PATCH v2 04/11] media: aspeed: remove IRQF_SHARED flag Jae Hyun Yoo
2019-05-24 23:17 ` Jae Hyun Yoo [this message]
2019-05-24 23:17 ` [PATCH v2 06/11] media: aspeed: remove checking of VE_INTERRUPT_CAPTURE_COMPLETE Jae Hyun Yoo
2019-05-24 23:17 ` [PATCH v2 07/11] media: aspeed: refine interrupt handling logic Jae Hyun Yoo
2019-05-24 23:17 ` [PATCH v2 08/11] media: aspeed: remove source buffer allocation before mode detection Jae Hyun Yoo
2019-05-29 16:07   ` Eddie James
2019-05-24 23:17 ` [PATCH v2 09/11] media: aspeed: use different delays for triggering VE H/W reset Jae Hyun Yoo
2019-05-29 16:07   ` Eddie James
2019-05-24 23:17 ` [PATCH v2 10/11] media: aspeed: fix an incorrect timeout checking in mode detection Jae Hyun Yoo
2019-05-29 14:03   ` Eddie James
2019-05-29 17:04     ` Jae Hyun Yoo
2019-05-24 23:17 ` [PATCH v2 11/11] media: aspeed: add a workaround to fix a silicon bug Jae Hyun Yoo
2019-05-29 14:07   ` Eddie James
2019-05-29 17:29     ` Jae Hyun Yoo
2019-05-31 16:32       ` Ryan Chen
2019-05-31 20:38         ` Jae Hyun Yoo
2019-05-29  9:55 ` [PATCH v2 00/11] Improve stability and add bug fixes of Aspeed video engine driver Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190524231725.12320-6-jae.hyun.yoo@linux.intel.com \
    --to=jae.hyun.yoo@linux.intel.com \
    --cc=andrew@aj.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=eajames@linux.ibm.com \
    --cc=joel@jms.id.au \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.