From: Wolfram Sang <wsa@the-dreams.de>
To: Ajay Gupta <ajaykuee@gmail.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
linux-i2c@vger.kernel.org, Ajay Gupta <ajayg@nvidia.com>
Subject: Re: [PATCH v3 1/5] i2c: nvidia-gpu: refactor master_xfer
Date: Sat, 25 May 2019 21:54:17 +0200 [thread overview]
Message-ID: <20190525195416.GA12538@kunai> (raw)
In-Reply-To: <20190522183142.11061-2-ajayg@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
On Wed, May 22, 2019 at 11:31:38AM -0700, Ajay Gupta wrote:
> From: Ajay Gupta <ajayg@nvidia.com>
>
> Added a local variable "send_stop" to simplify "goto" statements.
>
> The "send_stop" handles below two case
> 1) When first i2c start fails and so i2c stop is not sent before
> exiting
>
> 2) When i2c stop failed after all transfers and we do not need to
> send another stop before exiting.
>
> Signed-off-by: Ajay Gupta <ajayg@nvidia.com>
Nice! It was only a brainstorming suggestion to use a dedicated flag.
But I must say I like the outcome; much better readable code IMO.
Suggested-by: Wolfram Sang <wsa@the-dreams.de>
Reviewed-by: Wolfram Sang <wsa@the-dreams.de>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-05-25 19:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 18:31 [PATCH v3 0/5] usb: typec: ucsi: ccg: add runtime pm support Ajay Gupta
2019-05-22 18:31 ` [PATCH v3 1/5] i2c: nvidia-gpu: refactor master_xfer Ajay Gupta
2019-05-25 19:54 ` Wolfram Sang [this message]
2019-05-22 18:31 ` [PATCH v3 2/5] i2c: nvidia-gpu: add runtime pm support Ajay Gupta
2019-05-25 19:56 ` Wolfram Sang
2019-05-28 14:25 ` Ajay Gupta
2019-05-31 19:42 ` Ajay Gupta
2019-05-22 18:31 ` [PATCH v3 3/5] usb: typec: ucsi: ccg: enable " Ajay Gupta
2019-05-22 18:31 ` [PATCH v3 4/5] i2c: nvidia-gpu: resume ccgx i2c client Ajay Gupta
2019-05-25 19:58 ` Wolfram Sang
2019-05-22 18:31 ` [PATCH v3 5/5] usb: typec: ucsi: ccg: add runtime pm workaround Ajay Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190525195416.GA12538@kunai \
--to=wsa@the-dreams.de \
--cc=ajayg@nvidia.com \
--cc=ajaykuee@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.