From: Stefan Hajnoczi <stefanha@redhat.com>
To: Aarushi Mehta <mehta.aaru20@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>,
saket.sinha89@gmail.com, Julia Suvorova <jusual@mail.ru>
Subject: Re: [Qemu-devel] [PATCH v3 8/8] block/fileposix: extend to use io_uring
Date: Mon, 27 May 2019 10:42:07 +0100 [thread overview]
Message-ID: <20190527094207.GC25631@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190527080327.10780-9-mehta.aaru20@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Mon, May 27, 2019 at 01:33:27PM +0530, Aarushi Mehta wrote:
> @@ -1920,24 +1947,40 @@ static int coroutine_fn raw_co_pwritev(BlockDriverState *bs, uint64_t offset,
>
> static void raw_aio_plug(BlockDriverState *bs)
> {
> -#ifdef CONFIG_LINUX_AIO
> +#if defined CONFIG_LINUX_AIO || defined CONFIG_LINUX_IO_URING
> BDRVRawState *s = bs->opaque;
> +#endif
It would be nice to avoid the extra ifdefs. Here is an alternative
without #ifdef:
BDRVRawState __attribute__((unused)) *s = bs->opaque;
> @@ -1963,8 +2006,10 @@ static int raw_co_flush_to_disk(BlockDriverState *bs)
> static void raw_aio_attach_aio_context(BlockDriverState *bs,
> AioContext *new_context)
> {
> +#if defined CONFIG_LINUX_AIO || defined CONFIG_LINUX_IO_URING
> + BDRVRawState *s = bs->opaque;
Indentation?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-27 9:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 8:03 [Qemu-devel] [PATCH v3 0/8] Add support for io_uring Aarushi Mehta
2019-05-27 8:03 ` [Qemu-devel] [PATCH v3 1/8] configure: permit use of io_uring Aarushi Mehta
2019-05-27 8:03 ` [Qemu-devel] [PATCH v3 2/8] qapi/block-core: add option for io_uring Aarushi Mehta
2019-05-27 8:29 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2019-05-27 8:03 ` [Qemu-devel] [PATCH v3 3/8] block/block: add BDRV flag " Aarushi Mehta
2019-05-27 8:30 ` Stefan Hajnoczi
2019-05-27 8:03 ` [Qemu-devel] [PATCH v3 4/8] block/io_uring: implements interfaces " Aarushi Mehta
2019-05-27 9:32 ` Stefan Hajnoczi
2019-05-27 8:03 ` [Qemu-devel] [PATCH v3 5/8] stubs: add stubs for io_uring interface Aarushi Mehta
2019-05-27 8:32 ` Stefan Hajnoczi
2019-05-27 8:03 ` [Qemu-devel] [PATCH v3 6/8] util/async: add aio interfaces for io_uring Aarushi Mehta
2019-05-27 8:03 ` [Qemu-devel] [PATCH v3 7/8] blockdev: accept io_uring as option Aarushi Mehta
2019-05-27 8:03 ` [Qemu-devel] [PATCH v3 8/8] block/fileposix: extend to use io_uring Aarushi Mehta
2019-05-27 9:42 ` Stefan Hajnoczi [this message]
2019-05-27 8:25 ` [Qemu-devel] [PATCH v3 0/8] Add support for io_uring no-reply
2019-05-27 9:01 ` Stefan Hajnoczi
2019-05-27 8:43 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527094207.GC25631@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=jusual@mail.ru \
--cc=kwolf@redhat.com \
--cc=mehta.aaru20@gmail.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=saket.sinha89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.