All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	Krister Johansen <kjlx@templeofstupid.com>,
	Hari Bathini <hbathini@linux.vnet.ibm.com>
Subject: Re: [PATCH 4/3] perf tools: Remove const from thread read accessors
Date: Mon, 27 May 2019 11:15:41 -0300	[thread overview]
Message-ID: <20190527141541.GA6417@kernel.org> (raw)
In-Reply-To: <20190527061149.168640-1-namhyung@kernel.org>

Em Mon, May 27, 2019 at 03:11:49PM +0900, Namhyung Kim escreveu:
> The namespaces and comm fields of a thread are protected by rwsem and
> require write access for it.  So it ended up using a cast to remove
> the const qualifier.  Let's get rid of the const then.

Thanks, applied 1/3 and 4/3.

- Arnaldo
 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/util/hist.c   |  2 +-
>  tools/perf/util/thread.c | 12 ++++++------
>  tools/perf/util/thread.h |  4 ++--
>  3 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
> index 7ace7a10054d..fb3271fd420c 100644
> --- a/tools/perf/util/hist.c
> +++ b/tools/perf/util/hist.c
> @@ -2561,7 +2561,7 @@ int __hists__scnprintf_title(struct hists *hists, char *bf, size_t size, bool sh
>  	char unit;
>  	int printed;
>  	const struct dso *dso = hists->dso_filter;
> -	const struct thread *thread = hists->thread_filter;
> +	struct thread *thread = hists->thread_filter;
>  	int socket_id = hists->socket_filter;
>  	unsigned long nr_samples = hists->stats.nr_events[PERF_RECORD_SAMPLE];
>  	u64 nr_events = hists->stats.total_period;
> diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
> index b413ba5b9835..aab7807d445f 100644
> --- a/tools/perf/util/thread.c
> +++ b/tools/perf/util/thread.c
> @@ -141,13 +141,13 @@ static struct namespaces *__thread__namespaces(const struct thread *thread)
>  	return list_first_entry(&thread->namespaces_list, struct namespaces, list);
>  }
>  
> -struct namespaces *thread__namespaces(const struct thread *thread)
> +struct namespaces *thread__namespaces(struct thread *thread)
>  {
>  	struct namespaces *ns;
>  
> -	down_read((struct rw_semaphore *)&thread->namespaces_lock);
> +	down_read(&thread->namespaces_lock);
>  	ns = __thread__namespaces(thread);
> -	up_read((struct rw_semaphore *)&thread->namespaces_lock);
> +	up_read(&thread->namespaces_lock);
>  
>  	return ns;
>  }
> @@ -271,13 +271,13 @@ static const char *__thread__comm_str(const struct thread *thread)
>  	return comm__str(comm);
>  }
>  
> -const char *thread__comm_str(const struct thread *thread)
> +const char *thread__comm_str(struct thread *thread)
>  {
>  	const char *str;
>  
> -	down_read((struct rw_semaphore *)&thread->comm_lock);
> +	down_read(&thread->comm_lock);
>  	str = __thread__comm_str(thread);
> -	up_read((struct rw_semaphore *)&thread->comm_lock);
> +	up_read(&thread->comm_lock);
>  
>  	return str;
>  }
> diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h
> index cf8375c017a0..e97ef6977eb9 100644
> --- a/tools/perf/util/thread.h
> +++ b/tools/perf/util/thread.h
> @@ -76,7 +76,7 @@ static inline void thread__exited(struct thread *thread)
>  	thread->dead = true;
>  }
>  
> -struct namespaces *thread__namespaces(const struct thread *thread);
> +struct namespaces *thread__namespaces(struct thread *thread);
>  int thread__set_namespaces(struct thread *thread, u64 timestamp,
>  			   struct namespaces_event *event);
>  
> @@ -93,7 +93,7 @@ int thread__set_comm_from_proc(struct thread *thread);
>  int thread__comm_len(struct thread *thread);
>  struct comm *thread__comm(const struct thread *thread);
>  struct comm *thread__exec_comm(const struct thread *thread);
> -const char *thread__comm_str(const struct thread *thread);
> +const char *thread__comm_str(struct thread *thread);
>  int thread__insert_map(struct thread *thread, struct map *map);
>  int thread__fork(struct thread *thread, struct thread *parent, u64 timestamp, bool do_maps_clone);
>  size_t thread__fprintf(struct thread *thread, FILE *fp);
> -- 
> 2.22.0.rc1.257.g3120a18244-goog

-- 

- Arnaldo

  reply	other threads:[~2019-05-27 14:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22  5:32 [PATCH 0/3] perf tools: Assorted fixes and cleanups for namespace events Namhyung Kim
2019-05-22  5:32 ` [PATCH 1/3] perf tools: Protect reading thread's namespace Namhyung Kim
2019-05-22 13:18   ` Arnaldo Carvalho de Melo
2019-05-23  2:36     ` Namhyung Kim
2019-05-27  6:11       ` [PATCH 4/3] perf tools: Remove const from thread read accessors Namhyung Kim
2019-05-27 14:15         ` Arnaldo Carvalho de Melo [this message]
2019-05-30  8:07         ` [tip:perf/core] " tip-bot for Namhyung Kim
2019-05-28 21:27   ` [tip:perf/urgent] perf namespace: Protect reading thread's namespace tip-bot for Namhyung Kim
2019-05-22  5:32 ` [PATCH 2/3] perf tools: Add missing swap ops for namespace events Namhyung Kim
2019-05-22 13:23   ` Arnaldo Carvalho de Melo
2019-05-28 21:28   ` [tip:perf/urgent] perf session: " tip-bot for Namhyung Kim
2019-05-22  5:32 ` [PATCH 3/3] perf top: Enable --namespaces option Namhyung Kim
2019-05-22 13:24   ` Arnaldo Carvalho de Melo
2019-05-23  2:42     ` Namhyung Kim
2019-05-30  8:06   ` [tip:perf/core] perf top: Add " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190527141541.GA6417@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=hbathini@linux.vnet.ibm.com \
    --cc=jolsa@redhat.com \
    --cc=kjlx@templeofstupid.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --subject='Re: [PATCH 4/3] perf tools: Remove const from thread read accessors' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.