From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 805E8C04AB3 for ; Mon, 27 May 2019 15:47:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 499EE20815 for ; Mon, 27 May 2019 15:47:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 499EE20815 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:47415 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVHqW-00063e-Jq for qemu-devel@archiver.kernel.org; Mon, 27 May 2019 11:47:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVHon-0005AA-1h for qemu-devel@nongnu.org; Mon, 27 May 2019 11:45:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVHol-0003cB-OT for qemu-devel@nongnu.org; Mon, 27 May 2019 11:45:45 -0400 Received: from 9.mo177.mail-out.ovh.net ([46.105.72.238]:37085) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVHol-0003Ip-Id for qemu-devel@nongnu.org; Mon, 27 May 2019 11:45:43 -0400 Received: from player730.ha.ovh.net (unknown [10.109.143.183]) by mo177.mail-out.ovh.net (Postfix) with ESMTP id E3E02FBE6B for ; Mon, 27 May 2019 17:45:24 +0200 (CEST) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player730.ha.ovh.net (Postfix) with ESMTPSA id F2D9D6191157; Mon, 27 May 2019 15:45:16 +0000 (UTC) Date: Mon, 27 May 2019 17:45:15 +0200 From: Greg Kurz To: Yongji Xie Message-ID: <20190527174515.51912e03@bahia.lan> In-Reply-To: References: <20190520231008.20140-1-mst@redhat.com> <20190320112646.3712-2-xieyongji@baidu.com> <20190524121909.277ae31e@bahia.lan> <20190527124446.6b809c7f@bahia.lan> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 437975066339088685 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddruddvvddgleegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 46.105.72.238 Subject: Re: [Qemu-devel] [PULL v2 04/36] virtio: Introduce started flag to VirtioDevice X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Zhang Yu , "Michael S. Tsirkin" , qemu-devel , Xie Yongji , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 27 May 2019 21:04:38 +0800 Yongji Xie wrote: > On Mon, 27 May 2019 at 18:44, Greg Kurz wrote: > > > > On Fri, 24 May 2019 19:56:06 +0800 > > Yongji Xie wrote: > > > > > On Fri, 24 May 2019 at 18:20, Greg Kurz wrote: > > > > > > > > On Mon, 20 May 2019 19:10:35 -0400 > > > > "Michael S. Tsirkin" wrote: > > > > > > > > > From: Xie Yongji > > > > > > > > > > The virtio 1.0 transitional devices support driver uses the device > > > > > before setting the DRIVER_OK status bit. So we introduce a started > > > > > flag to indicate whether driver has started the device or not. > > > > > > > > > > Signed-off-by: Xie Yongji > > > > > Signed-off-by: Zhang Yu > > > > > Message-Id: <20190320112646.3712-2-xieyongji@baidu.com> > > > > > Reviewed-by: Michael S. Tsirkin > > > > > Signed-off-by: Michael S. Tsirkin > > > > > --- > > > > > include/hw/virtio/virtio.h | 2 ++ > > > > > hw/virtio/virtio.c | 52 ++++++++++++++++++++++++++++++++++++-- > > > > > 2 files changed, 52 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > > > > > index 7140381e3a..27c0efc3d0 100644 > > > > > --- a/include/hw/virtio/virtio.h > > > > > +++ b/include/hw/virtio/virtio.h > > > > > @@ -105,6 +105,8 @@ struct VirtIODevice > > > > > uint16_t device_id; > > > > > bool vm_running; > > > > > bool broken; /* device in invalid state, needs reset */ > > > > > + bool started; > > > > > + bool start_on_kick; /* virtio 1.0 transitional devices support that */ > > > > > VMChangeStateEntry *vmstate; > > > > > char *bus_name; > > > > > uint8_t device_endian; > > > > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > > > > > index 28056a7ef7..5d533ac74e 100644 > > > > > --- a/hw/virtio/virtio.c > > > > > +++ b/hw/virtio/virtio.c > > > > > @@ -1162,10 +1162,16 @@ int virtio_set_status(VirtIODevice *vdev, uint8_t val) > > > > > } > > > > > } > > > > > } > > > > > + vdev->started = val & VIRTIO_CONFIG_S_DRIVER_OK; > > > > > + if (unlikely(vdev->start_on_kick && vdev->started)) { > > > > > + vdev->start_on_kick = false; > > > > > + } > > > > > + > > > > > if (k->set_status) { > > > > > k->set_status(vdev, val); > > > > > } > > > > > vdev->status = val; > > > > > + > > > > > return 0; > > > > > } > > > > > > > > > > @@ -1208,6 +1214,9 @@ void virtio_reset(void *opaque) > > > > > k->reset(vdev); > > > > > } > > > > > > > > > > + vdev->start_on_kick = (virtio_host_has_feature(vdev, VIRTIO_F_VERSION_1) && > > > > > + !virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)); > > > > > + vdev->started = false; > > > > > vdev->broken = false; > > > > > vdev->guest_features = 0; > > > > > vdev->queue_sel = 0; > > > > > @@ -1518,14 +1527,21 @@ void virtio_queue_set_align(VirtIODevice *vdev, int n, int align) > > > > > > > > > > static bool virtio_queue_notify_aio_vq(VirtQueue *vq) > > > > > { > > > > > + bool ret = false; > > > > > + > > > > > if (vq->vring.desc && vq->handle_aio_output) { > > > > > VirtIODevice *vdev = vq->vdev; > > > > > > > > > > trace_virtio_queue_notify(vdev, vq - vdev->vq, vq); > > > > > - return vq->handle_aio_output(vdev, vq); > > > > > + ret = vq->handle_aio_output(vdev, vq); > > > > > + > > > > > + if (unlikely(vdev->start_on_kick)) { > > > > > + vdev->started = true; > > > > > + vdev->start_on_kick = false; > > > > > + } > > > > > } > > > > > > > > > > - return false; > > > > > + return ret; > > > > > } > > > > > > > > > > static void virtio_queue_notify_vq(VirtQueue *vq) > > > > > @@ -1539,6 +1555,11 @@ static void virtio_queue_notify_vq(VirtQueue *vq) > > > > > > > > > > trace_virtio_queue_notify(vdev, vq - vdev->vq, vq); > > > > > vq->handle_output(vdev, vq); > > > > > + > > > > > + if (unlikely(vdev->start_on_kick)) { > > > > > + vdev->started = true; > > > > > + vdev->start_on_kick = false; > > > > > + } > > > > > } > > > > > } > > > > > > > > > > @@ -1556,6 +1577,11 @@ void virtio_queue_notify(VirtIODevice *vdev, int n) > > > > > } else if (vq->handle_output) { > > > > > vq->handle_output(vdev, vq); > > > > > } > > > > > + > > > > > + if (unlikely(vdev->start_on_kick)) { > > > > > + vdev->started = true; > > > > > + vdev->start_on_kick = false; > > > > > + } > > > > > } > > > > > > > > > > uint16_t virtio_queue_vector(VirtIODevice *vdev, int n) > > > > > @@ -1770,6 +1796,13 @@ static bool virtio_broken_needed(void *opaque) > > > > > return vdev->broken; > > > > > } > > > > > > > > > > +static bool virtio_started_needed(void *opaque) > > > > > +{ > > > > > + VirtIODevice *vdev = opaque; > > > > > + > > > > > + return vdev->started; > > > > > > > > Existing machine types don't know about the "virtio/started" subsection. This > > > > breaks migration to older QEMUs if the driver has started the device, ie. most > > > > probably always when it comes to live migration. > > > > > > > > My understanding is that we do try to support backward migration though. It > > > > is a regular practice in datacenters to migrate workloads without having to > > > > take care of the QEMU version. FWIW I had to fix similar issues downstream > > > > many times in the past because customers had filed bugs. > > > > > > > > > > If we do need to support backward migration, for this patch, what I > > > can think of is to only migrate the flag in the case that guest kicks > > > but not set DRIVER_OK. This could fix backward migration in most case. > > > > You mean something like that ? > > > > static bool virtio_started_needed(void *opaque) > > { > > VirtIODevice *vdev = opaque; > > > > return vdev->started && !(vdev->status & VIRTIO_CONFIG_S_DRIVER_OK); > > } > > > > Yes. > > > > Not sure if there is a more general approach... > > > > > > > Another approach would be to only implement the started flag for > > machine version > 4.0. This can be achieved by adding a "use-started" > > property to the base virtio device, true by default and set to > > false by hw_compat_4_0. > > > > If so, the problem that I tried to fix in this patch would still be > exist in old machine type, right? > Yes. > Now I think the first approach may be more reasonable. Blocking a > migration that will cause guest hang instead of allowing that. > Fair enough but it may be difficult for the end user to understand why the migration failed in the first place... What about detecting the hang condition (kick before DRIVER_OK) in the source, add a migration blocker with an explicit message and remove the blocker once DRIVER_OK is set ? > Thanks, > Yongji