From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD866C04AB3 for ; Mon, 27 May 2019 18:00:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8286A20883 for ; Mon, 27 May 2019 18:00:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727089AbfE0SAu (ORCPT ); Mon, 27 May 2019 14:00:50 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:54649 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726657AbfE0SAu (ORCPT ); Mon, 27 May 2019 14:00:50 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hVJvU-0005Dw-Cj; Mon, 27 May 2019 20:00:48 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hVJvT-0008G3-Vv; Mon, 27 May 2019 20:00:47 +0200 Date: Mon, 27 May 2019 20:00:47 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Martin Blumenstingl Cc: Neil Armstrong , linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 04/14] pwm: meson: change MISC_CLK_SEL_WIDTH to MISC_CLK_SEL_MASK Message-ID: <20190527180047.nfsjfqs22coyqmvp@pengutronix.de> References: <20190525181133.4875-1-martin.blumenstingl@googlemail.com> <20190525181133.4875-5-martin.blumenstingl@googlemail.com> <3b61897a-267b-fd6e-181b-a8c7e47918fb@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 27, 2019 at 07:46:43PM +0200, Martin Blumenstingl wrote: > Hi Neil, > > On Mon, May 27, 2019 at 2:26 PM Neil Armstrong wrote: > > > > On 25/05/2019 20:11, Martin Blumenstingl wrote: > > > MISC_CLK_SEL_WIDTH is only used in one place where it's converted into > > > a bit-mask. Rename and change the macro to be a bit-mask so that > > > conversion is not needed anymore. No functional changes intended. > > > > > > Signed-off-by: Martin Blumenstingl > > > --- > > > drivers/pwm/pwm-meson.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c > > > index c62a3ac924d0..84b28ba0f903 100644 > > > --- a/drivers/pwm/pwm-meson.c > > > +++ b/drivers/pwm/pwm-meson.c > > > @@ -33,7 +33,7 @@ > > > #define MISC_A_CLK_DIV_SHIFT 8 > > > #define MISC_B_CLK_SEL_SHIFT 6 > > > #define MISC_A_CLK_SEL_SHIFT 4 > > > -#define MISC_CLK_SEL_WIDTH 2 > > > +#define MISC_CLK_SEL_MASK 0x3 > > > > NIT I would have used GENMASK here > that was my initial idea but I decided against it. > the variant I came up with was: #define MISC_CLK_SEL_MASK GENMASK(1, 0) > > however, the actual offset is either 4 or 6 (depending on the PWM channel) > and I felt that duplicating the macro would just make it more complicated > so instead I chose to be consistent with MISC_CLK_DIV_MASK An option would be: #define MISC_CLK_SEL_MASK(hwid) GENMASK(1 + 4 * (hwid), 0 + 4 * (hwid)) (Note I didn't check a manual to the 4 above is probably wrong.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90F5DC04AB3 for ; Mon, 27 May 2019 18:00:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67E9820883 for ; Mon, 27 May 2019 18:00:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uIYBjtHJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67E9820883 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UyMThFe9KXPdtJQlJA+eqwrD1XdimBr/1yadUce/1rA=; b=uIYBjtHJ85g9a0 g/5dY5R3ExEYp1brB1zINk0BdTxAQ9JYVTTJdsP5mD4vi9OE0u8sG7yd0B6UNuLI7HI3qOUHicx8H SvULkehbc/0gGEBOseTUisT1gjZljMd0gbCxbYqjvIUDHhHA20vWFGDmv2RhqIEQXCFLRd9BKNyxF iE6XDYYpwGTkGSX0oecVTaqYCFz1tXuA4SMm46Gn6fYAW/ADmjGrud0mRfOi7LtQeIQ69y17d9ckI 97G/kHar1H48SNJ8RCGabYwMBLJRAlkGSZr0ZY3EsH6gevPX04TtvdSg1le58RvuOLIAzV8CCU7xY fj2+PBDc3fKZv/lY9k9Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVJvb-0008PI-5G; Mon, 27 May 2019 18:00:55 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVJvX-0008LP-RN for linux-arm-kernel@lists.infradead.org; Mon, 27 May 2019 18:00:53 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hVJvU-0005Dw-Cj; Mon, 27 May 2019 20:00:48 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hVJvT-0008G3-Vv; Mon, 27 May 2019 20:00:47 +0200 Date: Mon, 27 May 2019 20:00:47 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Martin Blumenstingl Subject: Re: [PATCH 04/14] pwm: meson: change MISC_CLK_SEL_WIDTH to MISC_CLK_SEL_MASK Message-ID: <20190527180047.nfsjfqs22coyqmvp@pengutronix.de> References: <20190525181133.4875-1-martin.blumenstingl@googlemail.com> <20190525181133.4875-5-martin.blumenstingl@googlemail.com> <3b61897a-267b-fd6e-181b-a8c7e47918fb@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190527_110052_037142_64DBA3FE X-CRM114-Status: GOOD ( 16.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Neil Armstrong , linux-kernel@vger.kernel.org, thierry.reding@gmail.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 27, 2019 at 07:46:43PM +0200, Martin Blumenstingl wrote: > Hi Neil, > = > On Mon, May 27, 2019 at 2:26 PM Neil Armstrong = wrote: > > > > On 25/05/2019 20:11, Martin Blumenstingl wrote: > > > MISC_CLK_SEL_WIDTH is only used in one place where it's converted into > > > a bit-mask. Rename and change the macro to be a bit-mask so that > > > conversion is not needed anymore. No functional changes intended. > > > > > > Signed-off-by: Martin Blumenstingl > > > --- > > > drivers/pwm/pwm-meson.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c > > > index c62a3ac924d0..84b28ba0f903 100644 > > > --- a/drivers/pwm/pwm-meson.c > > > +++ b/drivers/pwm/pwm-meson.c > > > @@ -33,7 +33,7 @@ > > > #define MISC_A_CLK_DIV_SHIFT 8 > > > #define MISC_B_CLK_SEL_SHIFT 6 > > > #define MISC_A_CLK_SEL_SHIFT 4 > > > -#define MISC_CLK_SEL_WIDTH 2 > > > +#define MISC_CLK_SEL_MASK 0x3 > > > > NIT I would have used GENMASK here > that was my initial idea but I decided against it. > the variant I came up with was: #define MISC_CLK_SEL_MASK GENMASK(1, 0) > = > however, the actual offset is either 4 or 6 (depending on the PWM channel) > and I felt that duplicating the macro would just make it more complicated > so instead I chose to be consistent with MISC_CLK_DIV_MASK An option would be: #define MISC_CLK_SEL_MASK(hwid) GENMASK(1 + 4 * (hwid), 0 + 4 * (hwid)) (Note I didn't check a manual to the 4 above is probably wrong.) Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED326C04AB3 for ; Mon, 27 May 2019 18:01:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5D5B20883 for ; Mon, 27 May 2019 18:01:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lgN9OIDP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5D5B20883 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zx2lC72HHeangDuH7lxJe239HagXamjJD3ZRYDyI3AM=; b=lgN9OIDPaCdzUZ 2+gH4+JVYHkq297lp53jKWnfXG2c7cDWZTS2Q5LtWjYKWUSU6HfWpE6g4FMnSMxrIJKs21N6MZokm 1siLtKT1hflfJsvcRzz32hqrXMxxnOREEIL8GgJQxwDKxJegtUV1F2hC/JH1RtXJzC1oBgQqf4X3Q anMUdQwFqxN6RJdqhrcC1zDfXfuIn5JyZ7aAv2IHT6MZf7Klsypz6ObKYrEaad81sfZw2QrNF6M0K CqWbr24aqLHO7xlBgzaSrGbOb88eZuDxctznszPEap4DhURGt9zfhsuXDb/Eraum8iPJ2sOTa4GkC FR90zFrHDpRDoUyZgqMg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVJvf-00005m-Rx; Mon, 27 May 2019 18:00:59 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVJvX-0008Ks-Qd for linux-amlogic@lists.infradead.org; Mon, 27 May 2019 18:00:53 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hVJvU-0005Dw-Cj; Mon, 27 May 2019 20:00:48 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hVJvT-0008G3-Vv; Mon, 27 May 2019 20:00:47 +0200 Date: Mon, 27 May 2019 20:00:47 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Martin Blumenstingl Subject: Re: [PATCH 04/14] pwm: meson: change MISC_CLK_SEL_WIDTH to MISC_CLK_SEL_MASK Message-ID: <20190527180047.nfsjfqs22coyqmvp@pengutronix.de> References: <20190525181133.4875-1-martin.blumenstingl@googlemail.com> <20190525181133.4875-5-martin.blumenstingl@googlemail.com> <3b61897a-267b-fd6e-181b-a8c7e47918fb@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-amlogic@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190527_110052_015882_815BA254 X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Neil Armstrong , linux-kernel@vger.kernel.org, thierry.reding@gmail.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon, May 27, 2019 at 07:46:43PM +0200, Martin Blumenstingl wrote: > Hi Neil, > = > On Mon, May 27, 2019 at 2:26 PM Neil Armstrong = wrote: > > > > On 25/05/2019 20:11, Martin Blumenstingl wrote: > > > MISC_CLK_SEL_WIDTH is only used in one place where it's converted into > > > a bit-mask. Rename and change the macro to be a bit-mask so that > > > conversion is not needed anymore. No functional changes intended. > > > > > > Signed-off-by: Martin Blumenstingl > > > --- > > > drivers/pwm/pwm-meson.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c > > > index c62a3ac924d0..84b28ba0f903 100644 > > > --- a/drivers/pwm/pwm-meson.c > > > +++ b/drivers/pwm/pwm-meson.c > > > @@ -33,7 +33,7 @@ > > > #define MISC_A_CLK_DIV_SHIFT 8 > > > #define MISC_B_CLK_SEL_SHIFT 6 > > > #define MISC_A_CLK_SEL_SHIFT 4 > > > -#define MISC_CLK_SEL_WIDTH 2 > > > +#define MISC_CLK_SEL_MASK 0x3 > > > > NIT I would have used GENMASK here > that was my initial idea but I decided against it. > the variant I came up with was: #define MISC_CLK_SEL_MASK GENMASK(1, 0) > = > however, the actual offset is either 4 or 6 (depending on the PWM channel) > and I felt that duplicating the macro would just make it more complicated > so instead I chose to be consistent with MISC_CLK_DIV_MASK An option would be: #define MISC_CLK_SEL_MASK(hwid) GENMASK(1 + 4 * (hwid), 0 + 4 * (hwid)) (Note I didn't check a manual to the 4 above is probably wrong.) Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic