From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Lucas Stach <l.stach@pengutronix.de>,
Andrey Gusakov <andrey.gusakov@cogentembedded.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Jyri Sarha <jsarha@ti.com>, Benoit Parrot <bparrot@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: [PATCHv4 17/24] drm/bridge: tc358767: remove check for video mode in link enable
Date: Tue, 28 May 2019 11:27:40 +0300 [thread overview]
Message-ID: <20190528082747.3631-18-tomi.valkeinen@ti.com> (raw)
In-Reply-To: <20190528082747.3631-1-tomi.valkeinen@ti.com>
tc_main_link_enable() checks if videomode has been set, and fails if
there's no videomode. As tc_main_link_enable() no longer depends on the
videomode, we can drop the check.
Also, while tc_stream_enable() does depend on the videomode, we can
expect that a mode has been set before drm_bridge_funcs.enable is
called, so we don't need the check there either.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/gpu/drm/bridge/tc358767.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index 10a9b46de5f1..604e54b90b79 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -773,10 +773,6 @@ static int tc_main_link_enable(struct tc_data *tc)
int ret;
u8 tmp[8];
- /* display mode should be set at this point */
- if (!tc->mode)
- return -EINVAL;
-
dev_dbg(tc->dev, "link enable\n");
tc_read(DP0CTL, &value);
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-05-28 8:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190528082813epcas2p239d993a4286c0a41d2b17d026bf0288b@epcas2p2.samsung.com>
2019-05-28 8:27 ` [PATCHv4 00/24] drm/bridge: tc358767: DP support Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 01/24] drm/bridge: tc358767: fix tc_aux_get_status error handling Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 02/24] drm/bridge: tc358767: reset voltage-swing & pre-emphasis Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 03/24] drm/bridge: tc358767: fix ansi 8b10b use Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 04/24] drm/bridge: tc358767: cleanup spread & scrambler_dis Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 05/24] drm/bridge: tc358767: remove unused swing & preemp Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 06/24] drm/bridge: tc358767: cleanup aux_link_setup Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 07/24] drm/bridge: tc358767: move video stream setup to tc_main_link_stream Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 08/24] drm/bridge: tc358767: split stream enable/disable Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 09/24] drm/bridge: tc358767: move PXL PLL enable/disable to " Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 10/24] drm/bridge: tc358767: add link disable function Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 11/24] drm/bridge: tc358767: disable only video stream in tc_stream_disable Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 12/24] drm/bridge: tc358767: ensure DP is disabled before LT Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 13/24] drm/bridge: tc358767: remove unnecessary msleep Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 14/24] drm/bridge: tc358767: use more reliable seq when finishing LT Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 15/24] drm/bridge: tc358767: cleanup LT result check Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 16/24] drm/bridge: tc358767: clean-up link training Tomi Valkeinen
2019-05-28 8:27 ` Tomi Valkeinen [this message]
2019-05-28 8:27 ` [PATCHv4 18/24] drm/bridge: tc358767: use bridge mode_valid Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 19/24] drm/bridge: tc358767: remove tc_connector_best_encoder Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 20/24] drm/bridge: tc358767: copy the mode data, instead of storing the pointer Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 21/24] drm/bridge: tc358767: read display_props in get_modes() Tomi Valkeinen
2019-05-28 11:54 ` Andrzej Hajda
2019-05-28 8:27 ` [PATCHv4 22/24] drm/bridge: tc358767: add GPIO & interrupt registers Tomi Valkeinen
2019-05-28 8:27 ` [PATCHv4 23/24] drm/bridge: tc358767: add IRQ and HPD support Tomi Valkeinen
2019-05-31 13:38 ` Andrzej Hajda
2019-05-28 8:27 ` [PATCHv4 24/24] dt-bindings: tc358767: add " Tomi Valkeinen
2019-05-31 13:53 ` [PATCHv4 00/24] drm/bridge: tc358767: DP support Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528082747.3631-18-tomi.valkeinen@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=andrew.smirnov@gmail.com \
--cc=andrey.gusakov@cogentembedded.com \
--cc=bparrot@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=l.stach@pengutronix.de \
--cc=p.zabel@pengutronix.de \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.