All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] media-ioc-enum-links.rst: fix incorrect reserved field documentation
Date: Tue, 28 May 2019 11:47:55 +0300	[thread overview]
Message-ID: <20190528084755.2r6zhrzh4r6lbg3p@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <db111993-2071-3023-56c2-1bffc83eb994@xs4all.nl>

On Mon, May 27, 2019 at 11:11:32AM +0200, Hans Verkuil wrote:
> The reserved field array for struct media_link_desc has length 2, not 4.
> 
> And the reserved field array of struct media_links_enum was never documented
> at all.
> 
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

> ---
> diff --git a/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst b/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst
> index a982f16e55a4..b827ebc398f8 100644
> --- a/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst
> +++ b/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst
> @@ -84,6 +84,11 @@ returned during the enumeration process.
>         -  Pointer to a links array allocated by the application. Ignored if
>  	  NULL.
> 
> +    *  -  __u32
> +       -  ``reserved[4]``
> +       -  Reserved for future extensions. Drivers and applications must set
> +          the array to zero.
> +
> 
>  .. c:type:: media_pad_desc
> 
> @@ -135,7 +140,7 @@ returned during the enumeration process.
>         -  Link flags, see :ref:`media-link-flag` for more details.
> 
>      *  -  __u32
> -       -  ``reserved[4]``
> +       -  ``reserved[2]``
>         -  Reserved for future extensions. Drivers and applications must set
>            the array to zero.
> 

-- 
Sakari Ailus

      reply	other threads:[~2019-05-28  8:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27  9:11 [PATCH] media-ioc-enum-links.rst: fix incorrect reserved field documentation Hans Verkuil
2019-05-28  8:47 ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190528084755.2r6zhrzh4r6lbg3p@valkosipuli.retiisi.org.uk \
    --to=sakari.ailus@iki.fi \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.