On Mon, May 27, 2019 at 06:15:20PM -0700, Banajit Goswami wrote:

> having the dev_dbg here are-

> 1. Do not need to enable trace, which helps collecting logs, without much
> know-how

> about audio or kernel

That approach results in kernel logs that are really hard to use and
wrap round far too fast - if everything starts spamming the logs it does
nothing for readability.

> 2. Dynamic debug (using /sys/kernel/debug/dynamic_debug) can be enabled for

> either just this line of code, or, for the function containing this debug
> statement.

> This way, logs can be collected just for the DAPM widget enable/disable, and
> thereby

> avoid having the output logs filled with unwanted logs.

That's into needing to learn about the kernel at which point there's no
real advantage of this approach.

> 3. Though I agree with you about the additional DAPM debug logs being
> present for

> someone who may not be specifically working on Audio, based on the number of

> widgets in the audio path used, the number of prints should be limited to
> only widget

> power on/off.

Some devices are *much* bigger than others, and some systems will start
and stop audio much more frequently than others (things like noises for
taps for example) both of which will massively amplify the noise.  Even
when actively working on audio with those systems logging everything
gets old really fast.