All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: linux@armlinux.org.uk, f.fainelli@gmail.com,
	hkallweit1@gmail.com, maxime.chevallier@bootlin.com,
	olteanv@gmail.com, thomas.petazzoni@bootlin.com,
	davem@davemloft.net, vivien.didelot@gmail.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH 03/11] net: phy: Check against net_device being NULL
Date: Tue, 28 May 2019 17:51:49 +0200	[thread overview]
Message-ID: <20190528155149.GP18059@lunn.ch> (raw)
In-Reply-To: <1558992127-26008-4-git-send-email-ioana.ciornei@nxp.com>

On Tue, May 28, 2019 at 12:21:59AM +0300, Ioana Ciornei wrote:
> In general, we don't want MAC drivers calling phy_attach_direct with the
> net_device being NULL. Add checks against this in all the functions
> calling it: phy_attach() and phy_connect_direct().
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>

I should actually say, once you fix the sparse warnings, you can add:

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  parent reply	other threads:[~2019-05-28 15:51 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27 21:21 [PATCH 00/11] Decoupling PHYLINK from struct net_device Ioana Ciornei
2019-05-27 21:21 ` [PATCH 01/11] net: phy: Add phy_sysfs_create_links helper function Ioana Ciornei
2019-05-27 23:32   ` Fabio Estevam
2019-05-28  6:53     ` Ioana Ciornei
2019-05-27 21:21 ` [PATCH 02/11] net: phy: Guard against the presence of a netdev Ioana Ciornei
2019-05-27 21:21 ` [PATCH 03/11] net: phy: Check against net_device being NULL Ioana Ciornei
2019-05-27 23:07   ` kbuild test robot
2019-05-28  2:27   ` kbuild test robot
2019-05-28 15:50   ` Andrew Lunn
2019-05-28 15:51   ` Andrew Lunn [this message]
2019-05-27 21:22 ` [PATCH 04/11] net: phy: Add phy_standalone sysfs entry Ioana Ciornei
2019-05-28  2:00   ` Florian Fainelli
2019-05-27 21:22 ` [PATCH 05/11] net: phylink: Add phylink_mac_link_{up,down} wrapper functions Ioana Ciornei
2019-05-27 21:22 ` [PATCH 06/11] net: phylink: Add struct phylink_config to PHYLINK API Ioana Ciornei
2019-05-28  1:51   ` Florian Fainelli
2019-05-27 21:22 ` [PATCH 07/11] net: phylink: Add PHYLINK_DEV operation type Ioana Ciornei
2019-05-28  2:01   ` Florian Fainelli
2019-05-28 17:11     ` Ioana Ciornei
2019-05-27 21:22 ` [PATCH 08/11] net: phylink: Add phylink_{printk,err,warn,info,dbg} macros Ioana Ciornei
2019-05-28  1:53   ` Florian Fainelli
2019-05-27 21:22 ` [PATCH 09/11] net: dsa: Move the phylink driver calls into port.c Ioana Ciornei
2019-05-28  2:02   ` Florian Fainelli
2019-05-27 21:22 ` [PATCH 10/11] net: dsa: Use PHYLINK for the CPU/DSA ports Ioana Ciornei
2019-05-28  1:55   ` Florian Fainelli
2019-05-28  3:36   ` kbuild test robot
2019-05-28  3:36   ` [RFC PATCH] net: dsa: dsa_port_phylink_register() can be static kbuild test robot
2019-05-29  2:35   ` [net] 9dd6d07682: kernel_BUG_at_drivers/net/phy/mdio_bus.c kernel test robot
2019-05-29  2:35     ` kernel test robot
2019-05-29 16:11     ` Ioana Ciornei
2019-05-29 16:25       ` Russell King - ARM Linux admin
2019-05-29 20:08         ` Ioana Ciornei
2019-05-29 23:03           ` Andrew Lunn
2019-05-29 23:03             ` Andrew Lunn
2019-05-27 21:22 ` [PATCH 11/11] net: dsa: sja1105: Fix broken fixed-link interfaces on user ports Ioana Ciornei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190528155149.GP18059@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=ioana.ciornei@nxp.com \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.