From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2] fanotify: Disallow permission events for proc filesystem
Date: Tue, 28 May 2019 18:08:18 +0200 [thread overview]
Message-ID: <20190528160818.GB27155@quack2.suse.cz> (raw)
In-Reply-To: <CAOQ4uxi7LKSxcmmbgBpLJgHZFVa56oupQRQvabL4EGM7jfp1mQ@mail.gmail.com>
On Tue 28-05-19 19:02:46, Amir Goldstein wrote:
> On Tue, May 28, 2019 at 6:54 PM Jan Kara <jack@suse.cz> wrote:
> >
> > On Thu 16-05-19 13:56:19, Jan Kara wrote:
> > > Proc filesystem has special locking rules for various files. Thus
> > > fanotify which opens files on event delivery can easily deadlock
> > > against another process that waits for fanotify permission event to be
> > > handled. Since permission events on /proc have doubtful value anyway,
> > > just disallow them.
> > >
> > > Link: https://lore.kernel.org/linux-fsdevel/20190320131642.GE9485@quack2.suse.cz/
> > > Signed-off-by: Jan Kara <jack@suse.cz>
> >
> > Amir, ping? What do you think about this version of the patch?
>
> Sorry, I reviewed but forgot to reply.
> You may add:
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Thanks! I'll push it to my tree for the next merge window then.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2019-05-28 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 11:56 [PATCH v2] fanotify: Disallow permission events for proc filesystem Jan Kara
2019-05-28 15:54 ` Jan Kara
2019-05-28 16:02 ` Amir Goldstein
2019-05-28 16:08 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528160818.GB27155@quack2.suse.cz \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.