From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v3 1/2] dt-bindings: mmc: Add YAML schemas for the generic MMC options Date: Tue, 28 May 2019 19:26:49 +0200 Message-ID: <20190528172649.6mkdkscnu5d2rybi@flea> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Ulf Hansson Cc: Mark Rutland , DTML , Rob Herring , "linux-mmc@vger.kernel.org" , Chen-Yu Tsai , Rob Herring , Frank Rowand , Linux ARM List-Id: devicetree@vger.kernel.org Hi Ulf, On Tue, May 28, 2019 at 10:40:16AM +0200, Ulf Hansson wrote: > > +patternProperties: > > + "^.*@[0-9]+$": > > + properties: > > + reg: > > + items: > > + - minimum: 0 > > + maximum: 7 > > + description: > > + Must contain the SDIO function number of the function this > > + subnode describes. A value of 0 denotes the memory SD > > + function, values from 1 to 7 denote the SDIO functions. > > + > > + broken-hpi: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + Use this to indicate that the mmc-card has a broken hpi > > + implementation, and that hpi should not be used. > > + > > + required: > > + - reg > > + > > [...] > > > -Use of Function subnodes > > ------------------------- > > - > > -On embedded systems the cards connected to a host may need additional > > -properties. These can be specified in subnodes to the host controller node. > > -The subnodes are identified by the standard 'reg' property. > > -Which information exactly can be specified depends on the bindings for the > > -SDIO function driver for the subnode, as specified by the compatible string. > > - > > -Required host node properties when using function subnodes: > > -- #address-cells: should be one. The cell is the slot id. > > -- #size-cells: should be zero. > > - > > -Required function subnode properties: > > -- reg: Must contain the SDIO function number of the function this subnode > > - describes. A value of 0 denotes the memory SD function, values from > > - 1 to 7 denote the SDIO functions. > > - > > -Optional function subnode properties: > > -- compatible: name of SDIO function following generic names recommended practice > > - > > I think most of the information of how we use sub(child) nodes > disappeared in this conversion - or at least gets harder to > understand. Could we perhaps keep some of this? Sure, what would you like to keep in particular? Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27521C04AB6 for ; Tue, 28 May 2019 17:27:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0859216FD for ; Tue, 28 May 2019 17:27:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s2tbFr9L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0859216FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZW8LuDhPuWAI+VKwdAPxcOD+olp9vDEdMnVDvSopofw=; b=s2tbFr9LP3hlYR NU9Nu1iFo9b13RF3oXV58WXTEeMhP0gnVBiyvwlxvWMouEc9CCnnLFwkTthe99GSjWy14G179tGmU C2oMTpV0cQ8FNSksNQsb+7FuR7rTdyj7Er1h6qSQyi16sgR4YJDwFO0ZsfryPZA6bDIL5lyH/ULPX sHyZ8hdTgko25Ul+uuHp+HxvLJPVXkpXI4Ihb/2zjx1UfImmfQOERyyWER9DX1zZSirq2PMcZhvXq Ft9qvy41EPpVp6lkztrLY0HAFAfuoHXN/x33tjve5TJ7O9Oa7SKkIrgZk3R3+M1wfpnX6/JLHpVC+ +3p23Oc1oBBLEjv4PHeA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVfsN-0004ow-BA; Tue, 28 May 2019 17:27:03 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVfsK-0004oc-NP for linux-arm-kernel@lists.infradead.org; Tue, 28 May 2019 17:27:02 +0000 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (Authenticated sender: maxime.ripard@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id CAF27200009; Tue, 28 May 2019 17:26:49 +0000 (UTC) Date: Tue, 28 May 2019 19:26:49 +0200 From: Maxime Ripard To: Ulf Hansson Subject: Re: [PATCH v3 1/2] dt-bindings: mmc: Add YAML schemas for the generic MMC options Message-ID: <20190528172649.6mkdkscnu5d2rybi@flea> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_102700_922414_BA1571A8 X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DTML , Rob Herring , "linux-mmc@vger.kernel.org" , Chen-Yu Tsai , Rob Herring , Frank Rowand , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ulf, On Tue, May 28, 2019 at 10:40:16AM +0200, Ulf Hansson wrote: > > +patternProperties: > > + "^.*@[0-9]+$": > > + properties: > > + reg: > > + items: > > + - minimum: 0 > > + maximum: 7 > > + description: > > + Must contain the SDIO function number of the function this > > + subnode describes. A value of 0 denotes the memory SD > > + function, values from 1 to 7 denote the SDIO functions. > > + > > + broken-hpi: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + Use this to indicate that the mmc-card has a broken hpi > > + implementation, and that hpi should not be used. > > + > > + required: > > + - reg > > + > > [...] > > > -Use of Function subnodes > > ------------------------- > > - > > -On embedded systems the cards connected to a host may need additional > > -properties. These can be specified in subnodes to the host controller node. > > -The subnodes are identified by the standard 'reg' property. > > -Which information exactly can be specified depends on the bindings for the > > -SDIO function driver for the subnode, as specified by the compatible string. > > - > > -Required host node properties when using function subnodes: > > -- #address-cells: should be one. The cell is the slot id. > > -- #size-cells: should be zero. > > - > > -Required function subnode properties: > > -- reg: Must contain the SDIO function number of the function this subnode > > - describes. A value of 0 denotes the memory SD function, values from > > - 1 to 7 denote the SDIO functions. > > - > > -Optional function subnode properties: > > -- compatible: name of SDIO function following generic names recommended practice > > - > > I think most of the information of how we use sub(child) nodes > disappeared in this conversion - or at least gets harder to > understand. Could we perhaps keep some of this? Sure, what would you like to keep in particular? Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel