From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B76A4C04AB6 for ; Tue, 28 May 2019 23:24:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8951C21734 for ; Tue, 28 May 2019 23:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559085842; bh=cjihyfNS4yCB2h/Z4NzAtgFe9LPb9n/+Q0q+iL6WSXQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xselDL/Rat62+sRof9j1CZgwxSM/fdDZNrXWJktwzhmYhs25+0skyhBFkKPcCpKYv WorZgePrYu+e73c2QCNTWxrPQGB0dSVpiMoF/6M6eKzMoxHtZynzz8kUDVmMBtVNfx YWAdW1rN0f2Y0K5o76jUFSh5jNf33gGhGHgAn5X4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726894AbfE1XYB (ORCPT ); Tue, 28 May 2019 19:24:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:60666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726506AbfE1XYB (ORCPT ); Tue, 28 May 2019 19:24:01 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BC18C20B1F; Tue, 28 May 2019 23:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559085840; bh=cjihyfNS4yCB2h/Z4NzAtgFe9LPb9n/+Q0q+iL6WSXQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cLpx3nCWUeMZyl1eVXl6udKfNsH8FmhlZZT/cXaMR2pc1o6lIagaM3Lj3qch/Ar1M xA4yTgNkGZj78ynLOWPdHHpPyZ0YzDQ3NAH+G70otMatrG0GnClmgYoX5YSb4wLIpk ant71oq3pIv8415gvM8x6l5E44ZtKgvrwOvBQvWs= Date: Tue, 28 May 2019 16:24:00 -0700 From: Greg KH To: richard.gong@linux.intel.com Cc: robh+dt@kernel.org, mark.rutland@arm.com, dinguyen@kernel.org, atull@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, sen.li@intel.com, Richard Gong Subject: Re: [PATCHv4 2/4] firmware: add Intel Stratix10 remote system update driver Message-ID: <20190528232400.GB29225@kroah.com> References: <1559074833-1325-1-git-send-email-richard.gong@linux.intel.com> <1559074833-1325-3-git-send-email-richard.gong@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1559074833-1325-3-git-send-email-richard.gong@linux.intel.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 28, 2019 at 03:20:31PM -0500, richard.gong@linux.intel.com wrote: > +static int rsu_send_msg(struct stratix10_rsu_priv *priv, > + enum stratix10_svc_command_code command, > + unsigned long arg, > + void (*callback)(struct stratix10_svc_client *client, > + struct stratix10_svc_cb_data *data)) Odd indentation for arg, and then callback. Why isn't callback a typedef to make this simpler to use? thanks, greg k-h