From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: ferruh.yigit@intel.com, stephen@networkplumber.org, bluca@debian.org
Cc: dev@dpdk.org, Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: [dpdk-dev] [PATCH] common/dpaax: fix i686 compilation issue
Date: Wed, 29 May 2019 12:17:16 +0530 [thread overview]
Message-ID: <20190529064716.14344-1-shreyansh.jain@nxp.com> (raw)
Meson build on i686, part of DPDK CI, reports: (example report [1])
*Meson Failed Build #1:
OS: UB1604-32
Target: i686-native-linuxapp-gcc
../drivers/common/dpaax/dpaax_iova_table.c:121:3: note: in expansion of
macro ‘DPAAX_DEBUG’
DPAAX_DEBUG("Invalid memory node values or count. (size=%lu)",
^
'statbuf.st_size', part of fstat() is a 'off_t' - which should be printable
as '%lu'. But, only a particularly old compiler reports this (5.4.0).
For now, removing the variable being dumped as part of debug.
[1] http://mails.dpdk.org/archives/test-report/2019-May/082622.html
Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table")
Cc: shreyansh.jain@nxp.com
Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
Note:
- Another option was to use the PRIu32 macros but, in absence of a proper
verification environment, I wish to take the safer route. In future, if
need arises, the field would be added to debug logs.
drivers/common/dpaax/dpaax_iova_table.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c
index 2dd38a920..4ba38ac00 100644
--- a/drivers/common/dpaax/dpaax_iova_table.c
+++ b/drivers/common/dpaax/dpaax_iova_table.c
@@ -118,8 +118,7 @@ read_memory_node(unsigned int *count)
*/
*count = (statbuf.st_size / 16);
if ((*count) <= 0 || (statbuf.st_size % 16 != 0)) {
- DPAAX_DEBUG("Invalid memory node values or count. (size=%lu)",
- statbuf.st_size);
+ DPAAX_DEBUG("Invalid memory node values or count. ");
goto cleanup;
}
--
2.17.1
next reply other threads:[~2019-05-29 6:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 6:47 Shreyansh Jain [this message]
2019-05-29 9:17 ` [dpdk-dev] [PATCH] common/dpaax: fix i686 compilation issue Bruce Richardson
2019-05-30 6:47 ` Shreyansh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529064716.14344-1-shreyansh.jain@nxp.com \
--to=shreyansh.jain@nxp.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.