From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 415EEC04AB3 for ; Wed, 29 May 2019 06:52:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3C132081C for ; Wed, 29 May 2019 06:52:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="IJ2bd7ul" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3C132081C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:48373 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVsS4-0001fZ-A7 for qemu-devel@archiver.kernel.org; Wed, 29 May 2019 02:52:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVsQ0-0008Dn-IC for qemu-devel@nongnu.org; Wed, 29 May 2019 02:50:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVsPz-0002YB-Cl for qemu-devel@nongnu.org; Wed, 29 May 2019 02:50:36 -0400 Received: from ozlabs.org ([203.11.71.1]:41027) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVsPz-0002WO-29; Wed, 29 May 2019 02:50:35 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45DLv24llpz9sNy; Wed, 29 May 2019 16:50:22 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1559112622; bh=ytv6+2Za7txhjhng8BTf4vmasxIQT6D/X9uDYVn1uXM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IJ2bd7ulby/dX+GTUchLdBTHVWauVDV/yA0kMbbzMo34TjFDS8/6lIqUM+YRLJTCN n2P6mD+pGgYvgYxhnggnj44CGyOqyYhKZmko6OQWGaVvQUqY778vPUWLCaVoFg76nD WG15NDjg+RRQLQxCYZmLBrpGqJlgsc2QJDDy97sA= From: David Gibson To: peter.maydell@linaro.org Date: Wed, 29 May 2019 16:49:47 +1000 Message-Id: <20190529065017.15149-15-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190529065017.15149-1-david@gibson.dropbear.id.au> References: <20190529065017.15149-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PULL 14/44] spapr/xive: EQ page should be naturally aligned X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson , rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: C=C3=A9dric Le Goater When the OS configures the EQ page in which to receive event notifications from the XIVE interrupt controller, the page should be naturally aligned. Add this check. Signed-off-by: C=C3=A9dric Le Goater Message-Id: <20190508171946.657-2-clg@kaod.org> Reviewed-by: Greg Kurz [dwg: Minor change for printf warning on some platforms] Signed-off-by: David Gibson --- hw/intc/spapr_xive.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/intc/spapr_xive.c b/hw/intc/spapr_xive.c index 097f88d460..33da1a52c6 100644 --- a/hw/intc/spapr_xive.c +++ b/hw/intc/spapr_xive.c @@ -993,6 +993,12 @@ static target_ulong h_int_set_queue_config(PowerPCCP= U *cpu, case 16: case 21: case 24: + if (!QEMU_IS_ALIGNED(qpage, 1ul << qsize)) { + qemu_log_mask(LOG_GUEST_ERROR, "XIVE: EQ @0x%" HWADDR_PRIx + " is not naturally aligned with %" HWADDR_PRIx= "\n", + qpage, (hwaddr)1 << qsize); + return H_P4; + } end.w2 =3D cpu_to_be32((qpage >> 32) & 0x0fffffff); end.w3 =3D cpu_to_be32(qpage & 0xffffffff); end.w0 |=3D cpu_to_be32(END_W0_ENQUEUE); --=20 2.21.0