From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2118DC28CC0 for ; Wed, 29 May 2019 10:06:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DDDAD21881 for ; Wed, 29 May 2019 10:06:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="mn/7Y1LZ"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="XISi7eb0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725990AbfE2KGO (ORCPT ); Wed, 29 May 2019 06:06:14 -0400 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:60151 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725956AbfE2KGN (ORCPT ); Wed, 29 May 2019 06:06:13 -0400 X-Greylist: delayed 510 seconds by postgrey-1.27 at vger.kernel.org; Wed, 29 May 2019 06:06:12 EDT Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id A37261B2A; Wed, 29 May 2019 05:57:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 29 May 2019 05:57:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm1; bh=U v/IO1lpsMhYefZCZE7IzUSu7PAH6TRG1LbnuRgviM4=; b=mn/7Y1LZeF5WEZX9C kyxZtrcWF3ULGfrAWaVTCu5SVtlugVE3VqZmjWKq6xRLw16HfohMo8gWCyfoiTDU 8ddDr3hcah8IDP6Hys4o8IC2EdotB5aWhP8EraoIMIJh7rSxM+BKMMZLl9NkVZnK u8d8d3Tq/d+bMYPb6BDrLZqiB9tpWxyCpNDdk+W8+YDBdrWfUs98RZG9TU53K7Dz JzBTbjFIf3kdd64Cj3KvVjOeVIk0m+zXZwZfm3VO+qvQIqvJ5VIncx8ff7FI9cB1 yNg71nTx/SLC0V1NRLStXOGxLLLNq2SftFdwZcoJwvxVzm0f9yJ9xJHcvbMQXOqS f9JWA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Uv/IO1lpsMhYefZCZE7IzUSu7PAH6TRG1LbnuRgvi M4=; b=XISi7eb0l5udJyx94Grx8xbNBu9uDmTspw9Ab8MZI6lurhPep2RI+RxCG ZQTte0gx97SzC5lbqL/OsmzePdtwqlKhCnCKwx+J0wQH/g8awSkdq4a1owukWtLA pSl7na4swI9Jn5vGwVD9JNDTU+FqQo7zHiwOYrXVPzhmvKU0bhF2leedTKJqnsWJ ZtZ3NyH7sqtqulHulH6p8cFT/inzGk9BoRibxUJQCqYn7HfABDtSJ4wgJtcE93Dn ubSwIKAl5IYPjRHsfy/9y3A9uQnHlGjBxilfoFBwIobYLPZxf0MeJIy/dpZ66Cd6 VespO6do/dcNZaF/vdhqkw+ACdFLw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddruddvjedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjggfsehtkeertddtreejnecuhfhrohhmpefvrghk rghshhhiucfurghkrghmohhtohcuoehoqdhtrghkrghshhhisehsrghkrghmohgttghhih drjhhpqeenucfkphepudegrdefrdejhedrudekudenucfrrghrrghmpehmrghilhhfrhho mhepohdqthgrkhgrshhhihesshgrkhgrmhhotggthhhirdhjphenucevlhhushhtvghruf hiiigvpedt X-ME-Proxy: Received: from workstation (ae075181.dynamic.ppp.asahi-net.or.jp [14.3.75.181]) by mail.messagingengine.com (Postfix) with ESMTPA id 59261380084; Wed, 29 May 2019 05:57:34 -0400 (EDT) Date: Wed, 29 May 2019 18:57:31 +0900 From: Takashi Sakamoto To: Geert Uytterhoeven Cc: Igor Konopko , David Howells , "Mohit P . Tahiliani" , Eran Ben Elisha , Matias Bjorling , Jiri Pirko , "David S . Miller" , Jamal Hadi Salim , Cong Wang , Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , Joe Perches , Arnd Bergmann , Dan Carpenter , linux-block@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] ALSA: fireface: Use ULL suffixes for 64-bit constants Message-ID: <20190529095730.GA7089@workstation> Mail-Followup-To: Geert Uytterhoeven , Igor Konopko , David Howells , "Mohit P . Tahiliani" , Eran Ben Elisha , Matias Bjorling , Jiri Pirko , "David S . Miller" , Jamal Hadi Salim , Cong Wang , Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , Joe Perches , Arnd Bergmann , Dan Carpenter , linux-block@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20190528142424.19626-1-geert@linux-m68k.org> <20190528142424.19626-5-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190528142424.19626-5-geert@linux-m68k.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi, On Tue, May 28, 2019 at 04:24:23PM +0200, Geert Uytterhoeven wrote: > With gcc 4.1: > > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_switch_fetching_mode’: > sound/firewire/fireface/ff-protocol-latter.c:97: warning: integer constant is too large for ‘long’ type > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_begin_session’: > sound/firewire/fireface/ff-protocol-latter.c:170: warning: integer constant is too large for ‘long’ type > sound/firewire/fireface/ff-protocol-latter.c:197: warning: integer constant is too large for ‘long’ type > sound/firewire/fireface/ff-protocol-latter.c:205: warning: integer constant is too large for ‘long’ type > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_finish_session’: > sound/firewire/fireface/ff-protocol-latter.c:214: warning: integer constant is too large for ‘long’ type > > Fix this by adding the missing "ULL" suffixes. > Add the same suffix to the last constant, to maintain consistency. > > Fixes: fd1cc9de64c2ca6c ("ALSA: fireface: add support for Fireface UCX") > Signed-off-by: Geert Uytterhoeven > --- > sound/firewire/fireface/ff-protocol-latter.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Thanks for your care. Reviewed-by: Takashi Sakamoto > diff --git a/sound/firewire/fireface/ff-protocol-latter.c b/sound/firewire/fireface/ff-protocol-latter.c > index c8236ff89b7fb9de..b30d02d359b1d21b 100644 > --- a/sound/firewire/fireface/ff-protocol-latter.c > +++ b/sound/firewire/fireface/ff-protocol-latter.c > @@ -9,11 +9,11 @@ > > #include "ff.h" > > -#define LATTER_STF 0xffff00000004 > -#define LATTER_ISOC_CHANNELS 0xffff00000008 > -#define LATTER_ISOC_START 0xffff0000000c > -#define LATTER_FETCH_MODE 0xffff00000010 > -#define LATTER_SYNC_STATUS 0x0000801c0000 > +#define LATTER_STF 0xffff00000004ULL > +#define LATTER_ISOC_CHANNELS 0xffff00000008ULL > +#define LATTER_ISOC_START 0xffff0000000cULL > +#define LATTER_FETCH_MODE 0xffff00000010ULL > +#define LATTER_SYNC_STATUS 0x0000801c0000ULL > > static int parse_clock_bits(u32 data, unsigned int *rate, > enum snd_ff_clock_src *src) > -- > 2.17.1 > Regards Takashi Sakamoto From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Sakamoto Subject: Re: [PATCH 4/5] ALSA: fireface: Use ULL suffixes for 64-bit constants Date: Wed, 29 May 2019 18:57:31 +0900 Message-ID: <20190529095730.GA7089@workstation> References: <20190528142424.19626-1-geert@linux-m68k.org> <20190528142424.19626-5-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E3EC2F8065A for ; Wed, 29 May 2019 11:57:42 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20190528142424.19626-5-geert@linux-m68k.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Geert Uytterhoeven Cc: linux-block@vger.kernel.org, alsa-devel@alsa-project.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, Arnd Bergmann , netdev@vger.kernel.org, Takashi Iwai , Clemens Ladisch , Jamal Hadi Salim , "David S . Miller" , David Howells , Jiri Pirko , Cong Wang , Joe Perches , "Mohit P . Tahiliani" , Matias Bjorling , Eran Ben Elisha , Dan Carpenter , Igor Konopko List-Id: alsa-devel@alsa-project.org SGksCgpPbiBUdWUsIE1heSAyOCwgMjAxOSBhdCAwNDoyNDoyM1BNICswMjAwLCBHZWVydCBVeXR0 ZXJob2V2ZW4gd3JvdGU6Cj4gV2l0aCBnY2MgNC4xOgo+IAo+ICAgICBzb3VuZC9maXJld2lyZS9m aXJlZmFjZS9mZi1wcm90b2NvbC1sYXR0ZXIuYzogSW4gZnVuY3Rpb24g4oCYbGF0dGVyX3N3aXRj aF9mZXRjaGluZ19tb2Rl4oCZOgo+ICAgICBzb3VuZC9maXJld2lyZS9maXJlZmFjZS9mZi1wcm90 b2NvbC1sYXR0ZXIuYzo5Nzogd2FybmluZzogaW50ZWdlciBjb25zdGFudCBpcyB0b28gbGFyZ2Ug Zm9yIOKAmGxvbmfigJkgdHlwZQo+ICAgICBzb3VuZC9maXJld2lyZS9maXJlZmFjZS9mZi1wcm90 b2NvbC1sYXR0ZXIuYzogSW4gZnVuY3Rpb24g4oCYbGF0dGVyX2JlZ2luX3Nlc3Npb27igJk6Cj4g ICAgIHNvdW5kL2ZpcmV3aXJlL2ZpcmVmYWNlL2ZmLXByb3RvY29sLWxhdHRlci5jOjE3MDogd2Fy bmluZzogaW50ZWdlciBjb25zdGFudCBpcyB0b28gbGFyZ2UgZm9yIOKAmGxvbmfigJkgdHlwZQo+ ICAgICBzb3VuZC9maXJld2lyZS9maXJlZmFjZS9mZi1wcm90b2NvbC1sYXR0ZXIuYzoxOTc6IHdh cm5pbmc6IGludGVnZXIgY29uc3RhbnQgaXMgdG9vIGxhcmdlIGZvciDigJhsb25n4oCZIHR5cGUK PiAgICAgc291bmQvZmlyZXdpcmUvZmlyZWZhY2UvZmYtcHJvdG9jb2wtbGF0dGVyLmM6MjA1OiB3 YXJuaW5nOiBpbnRlZ2VyIGNvbnN0YW50IGlzIHRvbyBsYXJnZSBmb3Ig4oCYbG9uZ+KAmSB0eXBl Cj4gICAgIHNvdW5kL2ZpcmV3aXJlL2ZpcmVmYWNlL2ZmLXByb3RvY29sLWxhdHRlci5jOiBJbiBm dW5jdGlvbiDigJhsYXR0ZXJfZmluaXNoX3Nlc3Npb27igJk6Cj4gICAgIHNvdW5kL2ZpcmV3aXJl L2ZpcmVmYWNlL2ZmLXByb3RvY29sLWxhdHRlci5jOjIxNDogd2FybmluZzogaW50ZWdlciBjb25z dGFudCBpcyB0b28gbGFyZ2UgZm9yIOKAmGxvbmfigJkgdHlwZQo+IAo+IEZpeCB0aGlzIGJ5IGFk ZGluZyB0aGUgbWlzc2luZyAiVUxMIiBzdWZmaXhlcy4KPiBBZGQgdGhlIHNhbWUgc3VmZml4IHRv IHRoZSBsYXN0IGNvbnN0YW50LCB0byBtYWludGFpbiBjb25zaXN0ZW5jeS4KPiAKPiBGaXhlczog ZmQxY2M5ZGU2NGMyY2E2YyAoIkFMU0E6IGZpcmVmYWNlOiBhZGQgc3VwcG9ydCBmb3IgRmlyZWZh Y2UgVUNYIikKPiBTaWduZWQtb2ZmLWJ5OiBHZWVydCBVeXR0ZXJob2V2ZW4gPGdlZXJ0QGxpbnV4 LW02OGsub3JnPgo+IC0tLQo+ICBzb3VuZC9maXJld2lyZS9maXJlZmFjZS9mZi1wcm90b2NvbC1s YXR0ZXIuYyB8IDEwICsrKysrLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygr KSwgNSBkZWxldGlvbnMoLSkKClRoYW5rcyBmb3IgeW91ciBjYXJlLgoKUmV2aWV3ZWQtYnk6IFRh a2FzaGkgU2FrYW1vdG8gPG8tdGFrYXNoaUBzYWthbW9jY2hpLmpwPgoKPiBkaWZmIC0tZ2l0IGEv c291bmQvZmlyZXdpcmUvZmlyZWZhY2UvZmYtcHJvdG9jb2wtbGF0dGVyLmMgYi9zb3VuZC9maXJl d2lyZS9maXJlZmFjZS9mZi1wcm90b2NvbC1sYXR0ZXIuYwo+IGluZGV4IGM4MjM2ZmY4OWI3ZmI5 ZGUuLmIzMGQwMmQzNTliMWQyMWIgMTAwNjQ0Cj4gLS0tIGEvc291bmQvZmlyZXdpcmUvZmlyZWZh Y2UvZmYtcHJvdG9jb2wtbGF0dGVyLmMKPiArKysgYi9zb3VuZC9maXJld2lyZS9maXJlZmFjZS9m Zi1wcm90b2NvbC1sYXR0ZXIuYwo+IEBAIC05LDExICs5LDExIEBACj4gIAo+ICAjaW5jbHVkZSAi ZmYuaCIKPiAgCj4gLSNkZWZpbmUgTEFUVEVSX1NURgkJMHhmZmZmMDAwMDAwMDQKPiAtI2RlZmlu ZSBMQVRURVJfSVNPQ19DSEFOTkVMUwkweGZmZmYwMDAwMDAwOAo+IC0jZGVmaW5lIExBVFRFUl9J U09DX1NUQVJUCTB4ZmZmZjAwMDAwMDBjCj4gLSNkZWZpbmUgTEFUVEVSX0ZFVENIX01PREUJMHhm ZmZmMDAwMDAwMTAKPiAtI2RlZmluZSBMQVRURVJfU1lOQ19TVEFUVVMJMHgwMDAwODAxYzAwMDAK PiArI2RlZmluZSBMQVRURVJfU1RGCQkweGZmZmYwMDAwMDAwNFVMTAo+ICsjZGVmaW5lIExBVFRF Ul9JU09DX0NIQU5ORUxTCTB4ZmZmZjAwMDAwMDA4VUxMCj4gKyNkZWZpbmUgTEFUVEVSX0lTT0Nf U1RBUlQJMHhmZmZmMDAwMDAwMGNVTEwKPiArI2RlZmluZSBMQVRURVJfRkVUQ0hfTU9ERQkweGZm ZmYwMDAwMDAxMFVMTAo+ICsjZGVmaW5lIExBVFRFUl9TWU5DX1NUQVRVUwkweDAwMDA4MDFjMDAw MFVMTAo+ICAKPiAgc3RhdGljIGludCBwYXJzZV9jbG9ja19iaXRzKHUzMiBkYXRhLCB1bnNpZ25l ZCBpbnQgKnJhdGUsCj4gIAkJCSAgICBlbnVtIHNuZF9mZl9jbG9ja19zcmMgKnNyYykKPiAtLSAK PiAyLjE3LjEKPiAKCgpSZWdhcmRzCgpUYWthc2hpIFNha2Ftb3RvCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFs c2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwczovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK