From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 870DBC28CC0 for ; Wed, 29 May 2019 09:03:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E74020B7C for ; Wed, 29 May 2019 09:03:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E74020B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:50244 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVuUl-00088d-1i for qemu-devel@archiver.kernel.org; Wed, 29 May 2019 05:03:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVuTl-0007q4-30 for qemu-devel@nongnu.org; Wed, 29 May 2019 05:02:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVuTk-00015P-3u for qemu-devel@nongnu.org; Wed, 29 May 2019 05:02:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37682) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVuTj-00014B-TX for qemu-devel@nongnu.org; Wed, 29 May 2019 05:02:36 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A6CA5F0D13; Wed, 29 May 2019 09:02:22 +0000 (UTC) Received: from gondolin (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5147B67E72; Wed, 29 May 2019 09:02:00 +0000 (UTC) Date: Wed, 29 May 2019 11:01:57 +0200 From: Cornelia Huck To: Markus Armbruster Message-ID: <20190529110157.777b7040.cohuck@redhat.com> In-Reply-To: <87lfyqla7r.fsf@dusky.pond.sub.org> References: <87lfyqla7r.fsf@dusky.pond.sub.org> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 29 May 2019 09:02:33 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] Headers without multiple inclusion guards X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Dmitry Fleytman , Sagar Karandikar , David Hildenbrand , James Hogan , Anthony Green , Palmer Dabbelt , Mark Cave-Ayland , qemu-devel@nongnu.org, Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Helge Deller , "Michael S. Tsirkin" , Laszlo Ersek , Halil Pasic , Christian Borntraeger , Anthony Perard , Richard Henderson , Jason Wang , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Riku Voipio , Eduardo Habkost , Alistair Francis , Greg Kurz , Marcelo Tosatti , Beniamino Galvani , Eric Auger , Paul Durrant , Stafford Horne , Alex =?UTF-8?B?QmVubsOpZQ==?= , David Gibson , "Daniel P. Berrange" , Claudio Fontana , Bastian Koppelmann , Chris Wulff , Claudio Fontana , Laurent Vivier , Andrew Baumann , Philippe =?UTF-8?B?TWF0aGlldS1EYXVk?= =?UTF-8?B?w6k=?= , Michael Walle , Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno , Philippe =?UTF-8?B?TWF0aGlldS1EYXVk?= =?UTF-8?B?w6k=?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 28 May 2019 20:12:24 +0200 Markus Armbruster wrote: > We have a bunch of headers without multiple inclusion guards. Some are > clearly intentional, some look accidental. Too many for me to find out > by examining each of them, so I'm asking their maintainers. > > Why do I ask? I'd like to mark the intentional ones and fix the > accidental ones, so they don't flunk "make check-headers" from "[RFC v4 > 0/7] Baby steps towards saner headers" just because they lack multiple > inclusion guards. > > Just in case: what's a multiple inclusion guard? It's > > #ifndef UNIQUE_GUARD_SYMBOL_H > #define UNIQUE_GUARD_SYMBOL_H > ... > #endif > > with nothing but comments outside the conditional, so that the header > can safely be included more than once. > > I append the alphabetical list of headers without multiple inclusion > guards (as reported by scripts/clean-header-guards -nv), followed by the > same list sorted into maintainer buckets. If you're cc'ed, please find > your bucket(s), and tell me which headers intentionally lack guards. (...) > S390 > M: Richard Henderson > M: David Hildenbrand > target/s390x/helper.h Intentional, as all target/*/helper.h. (...) > UNMAINTAINED > ------------ (...) > tests/migration/s390x/a-b-bios.h Autogenerated from a-b-bios.c, not intended to be included except in the migration test. [Side note: I probably should include tests/migration/s390x/ to the s390 section in MAINTAINERS so it is no longer 'unmaintained'...]