From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 747C0C28CC0 for ; Wed, 29 May 2019 13:00:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 573F3208CB for ; Wed, 29 May 2019 13:00:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbfE2NAF (ORCPT ); Wed, 29 May 2019 09:00:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:35156 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726889AbfE2NAF (ORCPT ); Wed, 29 May 2019 09:00:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 962DEAEB7; Wed, 29 May 2019 13:00:03 +0000 (UTC) Date: Wed, 29 May 2019 12:59:59 +0000 From: Michal Rostecki To: Sergei Shtylyov Cc: Michal Rostecki , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf] libbpf: Return btf_fd in libbpf__probe_raw_btf Message-ID: <20190529125959.GA31842@wotan.suse.de> References: <20190529082941.9440-1-mrostecki@opensuse.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 29, 2019 at 12:53:42PM +0300, Sergei Shtylyov wrote: > Hello! > > On 29.05.2019 11:29, Michal Rostecki wrote: > > > Function load_sk_storage_btf expects that libbpf__probe_raw_btf is > > returning a btf descriptor, but before this change it was returning > > an information about whether the probe was successful (0 or 1). > > load_sk_storage_btf was using that value as an argument to the close > > function, which was resulting in closing stdout and thus terminating the > > process which used that dunction. > > Function? :-) Opps! I will fix in v2. Thanks!