From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D41EDC28CC0 for ; Wed, 29 May 2019 16:56:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A420E23E7A for ; Wed, 29 May 2019 16:56:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726097AbfE2Q4u (ORCPT ); Wed, 29 May 2019 12:56:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:45334 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726125AbfE2Q4u (ORCPT ); Wed, 29 May 2019 12:56:50 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 0EB39AAA8; Wed, 29 May 2019 16:56:49 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 6BD5EDA85E; Wed, 29 May 2019 18:57:43 +0200 (CEST) Date: Wed, 29 May 2019 18:57:43 +0200 From: David Sterba To: Greg Kroah-Hartman Cc: stable@vger.kernel.org Subject: Re: Please revert "btrfs: Honour FITRIM range constraints during free space trim" from all stable trees Message-ID: <20190529165743.GA15290@suse.cz> Reply-To: dsterba@suse.cz References: <20190529112314.GY15290@suse.cz> <20190529113300.GB11952@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190529113300.GB11952@kroah.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, May 29, 2019 at 04:33:00AM -0700, Greg Kroah-Hartman wrote: > On Wed, May 29, 2019 at 01:23:14PM +0200, David Sterba wrote: > > Hi, > > > > upon closer inspection we found a problem with the patch > > > > "btrfs: Honour FITRIM range constraints during free space trim" > > > > that has been merged to 5.1.4. This could happen with ranged FITRIM > > where the range is not 'honoured' as it was supposed to. > > > > Please revert it and push in the next stable release so the buggy > > version is not in the wild for too long. > > > > Affected trees: > > > > 5.0.18 > > 5.1.4 > > 4.9.179 > > 4.19.45 > > 4.14.122 > > > > Master branch will have the revert too. Thanks. > > What is the git commit id of the revert in Linus's tree? Due to further changes in the code, a revert that will be in Linus' branch can't be backported and stable-specific patches would have to be provided anyway. There's a slight change in logic and handling of the trimmed ranges, the upstream revert removes code and updates calls to functions that are not in the stable branches. So I'm going to send you patches for all the affected branches. After analyzing the situation, the conclusion is that the patch should have never been tagged for stable. The patch is in 5.2-rc ie. an unreleased kernel and the bug would be handled as a regression before 5.20 final. The backport to stable happened before we knew that so the reverts are IMO the best solution we have now. I hope you understand that and sorry for the trouble.