From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09B52C28CC0 for ; Thu, 30 May 2019 19:41:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4B0026105 for ; Thu, 30 May 2019 19:41:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726721AbfE3Tlm (ORCPT ); Thu, 30 May 2019 15:41:42 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:59070 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725897AbfE3Tlm (ORCPT ); Thu, 30 May 2019 15:41:42 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D536F14DA9377; Thu, 30 May 2019 12:41:41 -0700 (PDT) Date: Thu, 30 May 2019 12:41:41 -0700 (PDT) Message-Id: <20190530.124141.171150800649105078.davem@davemloft.net> To: sameehj@amazon.com Cc: netdev@vger.kernel.org, akiyano@amazon.com, dwmw@amazon.com, zorik@amazon.com, matua@amazon.com, saeedb@amazon.com, msw@amazon.com, aliguori@amazon.com, nafea@amazon.com, gtzalik@amazon.com, netanel@amazon.com, alisaidi@amazon.com, benh@amazon.com Subject: Re: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra properties retrieval via get_priv_flags From: David Miller In-Reply-To: <20190529095004.13341-3-sameehj@amazon.com> References: <20190529095004.13341-1-sameehj@amazon.com> <20190529095004.13341-3-sameehj@amazon.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 30 May 2019 12:41:42 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Date: Wed, 29 May 2019 12:49:55 +0300 > @@ -560,6 +564,14 @@ struct ena_admin_set_feature_mtu_desc { > u32 mtu; > }; > > +struct ena_admin_get_extra_properties_strings_desc { > + u32 count; > +}; > + > +struct ena_admin_get_extra_properties_flags_desc { > + u32 flags; > +}; These single entry structures are a big overkill. If anything just do one which is like "ena_value_desc" and has that "u32 val;"