From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE58CC28CC0 for ; Thu, 30 May 2019 00:31:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77A51243A8 for ; Thu, 30 May 2019 00:31:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=who-t.net header.i=@who-t.net header.b="BMvGs1HN"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="mFMO9Ul5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726797AbfE3AbA (ORCPT ); Wed, 29 May 2019 20:31:00 -0400 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]:34159 "EHLO wnew3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726408AbfE3AbA (ORCPT ); Wed, 29 May 2019 20:31:00 -0400 X-Greylist: delayed 508 seconds by postgrey-1.27 at vger.kernel.org; Wed, 29 May 2019 20:30:59 EDT Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id C26A54E2; Wed, 29 May 2019 20:22:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 29 May 2019 20:22:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=who-t.net; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=g y2l4u4y9DJbSbz9jQ5pyBp5nfmgGalhkN7zbzls7JE=; b=BMvGs1HN2F95b5yCi 8mOT4MGkXyX2ES0QDtd/ZLFIgefoS80n4AqXpd8/tgYGYM27uW64aJz29yX/wiyl UjRMH9n7ri2QBXEoQl4AhlfRXgcfnXHrzQ6GjnuOPSJE50/soL0u6LSGEwecFQla 7ejPo/+rBAiZTr/m/az1i2nSbBaCGhRidxaHa4u/T3G81tzXYQvEd9rfAQnRyv1K rzDOAHnXQC7gcVRHkXXdXinuFDsQ4om55+6t2lojwqDP5S1THcIm449cwJfNEcdI WBEPnW2hIRreTrIH0hWWgU4YIofLYekW2WQwybQFhipauIIpS1Dbv8bdriyChWUw JnzPw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=gy2l4u4y9DJbSbz9jQ5pyBp5nfmgGalhkN7zbzls7 JE=; b=mFMO9Ul59waqxnXk5gu4UlayeoYbulXGojRZx7mEZs0uD08zNsYHIgFXA eRcikUSAMuVFx8hOiXwtloNj1Pv5RwvE51LS/yBD0rvAqejcMOajfejY1krcRUBj SZKsVgYolfxrsdOsvt+Z8UBGs5zrJcRY2Re/Lsc8bYoaV8vd7B7CX/THGMX8Vj48 B9BS8u+GKX1hSMK/jXIIPEkc4IZdQZ2WQlUYg8OsMZWW5hoB2GXQ1TwiPIdi79aG XYjHIg5U0uu087WkG8s3JB4ifz4d3iIdeOMpU3oof3AqezALqTqB50/KHIzHcz4N qRz/EvWllTB/XGbUWOI6tMyaWWqlA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddruddvkedgfeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjggfsehtkeertddtreejnecuhfhrohhmpefrvght vghrucfjuhhtthgvrhgvrhcuoehpvghtvghrrdhhuhhtthgvrhgvrhesfihhohdqthdrnh gvtheqnecukfhppeduudejrddvtddrieelrddugedvnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehpvghtvghrrdhhuhhtthgvrhgvrhesfihhohdqthdrnhgvthenucevlhhushhtvg hrufhiiigvpedt X-ME-Proxy: Received: from jelly (117-20-69-142.751445.bne.nbn.aussiebb.net [117.20.69.142]) by mail.messagingengine.com (Postfix) with ESMTPA id 7A5AB380083; Wed, 29 May 2019 20:22:24 -0400 (EDT) Date: Thu, 30 May 2019 10:22:19 +1000 From: Peter Hutterer To: Benjamin Tissoires Cc: Sean O'Brien , Harry Cutts , Dmitry Torokhov , =?utf-8?B?5buW5bSH5qau?= , Rob Herring , Aaron Ma , Hans de Goede , "open list:HID CORE LAYER" , lkml , devicetree@vger.kernel.org Subject: Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height Message-ID: <20190530002219.GA11985@jelly> References: <20190521132712.2818-1-benjamin.tissoires@redhat.com> <20190521132712.2818-9-benjamin.tissoires@redhat.com> <00f901d5143f$f5ea8420$e1bf8c60$@emc.com.tw> <20190528012101.GA193221@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 29, 2019 at 09:16:38AM +0200, Benjamin Tissoires wrote: > On Wed, May 29, 2019 at 2:12 AM Sean O'Brien wrote: > > > > We do still use a maxed out major axis as a signal for a palm in the touchscreen > > logic, but I'm not too concerned because if that axis is maxed out, the contact > > should probably be treated as a palm anyway... > > > > I'm more concerned with this affecting our gesture detection for > > touchpad. It looks > > like this change would cause all contacts to reported as some percentage bigger > > than they are currently. Can you give me an idea of how big that percentage is? > > On the P52, I currently have: > [ +0.000009] max: (3045,1731) drivers/input/mouse/elan_i2c_core.c:428 > [ +0.000003] traces: (24,14) drivers/input/mouse/elan_i2c_core.c:429 > > -> with the computation done in the kernel: > width_ratio: 126 > height_ratio: 123 > > For my average finger, the reported traces are between 4 and 6: > With the ETP_FWIDTH_REDUCE: > Major between 144 to 216 > Minor between 132 to 198 > > Without: > Major between 504 to 756 > Minor between 492 to 738 > > So a rough augmentation of 350% > > For the Synaptics devices (over SMBus), they send the raw value of the > traces, so you will get a major/minor between 2 to 5. Max on these > axes is 15, so we should get the same percentage of value comparing to > the range. > Which is why libinput has a database of which device reports which > pressure/major/minor ranges as otherwise the values are just > impossible to understand. yeah, I've given up on trying to guess finger/thumb/palm sizes. git grep for these quirk names in libinput for the ranges: AttrTouchSizeRange AttrThumbSizeThreshold AttrPalmSizeThreshold There are also matching s/Size/Pressure/ entries for touchpads without major/minor. Looking at the database now, the palm size thresholds range entries are 5 (Wacom) and a set of 800-1600 for apple touchpads. So yeah, all this is really a bit random :) Feel free to steal those entries though and/or add to them where applicable. Cheers, Peter > > > > > On Tue, May 28, 2019 at 11:13 AM Harry Cutts wrote: > > > > > > On Mon, 27 May 2019 at 18:21, Dmitry Torokhov wrote: > > > > > > > > Hi Benjamin, KT, > > > > > > > > On Mon, May 27, 2019 at 11:55:01AM +0800, 廖崇榮 wrote: > > > > > Hi > > > > > > > > > > -----Original Message----- > > > > > From: Benjamin Tissoires [mailto:benjamin.tissoires@redhat.com] > > > > > Sent: Friday, May 24, 2019 5:37 PM > > > > > To: Dmitry Torokhov; KT Liao; Rob Herring; Aaron Ma; Hans de Goede > > > > > Cc: open list:HID CORE LAYER; lkml; devicetree@vger.kernel.org > > > > > Subject: Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height > > > > > > > > > > On Tue, May 21, 2019 at 3:28 PM Benjamin Tissoires wrote: > > > > > > > > > > > > The width/height is actually in the same unit than X and Y. So we > > > > > > should not tamper the data, but just set the proper resolution, so > > > > > > that userspace can correctly detect which touch is a palm or a finger. > > > > > > > > > > > > Signed-off-by: Benjamin Tissoires > > > > > > > > > > > > -- > > > > > > > > > > > > new in v2 > > > > > > --- > > > > > > drivers/input/mouse/elan_i2c_core.c | 11 ++++------- > > > > > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > > > > > > > > > diff --git a/drivers/input/mouse/elan_i2c_core.c > > > > > > b/drivers/input/mouse/elan_i2c_core.c > > > > > > index 7ff044c6cd11..6f4feedb7765 100644 > > > > > > --- a/drivers/input/mouse/elan_i2c_core.c > > > > > > +++ b/drivers/input/mouse/elan_i2c_core.c > > > > > > @@ -45,7 +45,6 @@ > > > > > > #define DRIVER_NAME "elan_i2c" > > > > > > #define ELAN_VENDOR_ID 0x04f3 > > > > > > #define ETP_MAX_PRESSURE 255 > > > > > > -#define ETP_FWIDTH_REDUCE 90 > > > > > > #define ETP_FINGER_WIDTH 15 > > > > > > #define ETP_RETRY_COUNT 3 > > > > > > > > > > > > @@ -915,12 +914,8 @@ static void elan_report_contact(struct elan_tp_data *data, > > > > > > return; > > > > > > } > > > > > > > > > > > > - /* > > > > > > - * To avoid treating large finger as palm, let's reduce the > > > > > > - * width x and y per trace. > > > > > > - */ > > > > > > - area_x = mk_x * (data->width_x - ETP_FWIDTH_REDUCE); > > > > > > - area_y = mk_y * (data->width_y - ETP_FWIDTH_REDUCE); > > > > > > + area_x = mk_x * data->width_x; > > > > > > + area_y = mk_y * data->width_y; > > > > > > > > > > > > major = max(area_x, area_y); > > > > > > minor = min(area_x, area_y); @@ -1123,8 +1118,10 @@ > > > > > > static int elan_setup_input_device(struct elan_tp_data *data) > > > > > > ETP_MAX_PRESSURE, 0, 0); > > > > > > input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0, > > > > > > ETP_FINGER_WIDTH * max_width, 0, 0); > > > > > > + input_abs_set_res(input, ABS_MT_TOUCH_MAJOR, data->x_res); > > > > > > input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0, > > > > > > ETP_FINGER_WIDTH * min_width, 0, 0); > > > > > > + input_abs_set_res(input, ABS_MT_TOUCH_MINOR, data->y_res); > > > > > > > > > > I had a chat with Peter on Wednesday, and he mentioned that this is dangerous as Major/Minor are max/min of the width and height. And given that we might have 2 different resolutions, we would need to do some computation in the kernel to ensure the data is correct with respect to the resolution. > > > > > > > > > > TL;DR: I don't think we should export the resolution there :( > > > > > > > > > > KT, should I drop the patch entirely, or is there a strong argument for keeping the ETP_FWIDTH_REDUCE around? > > > > > I suggest you apply the patch, I have no idea why ETP_FWIDTH_REDUCE existed. > > > > > Our FW team know nothing about ETP_FWIDTH_REDUCE ether. > > > > > > > > > > The only side effect will happen on Chromebook because such computation have stayed in ChromeOS' kernel for four years. > > > > > Chrome's finger/palm threshold may be different from other Linux distribution. > > > > > We will discuss it with Google once the patch picked by chrome and cause something wrong. > > > > > > > > Chrome has logic that contact with maximum major/minor is treated as a > > > > palm, so here the driver (which originally came from Chrome OS) > > > > artificially reduces the contact size to ensure that palm rejection > > > > logic does not trigger. > > > > > > > > I'm adding Harry to confirm whether we are still using this logic and to > > > > see if we can adjust it to be something else. > > > > > > I'm not very familiar with our touchpad code, so adding Sean O'Brien, who is.