From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B739CC072B1 for ; Thu, 30 May 2019 03:55:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D06F24E78 for ; Thu, 30 May 2019 03:55:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559188546; bh=4iId1YHXYivKs1rRk46OLXtUoWdAmRb0lWxyFQEx5tA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=v/OT1dC3JJJkihzEuNzJgo8GuzMHGXXae0AhF0GQohVEKUxpiayBx+DrM6YT7f6f+ V5psImiagr5+RX4owhMvkMPITNlHuLzZjGTo/qDath6v6lrqZxOPJzfFZ6jHE0M+AI MahilrF4TjE4HMwpM/KgrpRmVYKSO0dxDf917780= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732282AbfE3Dzp (ORCPT ); Wed, 29 May 2019 23:55:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:53690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727519AbfE3DTH (ORCPT ); Wed, 29 May 2019 23:19:07 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 62EE324833; Thu, 30 May 2019 03:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186346; bh=4iId1YHXYivKs1rRk46OLXtUoWdAmRb0lWxyFQEx5tA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lkXM8wcDVhlC+EA/6Y9ajIzs1VQoVp7j0da/ZikfN0AZG4npNRGL8mnYNPHz+9x/H 8BkCnFsYxQqQsp57zqBqZIrm9PWHdjXKx+KPieKk/o8QT6g1O05onxGp37LhccnpR+ D+V4Nd5jycGVSMk1jf2tWzk4XY68KgB2c3viCdjA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, kbuild test robot , Sebastian Andrzej Siewior , Linus Torvalds , "Paul E. McKenney" , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Sasha Levin Subject: [PATCH 4.14 080/193] smpboot: Place the __percpu annotation correctly Date: Wed, 29 May 2019 20:05:34 -0700 Message-Id: <20190530030500.020958541@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030446.953835040@linuxfoundation.org> References: <20190530030446.953835040@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit d4645d30b50d1691c26ff0f8fa4e718b08f8d3bb ] The test robot reported a wrong assignment of a per-CPU variable which it detected by using sparse and sent a report. The assignment itself is correct. The annotation for sparse was wrong and hence the report. The first pointer is a "normal" pointer and points to the per-CPU memory area. That means that the __percpu annotation has to be moved. Move the __percpu annotation to pointer which points to the per-CPU area. This change affects only the sparse tool (and is ignored by the compiler). Reported-by: kbuild test robot Signed-off-by: Sebastian Andrzej Siewior Cc: Linus Torvalds Cc: Paul E. McKenney Cc: Peter Zijlstra Cc: Thomas Gleixner Fixes: f97f8f06a49fe ("smpboot: Provide infrastructure for percpu hotplug threads") Link: http://lkml.kernel.org/r/20190424085253.12178-1-bigeasy@linutronix.de Signed-off-by: Ingo Molnar Signed-off-by: Sasha Levin --- include/linux/smpboot.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/smpboot.h b/include/linux/smpboot.h index c174844cf663e..585e777a7f6ef 100644 --- a/include/linux/smpboot.h +++ b/include/linux/smpboot.h @@ -31,7 +31,7 @@ struct smpboot_thread_data; * @thread_comm: The base name of the thread */ struct smp_hotplug_thread { - struct task_struct __percpu **store; + struct task_struct * __percpu *store; struct list_head list; int (*thread_should_run)(unsigned int cpu); void (*thread_fn)(unsigned int cpu); -- 2.20.1