From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 957C1C28CC0 for ; Thu, 30 May 2019 03:21:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 611CD2498A for ; Thu, 30 May 2019 03:21:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186463; bh=YlPrh8K80E/Ugmg5D1lT+uJVwaWCaWzq3kBRQR+V0F4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=m2Y3sNEsETDx25/6wU10jSboow7WeVNgr7rWPVlGZl6wSl4p8iZvfzzgCeE+ub+Xa zcrZSlYti4u94GNvTuPKXKVgyY+CrqAeUQXsLout0G6Z4b4eeUAqMqICA61GnADEYK ke2RkaN3bgc9xmBIVx9kYXiM1b90Gdm4fpH2gpLg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732421AbfE3DVC (ORCPT ); Wed, 29 May 2019 23:21:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:41444 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730602AbfE3DQI (ORCPT ); Wed, 29 May 2019 23:16:08 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4AD252449A; Thu, 30 May 2019 03:16:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186168; bh=YlPrh8K80E/Ugmg5D1lT+uJVwaWCaWzq3kBRQR+V0F4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x0BorF/84yal8Xb78erMdws7QlmkjpYfJ/s/e2Dz7pUlVp4e8yjVX2YLhYNAMh8pK Aevf9kCq09b7sugrarQMd5aFNiot8ivvq+hY0eW+rE6D6Bsdlygd6HcI+mFOUCKA1I A5E9WW9Zc5KcQztHn7q/LUXDPsAMis9BgkGAujsQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Tobin C. Harding" , David Sterba Subject: [PATCH 4.19 021/276] btrfs: sysfs: Fix error path kobject memory leak Date: Wed, 29 May 2019 20:02:59 -0700 Message-Id: <20190530030525.458287378@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030523.133519668@linuxfoundation.org> References: <20190530030523.133519668@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tobin C. Harding commit 450ff8348808a89cc27436771aa05c2b90c0eef1 upstream. If a call to kobject_init_and_add() fails we must call kobject_put() otherwise we leak memory. Calling kobject_put() when kobject_init_and_add() fails drops the refcount back to 0 and calls the ktype release method (which in turn calls the percpu destroy and kfree). Add call to kobject_put() in the error path of call to kobject_init_and_add(). Cc: stable@vger.kernel.org # v4.4+ Reviewed-by: Greg Kroah-Hartman Signed-off-by: Tobin C. Harding Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/extent-tree.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -3911,8 +3911,7 @@ static int create_space_info(struct btrf info->space_info_kobj, "%s", alloc_name(space_info->flags)); if (ret) { - percpu_counter_destroy(&space_info->total_bytes_pinned); - kfree(space_info); + kobject_put(&space_info->kobj); return ret; }