From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F234AC28CC0 for ; Thu, 30 May 2019 03:22:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B70FE249C3 for ; Thu, 30 May 2019 03:22:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186569; bh=IszB0OOQeLjmgoIzz1bL/59sa6EgoYvgOFPYwjoubSg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oUZ/MaUNtcP5QxtISPWKN+bPSBZax1G23yuq2mTUB7tNcOwKwYlEiNqL4C3YxOhOe DVBaxEtLwqKFupFijhwkT/w7jpv4vuLlc423H7XOiawQzBrLn6TKChSYF49vUiQbxd NxPxFrBENg41jsKjsuiMSTHezse+l2k4C/nJMDV4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732932AbfE3DWt (ORCPT ); Wed, 29 May 2019 23:22:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:45024 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730915AbfE3DRG (ORCPT ); Wed, 29 May 2019 23:17:06 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 83BB424667; Thu, 30 May 2019 03:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186225; bh=IszB0OOQeLjmgoIzz1bL/59sa6EgoYvgOFPYwjoubSg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Iq95Njrullp0gRFwafxRL+cuQRoK8jlytBpueQiw9cn4Ijn2+kLTlLOsQbqo+l8th Jc+ouKU/MMsJvrjAkPxBeiHMiHcLow8qDhLNxnvaOZuzWBUlomxb2WN9XUIEskH6Yp sCEQr9bNJ/S5GYucPzUkCuUL0/tjkdzH57sXpAzY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Philipp Zabel , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.19 121/276] media: coda: clear error return value before picture run Date: Wed, 29 May 2019 20:04:39 -0700 Message-Id: <20190530030533.435208596@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030523.133519668@linuxfoundation.org> References: <20190530030523.133519668@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit bbeefa7357a648afe70e7183914c87c3878d528d ] The error return value is not written by some firmware codecs, such as MPEG-2 decode on CodaHx4. Clear the error return value before starting the picture run to avoid misinterpreting unrelated values returned by sequence initialization as error return value. Signed-off-by: Philipp Zabel Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/coda/coda-bit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c index d20d3df5778bc..a3cfefdbee127 100644 --- a/drivers/media/platform/coda/coda-bit.c +++ b/drivers/media/platform/coda/coda-bit.c @@ -1999,6 +1999,9 @@ static int coda_prepare_decode(struct coda_ctx *ctx) /* Clear decode success flag */ coda_write(dev, 0, CODA_RET_DEC_PIC_SUCCESS); + /* Clear error return value */ + coda_write(dev, 0, CODA_RET_DEC_PIC_ERR_MB); + trace_coda_dec_pic_run(ctx, meta); coda_command_async(ctx, CODA_COMMAND_PIC_RUN); -- 2.20.1