From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62A0DC072B1 for ; Thu, 30 May 2019 04:08:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 38BA3250D7 for ; Thu, 30 May 2019 04:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559189316; bh=35T0qHW0GoLyTvKSX60pYUseUsylkpZKu7B/BgGYgcY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jVNcnnjiM0/lCNRBlH3q1DHJhig6Y3qafoNRVwLUI3rlQK/FkhjHpYxVhdUEb/L2F n11oe9PjgsFZ2Z66il7LN3X9igPlvC9ZM5o2hQ1Eqf9fuzfl43Yz5eB7ka3efELPpP oS/ppgfFN6KMQhQn/slks1wT/jpJA7E/j2mg2p1A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726280AbfE3EIe (ORCPT ); Thu, 30 May 2019 00:08:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:45952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731070AbfE3DRT (ORCPT ); Wed, 29 May 2019 23:17:19 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 34183246A1; Thu, 30 May 2019 03:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186238; bh=35T0qHW0GoLyTvKSX60pYUseUsylkpZKu7B/BgGYgcY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VjS+roE4piIDYe8Zci3UU1F1uZuQgYVYVQvMCjRKDrR6Id/xBptFqivXOWe0CARuN mG+GPsUsBQPhK5T+gZlxCnhj9QvajRxUXkc8WDgnMgNtRfkIMpqliOICW5cbq2t96m pCRJnEP2X2x4Jdnx1Zlag8ENLf5opFoSMQaO9o+k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Tony Lindgren , Kishon Vijay Abraham I , Sasha Levin Subject: [PATCH 4.19 148/276] phy: mapphone-mdm6600: add gpiolib dependency Date: Wed, 29 May 2019 20:05:06 -0700 Message-Id: <20190530030534.874778653@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030523.133519668@linuxfoundation.org> References: <20190530030523.133519668@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 208d3423ee463ab257908456f6bbca4024ab63f7 ] gcc points out that when CONFIG_GPIOLIB is disabled, gpiod_get_array_value_cansleep() returns 0 but fails to set its output: drivers/phy/motorola/phy-mapphone-mdm6600.c: In function 'phy_mdm6600_status': drivers/phy/motorola/phy-mapphone-mdm6600.c:220:24: error: 'values[0]' is used uninitialized in this function [-Werror=uninitialized] This could be fixed more generally in gpiolib by returning a failure code, but for this specific case, the easier workaround is to add a gpiolib dependency. Fixes: 5d1ebbda0318 ("phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4") Signed-off-by: Arnd Bergmann Acked-by: Tony Lindgren Signed-off-by: Kishon Vijay Abraham I Signed-off-by: Sasha Levin --- drivers/phy/motorola/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/motorola/Kconfig b/drivers/phy/motorola/Kconfig index 82651524ffb9c..718f8729701df 100644 --- a/drivers/phy/motorola/Kconfig +++ b/drivers/phy/motorola/Kconfig @@ -13,7 +13,7 @@ config PHY_CPCAP_USB config PHY_MAPPHONE_MDM6600 tristate "Motorola Mapphone MDM6600 modem USB PHY driver" - depends on OF && USB_SUPPORT + depends on OF && USB_SUPPORT && GPIOLIB select GENERIC_PHY help Enable this for MDM6600 USB modem to work on Motorola phones -- 2.20.1