From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8B92C072B1 for ; Thu, 30 May 2019 04:06:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD23125085 for ; Thu, 30 May 2019 04:06:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559189168; bh=GZUqsTk4DRyMhsW1KtZI2tC5X5LSHWq2AHH1vJ4K+oM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=h7sXHat3Dv7jl+Gqz9bkV5+XQSfM86/3QntK4WHuTNN3Hq7dV1bQK286JjFMPkltl dlXk7q4z/yv4TmVXmP72jXAWUVVXM8ZpZiqmmBybkyxkhQ6hSh1PGDfdGp1vPF65xI 47EEL7H60JE/XRb9UqY70p8nUU/WGb58tjhGrlgc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726959AbfE3EGH (ORCPT ); Thu, 30 May 2019 00:06:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:47936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727628AbfE3DRh (ORCPT ); Wed, 29 May 2019 23:17:37 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3F5FA246BB; Thu, 30 May 2019 03:17:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186256; bh=GZUqsTk4DRyMhsW1KtZI2tC5X5LSHWq2AHH1vJ4K+oM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PD0rnapvWqFn6yxQ05XwsIaBgxuBsyQfIfmaugVN0n1+MOtoLsIsKbMTYYEr8MM6L oBCmgtChHkCSBu561yWPizbYoX0n7uflqE7B0ADOY5QF1Sy/NCxSTnaCU2US13n3ha 87YWOiHOui9t1vtTkH0dJwWp90Yuk9qfew4qIacM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wen Yang , dri-devel@lists.freedesktop.org ("open list:DRM DRIVERS"), Eric Anholt , Sasha Levin , David Airlie , Daniel Vetter Subject: [PATCH 4.19 185/276] drm/pl111: fix possible object reference leak Date: Wed, 29 May 2019 20:05:43 -0700 Message-Id: <20190530030536.807374138@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030523.133519668@linuxfoundation.org> References: <20190530030523.133519668@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit bc29d3a69d4c1bd1a103e8b3c1ed81b807c1870b ] The call to of_find_matching_node_and_match returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: drivers/gpu/drm/pl111/pl111_versatile.c:333:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 317, but without a corresponding object release within this function. drivers/gpu/drm/pl111/pl111_versatile.c:340:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 317, but without a corresponding object release within this function. drivers/gpu/drm/pl111/pl111_versatile.c:346:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 317, but without a corresponding object release within this function. drivers/gpu/drm/pl111/pl111_versatile.c:354:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 317, but without a corresponding object release within this function. drivers/gpu/drm/pl111/pl111_versatile.c:395:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 317, but without a corresponding object release within this function. drivers/gpu/drm/pl111/pl111_versatile.c:402:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 317, but without a corresponding object release within this function. Signed-off-by: Wen Yang Cc: Eric Anholt (supporter:DRM DRIVER FOR ARM PL111 CLCD) Cc: David Airlie (maintainer:DRM DRIVERS) Cc: Daniel Vetter (maintainer:DRM DRIVERS) Cc: dri-devel@lists.freedesktop.org (open list:DRM DRIVERS) Cc: linux-kernel@vger.kernel.org (open list) Signed-off-by: Eric Anholt Link: https://patchwork.freedesktop.org/patch/msgid/1554307455-40361-6-git-send-email-wen.yang99@zte.com.cn Signed-off-by: Sasha Levin --- drivers/gpu/drm/pl111/pl111_versatile.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/pl111/pl111_versatile.c b/drivers/gpu/drm/pl111/pl111_versatile.c index b9baefdba38a1..1c318ad32a8cd 100644 --- a/drivers/gpu/drm/pl111/pl111_versatile.c +++ b/drivers/gpu/drm/pl111/pl111_versatile.c @@ -330,6 +330,7 @@ int pl111_versatile_init(struct device *dev, struct pl111_drm_dev_private *priv) ret = vexpress_muxfpga_init(); if (ret) { dev_err(dev, "unable to initialize muxfpga driver\n"); + of_node_put(np); return ret; } @@ -337,17 +338,20 @@ int pl111_versatile_init(struct device *dev, struct pl111_drm_dev_private *priv) pdev = of_find_device_by_node(np); if (!pdev) { dev_err(dev, "can't find the sysreg device, deferring\n"); + of_node_put(np); return -EPROBE_DEFER; } map = dev_get_drvdata(&pdev->dev); if (!map) { dev_err(dev, "sysreg has not yet probed\n"); platform_device_put(pdev); + of_node_put(np); return -EPROBE_DEFER; } } else { map = syscon_node_to_regmap(np); } + of_node_put(np); if (IS_ERR(map)) { dev_err(dev, "no Versatile syscon regmap\n"); -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: [PATCH 4.19 185/276] drm/pl111: fix possible object reference leak Date: Wed, 29 May 2019 20:05:43 -0700 Message-ID: <20190530030536.807374138@linuxfoundation.org> References: <20190530030523.133519668@linuxfoundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 652A96E2DD for ; Thu, 30 May 2019 03:17:36 +0000 (UTC) In-Reply-To: <20190530030523.133519668@linuxfoundation.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-kernel@vger.kernel.org Cc: Sasha Levin , David Airlie , Greg Kroah-Hartman , "\"open list:DRM DRIVERS\"" , stable@vger.kernel.org, Wen Yang List-Id: dri-devel@lists.freedesktop.org WyBVcHN0cmVhbSBjb21taXQgYmMyOWQzYTY5ZDRjMWJkMWExMDNlOGIzYzFlZDgxYjgwN2MxODcw YiBdCgpUaGUgY2FsbCB0byBvZl9maW5kX21hdGNoaW5nX25vZGVfYW5kX21hdGNoIHJldHVybnMg YSBub2RlIHBvaW50ZXIgd2l0aApyZWZjb3VudCBpbmNyZW1lbnRlZCB0aHVzIGl0IG11c3QgYmUg ZXhwbGljaXRseSBkZWNyZW1lbnRlZCBhZnRlciB0aGUKbGFzdCB1c2FnZS4KCkRldGVjdGVkIGJ5 IGNvY2NpbmVsbGUgd2l0aCB0aGUgZm9sbG93aW5nIHdhcm5pbmdzOgpkcml2ZXJzL2dwdS9kcm0v cGwxMTEvcGwxMTFfdmVyc2F0aWxlLmM6MzMzOjMtOTogRVJST1I6IG1pc3Npbmcgb2Zfbm9kZV9w dXQ7IGFjcXVpcmVkIGEgbm9kZSBwb2ludGVyIHdpdGggcmVmY291bnQgaW5jcmVtZW50ZWQgb24g bGluZSAzMTcsIGJ1dCB3aXRob3V0IGEgY29ycmVzcG9uZGluZyBvYmplY3QgcmVsZWFzZSB3aXRo aW4gdGhpcyBmdW5jdGlvbi4KZHJpdmVycy9ncHUvZHJtL3BsMTExL3BsMTExX3ZlcnNhdGlsZS5j OjM0MDozLTk6IEVSUk9SOiBtaXNzaW5nIG9mX25vZGVfcHV0OyBhY3F1aXJlZCBhIG5vZGUgcG9p bnRlciB3aXRoIHJlZmNvdW50IGluY3JlbWVudGVkIG9uIGxpbmUgMzE3LCBidXQgd2l0aG91dCBh IGNvcnJlc3BvbmRpbmcgb2JqZWN0IHJlbGVhc2Ugd2l0aGluIHRoaXMgZnVuY3Rpb24uCmRyaXZl cnMvZ3B1L2RybS9wbDExMS9wbDExMV92ZXJzYXRpbGUuYzozNDY6My05OiBFUlJPUjogbWlzc2lu ZyBvZl9ub2RlX3B1dDsgYWNxdWlyZWQgYSBub2RlIHBvaW50ZXIgd2l0aCByZWZjb3VudCBpbmNy ZW1lbnRlZCBvbiBsaW5lIDMxNywgYnV0IHdpdGhvdXQgYSBjb3JyZXNwb25kaW5nIG9iamVjdCBy ZWxlYXNlIHdpdGhpbiB0aGlzIGZ1bmN0aW9uLgpkcml2ZXJzL2dwdS9kcm0vcGwxMTEvcGwxMTFf dmVyc2F0aWxlLmM6MzU0OjItODogRVJST1I6IG1pc3Npbmcgb2Zfbm9kZV9wdXQ7IGFjcXVpcmVk IGEgbm9kZSBwb2ludGVyIHdpdGggcmVmY291bnQgaW5jcmVtZW50ZWQgb24gbGluZSAzMTcsIGJ1 dCB3aXRob3V0IGEgY29ycmVzcG9uZGluZyBvYmplY3QgcmVsZWFzZSB3aXRoaW4gdGhpcyBmdW5j dGlvbi4KZHJpdmVycy9ncHUvZHJtL3BsMTExL3BsMTExX3ZlcnNhdGlsZS5jOjM5NTozLTk6IEVS Uk9SOiBtaXNzaW5nIG9mX25vZGVfcHV0OyBhY3F1aXJlZCBhIG5vZGUgcG9pbnRlciB3aXRoIHJl ZmNvdW50IGluY3JlbWVudGVkIG9uIGxpbmUgMzE3LCBidXQgd2l0aG91dCBhIGNvcnJlc3BvbmRp bmcgb2JqZWN0IHJlbGVhc2Ugd2l0aGluIHRoaXMgZnVuY3Rpb24uCmRyaXZlcnMvZ3B1L2RybS9w bDExMS9wbDExMV92ZXJzYXRpbGUuYzo0MDI6MS03OiBFUlJPUjogbWlzc2luZyBvZl9ub2RlX3B1 dDsgYWNxdWlyZWQgYSBub2RlIHBvaW50ZXIgd2l0aCByZWZjb3VudCBpbmNyZW1lbnRlZCBvbiBs aW5lIDMxNywgYnV0IHdpdGhvdXQgYSBjb3JyZXNwb25kaW5nIG9iamVjdCByZWxlYXNlIHdpdGhp biB0aGlzIGZ1bmN0aW9uLgoKU2lnbmVkLW9mZi1ieTogV2VuIFlhbmcgPHdlbi55YW5nOTlAenRl LmNvbS5jbj4KQ2M6IEVyaWMgQW5ob2x0IDxlcmljQGFuaG9sdC5uZXQ+IChzdXBwb3J0ZXI6RFJN IERSSVZFUiBGT1IgQVJNIFBMMTExIENMQ0QpCkNjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGlu dXguaWU+IChtYWludGFpbmVyOkRSTSBEUklWRVJTKQpDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVs QGZmd2xsLmNoPiAobWFpbnRhaW5lcjpEUk0gRFJJVkVSUykKQ2M6IGRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcgKG9wZW4gbGlzdDpEUk0gRFJJVkVSUykKQ2M6IGxpbnV4LWtlcm5lbEB2 Z2VyLmtlcm5lbC5vcmcgKG9wZW4gbGlzdCkKU2lnbmVkLW9mZi1ieTogRXJpYyBBbmhvbHQgPGVy aWNAYW5ob2x0Lm5ldD4KTGluazogaHR0cHM6Ly9wYXRjaHdvcmsuZnJlZWRlc2t0b3Aub3JnL3Bh dGNoL21zZ2lkLzE1NTQzMDc0NTUtNDAzNjEtNi1naXQtc2VuZC1lbWFpbC13ZW4ueWFuZzk5QHp0 ZS5jb20uY24KU2lnbmVkLW9mZi1ieTogU2FzaGEgTGV2aW4gPHNhc2hhbEBrZXJuZWwub3JnPgot LS0KIGRyaXZlcnMvZ3B1L2RybS9wbDExMS9wbDExMV92ZXJzYXRpbGUuYyB8IDQgKysrKwogMSBm aWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9wbDExMS9wbDExMV92ZXJzYXRpbGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9wbDExMS9wbDExMV92 ZXJzYXRpbGUuYwppbmRleCBiOWJhZWZkYmEzOGExLi4xYzMxOGFkMzJhOGNkIDEwMDY0NAotLS0g YS9kcml2ZXJzL2dwdS9kcm0vcGwxMTEvcGwxMTFfdmVyc2F0aWxlLmMKKysrIGIvZHJpdmVycy9n cHUvZHJtL3BsMTExL3BsMTExX3ZlcnNhdGlsZS5jCkBAIC0zMzAsNiArMzMwLDcgQEAgaW50IHBs MTExX3ZlcnNhdGlsZV9pbml0KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IHBsMTExX2RybV9k ZXZfcHJpdmF0ZSAqcHJpdikKIAkJcmV0ID0gdmV4cHJlc3NfbXV4ZnBnYV9pbml0KCk7CiAJCWlm IChyZXQpIHsKIAkJCWRldl9lcnIoZGV2LCAidW5hYmxlIHRvIGluaXRpYWxpemUgbXV4ZnBnYSBk cml2ZXJcbiIpOworCQkJb2Zfbm9kZV9wdXQobnApOwogCQkJcmV0dXJuIHJldDsKIAkJfQogCkBA IC0zMzcsMTcgKzMzOCwyMCBAQCBpbnQgcGwxMTFfdmVyc2F0aWxlX2luaXQoc3RydWN0IGRldmlj ZSAqZGV2LCBzdHJ1Y3QgcGwxMTFfZHJtX2Rldl9wcml2YXRlICpwcml2KQogCQlwZGV2ID0gb2Zf ZmluZF9kZXZpY2VfYnlfbm9kZShucCk7CiAJCWlmICghcGRldikgewogCQkJZGV2X2VycihkZXYs ICJjYW4ndCBmaW5kIHRoZSBzeXNyZWcgZGV2aWNlLCBkZWZlcnJpbmdcbiIpOworCQkJb2Zfbm9k ZV9wdXQobnApOwogCQkJcmV0dXJuIC1FUFJPQkVfREVGRVI7CiAJCX0KIAkJbWFwID0gZGV2X2dl dF9kcnZkYXRhKCZwZGV2LT5kZXYpOwogCQlpZiAoIW1hcCkgewogCQkJZGV2X2VycihkZXYsICJz eXNyZWcgaGFzIG5vdCB5ZXQgcHJvYmVkXG4iKTsKIAkJCXBsYXRmb3JtX2RldmljZV9wdXQocGRl dik7CisJCQlvZl9ub2RlX3B1dChucCk7CiAJCQlyZXR1cm4gLUVQUk9CRV9ERUZFUjsKIAkJfQog CX0gZWxzZSB7CiAJCW1hcCA9IHN5c2Nvbl9ub2RlX3RvX3JlZ21hcChucCk7CiAJfQorCW9mX25v ZGVfcHV0KG5wKTsKIAogCWlmIChJU19FUlIobWFwKSkgewogCQlkZXZfZXJyKGRldiwgIm5vIFZl cnNhdGlsZSBzeXNjb24gcmVnbWFwXG4iKTsKLS0gCjIuMjAuMQoKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=