From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DCD7C072B1 for ; Thu, 30 May 2019 05:46:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C1892541F for ; Thu, 30 May 2019 05:46:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727154AbfE3Fqp (ORCPT ); Thu, 30 May 2019 01:46:45 -0400 Received: from muru.com ([72.249.23.125]:51828 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726308AbfE3Fqo (ORCPT ); Thu, 30 May 2019 01:46:44 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 2744A8027; Thu, 30 May 2019 05:47:03 +0000 (UTC) Date: Wed, 29 May 2019 22:46:40 -0700 From: Tony Lindgren To: Tomi Valkeinen Cc: Sebastian Reichel , Sebastian Reichel , Pavel Machek , Laurent Pinchart , "H. Nikolaus Schaller" , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Keerthy , Peter Ujfalusi Subject: Re: [PATCHv6 0/4] omapdrm: DSI command mode panel support Message-ID: <20190530054640.GQ5447@atomide.com> References: <20190523200756.25314-1-sebastian.reichel@collabora.com> <60c45d23-de2f-d94a-c3d7-146a2bee538f@ti.com> <20190527112122.GJ5447@atomide.com> <20190528093952.GM5447@atomide.com> <14c6c702-844b-756d-2d97-44e8f5a169df@ti.com> <20190528101847.GN5447@atomide.com> <20190529081038.GP5447@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190529081038.GP5447@atomide.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tony Lindgren [190529 08:11]: > * Tomi Valkeinen [190529 07:06]: > > On 28/05/2019 13:18, Tony Lindgren wrote: > > > > > > My board is x15 rev A3, attached to AM5 EVM. I've also attached my kernel > > > > config. > > > > > > Strange that this is not affecting other x15? I think timer12 would > > > be blocked on HS devices though? > > > > Seems that the kernel config affects. omap2plus_defconfig boots ok. > > OK, this line in your oops: > > Unable to handle kernel paging request at virtual address 5a5a5a5a > > Probably means we hit some slab poison with DEBUG_SLAB set. > Looks like your config boots fine with DEBUG_SLAB disabled > for me. > > As this only happens for timer12, I wonder if we're again > hitting some uncompress issue with corrupted dtb. Changing > u-boot ftdaddr higher up might possibly make it go away. > Or else there's a bug elsewhere :) Oh but CM_WKUPAON_TIMER12_CLKCTRL has no CLKSEL option unlike CM_WKUPAON_TIMER1_CLKCTRL. Below is one part of the fix, but it seems like we're missing handling somewhere as trying to get a non-existing clock should just produce -ENODEV type error. And the clksel should be just handled with assigned-clocks in general, but I think we still need it there until we have drivers/clocksource/ timer drivers updated to boot using early_platform_device. Regards, Tony 8< --------------- diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi --- a/arch/arm/boot/dts/dra7-l4.dtsi +++ b/arch/arm/boot/dts/dra7-l4.dtsi @@ -4450,8 +4450,6 @@ timer12: timer@0 { compatible = "ti,omap5430-timer"; reg = <0x0 0x80>; - clocks = <&wkupaon_clkctrl DRA7_WKUPAON_TIMER12_CLKCTRL 24>; - clock-names = "fck"; interrupts = ; ti,timer-alwon; ti,timer-secure;