From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E4EEC072B1 for ; Thu, 30 May 2019 06:35:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E144025A3C for ; Thu, 30 May 2019 06:35:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qw1P2yCe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727401AbfE3GfA (ORCPT ); Thu, 30 May 2019 02:35:00 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:41688 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbfE3Ge7 (ORCPT ); Thu, 30 May 2019 02:34:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jr8TFbprzSDAQ8IU8dPBj96p3eA/WBFaKx/uITpNZxo=; b=qw1P2yCe/tNQ53IWK8sRhTlQ/ 7BOzfMuds62GDyiMXXH0kaXp1Y+C9rv3rPLSzwvtXfy2QGuFj7Z4GM+RO8YF28VJED1HBAVuJiacv HfYJ8LtXhewzVwZPvZj+5oYXx2zT6rEK1SyEt/ODgaLXdjqFaYQUKil4+7nXra90GSGQk7EXlZj8Y zR8FSrFgCmzAQsmE0qwBRRVez9amvdlg3cLbTtuDXOhSU8dOxHmsBsyayqcOKZhpq7X5TjV0Vtph+ SNe5iYHi6xjjdAMoXuQN3GXfEYLx/kF6PhaP+VsY3yVJyVgoDw6XzDkR0ixeywqN5YUy/hPRiubF1 hBGqc8phQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWEeR-0000fN-4p; Thu, 30 May 2019 06:34:59 +0000 Date: Wed, 29 May 2019 23:34:59 -0700 From: Christoph Hellwig To: Anshuman Khandual Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Mark Rutland , James Morse , Andrey Konovalov Subject: Re: [PATCH 4/4] arm64/mm: Drop vm_fault_t argument from __do_page_fault() Message-ID: <20190530063459.GA2181@infradead.org> References: <1559133285-27986-1-git-send-email-anshuman.khandual@arm.com> <1559133285-27986-5-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1559133285-27986-5-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 29, 2019 at 06:04:45PM +0530, Anshuman Khandual wrote: > __do_page_fault() is over complicated with multiple goto statements. This > cleans up code flow and while there drops the vm_fault_t argument. There is no argument dropped anywhere, just a local variable. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60C4FC072B1 for ; Thu, 30 May 2019 06:35:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FA0A25A3C for ; Thu, 30 May 2019 06:35:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G4yw958S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FA0A25A3C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/qHkL+DLbD6UJvW/xHGS16aTZqG2/32mlxoCboebHXY=; b=G4yw958SmpIMMy Nic5CZLDKq7kcBVhItZsUnNLGX1hLqT9IhVNVH52ScSZfQG3ua4wvN71IAS6ABf541QrGT+n4YRoJ h9AH8DvpMwrlhWMUsTB6b7CEDHxPoX3YUtIiwIZfV4ABilTTQ7ni/XPyFZ+mel7iD6wzLDMUQC/PE VCqTKuYlsJi+J3vsbAHBtYdGKvl7E4wA1xxbA/7L3dGmGxCwMpeOnJYmL+YNX0NfpqdVewaZSWUyW kDgzkM4lOcOgm+OWu1siavY+nTl4uOLaDwvbgsuXeZySxALnt6dncn2c54C1NccTcfzavk7oQIqEC lJZPO3ROXQ5Df8kaZ+Iw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWEeT-0000fg-8F; Thu, 30 May 2019 06:35:01 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWEeR-0000fN-4p; Thu, 30 May 2019 06:34:59 +0000 Date: Wed, 29 May 2019 23:34:59 -0700 From: Christoph Hellwig To: Anshuman Khandual Subject: Re: [PATCH 4/4] arm64/mm: Drop vm_fault_t argument from __do_page_fault() Message-ID: <20190530063459.GA2181@infradead.org> References: <1559133285-27986-1-git-send-email-anshuman.khandual@arm.com> <1559133285-27986-5-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1559133285-27986-5-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, James Morse , Andrey Konovalov , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 29, 2019 at 06:04:45PM +0530, Anshuman Khandual wrote: > __do_page_fault() is over complicated with multiple goto statements. This > cleans up code flow and while there drops the vm_fault_t argument. There is no argument dropped anywhere, just a local variable. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel