From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E3CC28CC0 for ; Thu, 30 May 2019 13:22:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE90323B54 for ; Thu, 30 May 2019 13:22:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726855AbfE3NWy (ORCPT ); Thu, 30 May 2019 09:22:54 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:37842 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbfE3NWy (ORCPT ); Thu, 30 May 2019 09:22:54 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hWL1A-000584-MK; Thu, 30 May 2019 21:22:52 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hWL18-0003W9-AH; Thu, 30 May 2019 21:22:50 +0800 Date: Thu, 30 May 2019 21:22:50 +0800 From: Herbert Xu To: Ondrej Mosnacek Cc: linux-crypto@vger.kernel.org, keyrings@vger.kernel.org, David Howells , Stephan Mueller , Milan Broz , Ondrej Kozina , Daniel Zatovic Subject: Re: [PATCH] crypto: af_alg - implement keyring support Message-ID: <20190530132250.gsbpj3ay4ah4ojw2@gondor.apana.org.au> References: <20190521100034.9651-1-omosnace@redhat.com> <20190530071400.jpadh2fjjaqzyw6m@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, May 30, 2019 at 01:35:06PM +0200, Ondrej Mosnacek wrote: > > Because libkcapi already assumes these values [1] and has code that > uses them. Reserving will allow existing builds of libkcapi to work > correctly once the functionality actually lands in the kernel (if that > ever happens). Of course, it is libkcapi's fault to assume values for > these symbols (in released code) before they are commited in the > kernel, but it seemed easier to just add them along with this patch > rather than creating a confusing situation. > > [1] https://github.com/smuellerDD/libkcapi/blob/master/lib/internal.h#L54 OK but please just leave a gap (or a comment) rather than actually adding these reserved symbols to the kernel. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Date: Thu, 30 May 2019 13:22:50 +0000 Subject: Re: [PATCH] crypto: af_alg - implement keyring support Message-Id: <20190530132250.gsbpj3ay4ah4ojw2@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20190521100034.9651-1-omosnace@redhat.com> <20190530071400.jpadh2fjjaqzyw6m@gondor.apana.org.au> In-Reply-To: To: Ondrej Mosnacek Cc: linux-crypto@vger.kernel.org, keyrings@vger.kernel.org, David Howells , Stephan Mueller , Milan Broz , Ondrej Kozina , Daniel Zatovic On Thu, May 30, 2019 at 01:35:06PM +0200, Ondrej Mosnacek wrote: > > Because libkcapi already assumes these values [1] and has code that > uses them. Reserving will allow existing builds of libkcapi to work > correctly once the functionality actually lands in the kernel (if that > ever happens). Of course, it is libkcapi's fault to assume values for > these symbols (in released code) before they are commited in the > kernel, but it seemed easier to just add them along with this patch > rather than creating a confusing situation. > > [1] https://github.com/smuellerDD/libkcapi/blob/master/lib/internal.h#L54 OK but please just leave a gap (or a comment) rather than actually adding these reserved symbols to the kernel. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt