All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
	Mark Brown <broonie@kernel.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Applied "ASoC: SOF: Intel: hda: use the defined ppcap functions" to the asoc tree
Date: Thu, 30 May 2019 17:33:09 +0100 (BST)	[thread overview]
Message-ID: <20190530163309.C5DFA440046@finisterre.sirena.org.uk> (raw)
In-Reply-To: <20190524190925.5931-10-pierre-louis.bossart@linux.intel.com>

The patch

   ASoC: SOF: Intel: hda: use the defined ppcap functions

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 970c43d1783539b75a5e234ff5e51fc5c888112f Mon Sep 17 00:00:00 2001
From: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>
Date: Fri, 24 May 2019 14:09:25 -0500
Subject: [PATCH] ASoC: SOF: Intel: hda: use the defined ppcap functions

There are already defined ppcap and ppcap interrupt functions, use
the already defined functions for easy code read.

Fixes: 8a300c8fb17 ("ASoC: SOF: Intel: Add HDA controller for Intel DSP")
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/sof/intel/hda.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c
index b1f4db0a6895..92c546e93400 100644
--- a/sound/soc/sof/intel/hda.c
+++ b/sound/soc/sof/intel/hda.c
@@ -544,13 +544,9 @@ int hda_dsp_probe(struct snd_sof_dev *sdev)
 	if (ret < 0)
 		goto free_ipc_irq;
 
-	/* enable DSP features */
-	snd_sof_dsp_update_bits(sdev, HDA_DSP_PP_BAR, SOF_HDA_REG_PP_PPCTL,
-				SOF_HDA_PPCTL_GPROCEN, SOF_HDA_PPCTL_GPROCEN);
-
-	/* enable DSP IRQ */
-	snd_sof_dsp_update_bits(sdev, HDA_DSP_PP_BAR, SOF_HDA_REG_PP_PPCTL,
-				SOF_HDA_PPCTL_PIE, SOF_HDA_PPCTL_PIE);
+	/* enable ppcap interrupt */
+	hda_dsp_ctrl_ppcap_enable(sdev, true);
+	hda_dsp_ctrl_ppcap_int_enable(sdev, true);
 
 	/* initialize waitq for code loading */
 	init_waitqueue_head(&sdev->waitq);
-- 
2.20.1

  reply	other threads:[~2019-05-30 16:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24 19:09 [PATCH v3 0/9] ASoC: SOF: stability fixes Pierre-Louis Bossart
2019-05-24 19:09 ` [PATCH v3 1/9] ASoC: SOF: core: remove DSP after unregistering machine driver Pierre-Louis Bossart
2019-05-28 15:07   ` Applied "ASoC: SOF: core: remove DSP after unregistering machine driver" to the asoc tree Mark Brown
2019-05-24 19:09 ` [PATCH v3 2/9] ASoC: SOF: core: remove snd_soc_unregister_component in case of error Pierre-Louis Bossart
2019-05-28 15:07   ` Applied "ASoC: SOF: core: remove snd_soc_unregister_component in case of error" to the asoc tree Mark Brown
2019-05-24 19:09 ` [PATCH v3 3/9] ASoC: SOF: core: fix error handling with the probe workqueue Pierre-Louis Bossart
2019-05-28 15:07   ` Applied "ASoC: SOF: core: fix error handling with the probe workqueue" to the asoc tree Mark Brown
2019-05-24 19:09 ` [PATCH v3 4/9] ASoC: SOF: pcm: clear hw_params_upon_resume flag correctly Pierre-Louis Bossart
2019-05-28 15:07   ` Applied "ASoC: SOF: pcm: clear hw_params_upon_resume flag correctly" to the asoc tree Mark Brown
2019-05-24 19:09 ` [PATCH v3 5/9] ASoC: SOF: pcm: remove warning - initialize workqueue on open Pierre-Louis Bossart
2019-05-28 15:07   ` Applied "ASoC: SOF: pcm: remove warning - initialize workqueue on open" to the asoc tree Mark Brown
2019-05-24 19:09 ` [PATCH v3 6/9] ASoC: SOF: control: correct the copy size for bytes kcontrol put Pierre-Louis Bossart
2019-05-28 15:07   ` Applied "ASoC: SOF: control: correct the copy size for bytes kcontrol put" to the asoc tree Mark Brown
2019-05-24 19:09 ` [PATCH v3 7/9] ASoC: SOF: ipc: fix a race, leading to IPC timeouts Pierre-Louis Bossart
2019-05-28 15:07   ` Applied "ASoC: SOF: ipc: fix a race, leading to IPC timeouts" to the asoc tree Mark Brown
2019-05-24 19:09 ` [PATCH v3 8/9] ASoC: SOF: Intel: hda: fix the hda init chip Pierre-Louis Bossart
2019-05-28 15:07   ` Applied "ASoC: SOF: Intel: hda: fix the hda init chip" to the asoc tree Mark Brown
2019-05-24 19:09 ` [PATCH v3 9/9] ASoC: SOF: Intel: hda: use the defined ppcap functions Pierre-Louis Bossart
2019-05-30 16:33   ` Mark Brown [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-05-22 16:21 [PATCH v2 10/12] " Pierre-Louis Bossart
2019-06-06 21:27 ` Applied "ASoC: SOF: Intel: hda: use the defined ppcap functions" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190530163309.C5DFA440046@finisterre.sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=yingjiang.zhu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.