From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH] drm/i915: Fix the interpretation of MAX_PRE-EMPHASIS_REACHED bit inorder to pass Link Layer compliance test number 400.3.1.15 Date: Thu, 30 May 2019 14:20:10 -0700 Message-ID: <20190530212010.GC24724@intel.com> References: <20190520232541.16085-1-khaled.almahallawy@intel.com> <20190521132458.GZ24299@intel.com> <20190522192512.GB2502@intel.com> <7d893672dc1ca2941f04f7a34c499760007a252e.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B9FA6E16B for ; Thu, 30 May 2019 21:18:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <7d893672dc1ca2941f04f7a34c499760007a252e.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Almahallawy, Khaled" Cc: "Intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXkgMzAsIDIwMTkgYXQgMTI6MzM6NDBQTSAtMDcwMCwgQWxtYWhhbGxhd3ksIEto YWxlZCB3cm90ZToKPiBPbiBXZWQsIDIwMTktMDUtMjIgYXQgMTI6MjUgLTA3MDAsIE1hbmFzaSBO YXZhcmUgd3JvdGU6Cj4gPiBPbiBUdWUsIE1heSAyMSwgMjAxOSBhdCAwNDoyNDo1OFBNICswMzAw LCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+IE9uIE1vbiwgTWF5IDIwLCAyMDE5IGF0IDA0 OjI1OjQxUE0gLTA3MDAsIEtoYWxlZCBBbG1haGFsbGF3eSB3cm90ZToKPiA+ID4gPiBBY2NvcmRp bmcgdG8gRFAgMS40IHN0YW5kYXJkLCBpZiB0aGUgc291cmNlIHN1cHBvcnRzIGZvdXIgcHJlLQo+ ID4gPiA+IGVtcGhhc2lzIGxldmVscywgdGhlbiB0aGUgc291cmNlIHNoYWxsIHNldCB0aGUgYml0 IE1BWF9QUkUtCj4gPiA+ID4gRU1QSEFTSVNfUkVBQ0hFRCA9IDEgb25seSB3aGVuIHRyYXNtaXR0 ZXIgcHJvZ3JhbW1lZCBQUkUtCj4gPiA+ID4gRU1QSEFTSVNfU0VUIGZpZWxkIChiaXRzIDQ6Mykg dG8gMTFiIChMZXZlbCAzKS4gUHJlLWVtcGhhc2lzCj4gPiA+ID4gbGV2ZWwgMyBpcyB0aGUgbWF4 aW11bSBwcmUtZW1waGFzaXMgbGV2ZWwgdGhhdCB0aGUgc291cmNlCj4gPiA+ID4gc3VwcG9ydHMu Cj4gPiA+ID4gQ3VycmVudGx5IHRoZSBNQVhfUFJFLUVNUEhBU0lTX1JFQUNIRUQgYml0IGlzIGlu dGVycHJldGVkIGFzIHRoZQo+ID4gPiA+IE1heCBQcmUtRW1waGFzaXMgbGV2ZWwgZm9yIGNlcnRh aW4gU3dpbmcgTGV2ZWwuIFRoaXMKPiA+ID4gPiBpbnRlcnByZXRhdGlvbiBmYWlscyBMaW5rIExh eWVyIGNvbXBsaWFuY2UgdGVzdCA0MDAuMy4xLjE1IHN0ZXAKPiA+ID4gPiAxNyBhY2NvcmRpbmcg dG8gdGhlIGZvbGxvd2luZyBGYWlsIGNvbmRpdGlvbjoKPiA+ID4gPiBUUkFJTklOR19MQU5FeF9T RVQuTUFYX1BSRS1FTVBIQVNJU19SRUFDSEVEID0gMSAoY2hlY2sgYWxsIGFjdGl2ZQo+ID4gPiA+ IGxhbmVzKSBhbmQgdGhlIFNvdXJjZSBEVVQgc3VwcG9ydHMgcHJlLWVtcGhhc2lzIGxldmVsIDMg KDkuNWRiKS4KPiA+ID4gCj4gPiA+IEhtbS4gSSBndWVzcyB0aGF0J3MgY29ycmVjdC4gVGhlIHNw ZWMgZG9lc24ndCBzYXkgYW55dGhpbmcgYWJvdXQKPiA+ID4gcGVyLXZzd2luZyBwcmUtZW1waGFz aXMgd2hlbiB0YWxraW5nIGFib3V0IHRoZSAnbWF4IHJlYWNoZWQnIGJpdC4KPiA+ID4gCj4gPiA+ ID4gCj4gPiA+ID4gQ2M6IENsaW50IFRheWxvciA8Q2xpbnRvbi5BLlRheWxvckBpbnRlbC5jb20+ Cj4gPiA+ID4gQ2M6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4g PiA+ID4gU2lnbmVkLW9mZi1ieTogS2hhbGVkIEFsbWFoYWxsYXd5IDxraGFsZWQuYWxtYWhhbGxh d3lAaW50ZWwuY29tPgo+ID4gPiA+IC0tLQo+ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kZGkuYyB8IDIwIC0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiA+ID4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RwLmMgIHwgIDIgKy0KPiA+ID4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAx IGluc2VydGlvbigrKSwgMjEgZGVsZXRpb25zKC0pCj4gPiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiA+ID4gYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gPiA+IGluZGV4IDBhZjQ3ZjM0M2ZhYS4uNjU0MGM5 NzljMDk4IDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rk aS5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+ID4g PiBAQCAtMjIzOSwyNiArMjIzOSw2IEBAIHU4IGludGVsX2RkaV9kcF92b2x0YWdlX21heChzdHJ1 Y3QKPiA+ID4gPiBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQo+ID4gPiA+ICAJCURQX1RSQUlOX1ZP TFRBR0VfU1dJTkdfTUFTSzsKPiA+ID4gPiAgfQo+ID4gPiA+ICAKPiA+ID4gPiAtLyoKPiA+ID4g PiAtICogV2UgYXNzdW1lIHRoYXQgdGhlIGZ1bGwgc2V0IG9mIHByZS1lbXBoYXNpcyB2YWx1ZXMg Y2FuIGJlCj4gPiA+ID4gLSAqIHVzZWQgb24gYWxsIERESSBwbGF0Zm9ybXMuIFNob3VsZCB0aGF0 IGNoYW5nZSB3ZSBuZWVkIHRvCj4gPiA+ID4gLSAqIHJldGhpbmsgdGhpcyBjb2RlLgo+ID4gPiA+ IC0gKi8KPiA+ID4gPiAtdTggaW50ZWxfZGRpX2RwX3ByZV9lbXBoYXNpc19tYXgoc3RydWN0IGlu dGVsX2VuY29kZXIgKmVuY29kZXIsCj4gPiA+ID4gdTggdm9sdGFnZV9zd2luZykKPiA+ID4gPiAt ewo+ID4gPiA+IC0Jc3dpdGNoICh2b2x0YWdlX3N3aW5nICYgRFBfVFJBSU5fVk9MVEFHRV9TV0lO R19NQVNLKSB7Cj4gPiA+ID4gLQljYXNlIERQX1RSQUlOX1ZPTFRBR0VfU1dJTkdfTEVWRUxfMDoK PiA+ID4gPiAtCQlyZXR1cm4gRFBfVFJBSU5fUFJFX0VNUEhfTEVWRUxfMzsKPiA+ID4gPiAtCWNh c2UgRFBfVFJBSU5fVk9MVEFHRV9TV0lOR19MRVZFTF8xOgo+ID4gPiA+IC0JCXJldHVybiBEUF9U UkFJTl9QUkVfRU1QSF9MRVZFTF8yOwo+ID4gPiA+IC0JY2FzZSBEUF9UUkFJTl9WT0xUQUdFX1NX SU5HX0xFVkVMXzI6Cj4gPiA+ID4gLQkJcmV0dXJuIERQX1RSQUlOX1BSRV9FTVBIX0xFVkVMXzE7 Cj4gPiA+ID4gLQljYXNlIERQX1RSQUlOX1ZPTFRBR0VfU1dJTkdfTEVWRUxfMzoKPiA+ID4gPiAt CWRlZmF1bHQ6Cj4gPiA+ID4gLQkJcmV0dXJuIERQX1RSQUlOX1BSRV9FTVBIX0xFVkVMXzA7Cj4g PiA+ID4gLQl9Cj4gPiA+ID4gLX0KPiA+ID4gPiAtCj4gPiA+ID4gIHN0YXRpYyB2b2lkIGNubF9k ZGlfdnN3aW5nX3Byb2dyYW0oc3RydWN0IGludGVsX2VuY29kZXIKPiA+ID4gPiAqZW5jb2RlciwK PiA+ID4gPiAgCQkJCSAgIGludCBsZXZlbCwgZW51bSBpbnRlbF9vdXRwdXRfdHlwZQo+ID4gPiA+ IHR5cGUpCj4gPiA+ID4gIHsKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHAuYwo+ID4gPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ ID4gPiA+IGluZGV4IDc3YmE0ZGE2Yjk4MS4uZjk0NzU5ZTQ1ODYyIDEwMDY0NAo+ID4gPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ID4gPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+ID4gQEAgLTM1NDEsNyArMzU0MSw3IEBAIGlu dGVsX2RwX3ByZV9lbXBoYXNpc19tYXgoc3RydWN0IGludGVsX2RwCj4gPiA+ID4gKmludGVsX2Rw LCB1OCB2b2x0YWdlX3N3aW5nKQo+ID4gPiA+ICAJZW51bSBwb3J0IHBvcnQgPSBlbmNvZGVyLT5w b3J0Owo+ID4gPiA+ICAKPiA+ID4gPiAgCWlmIChIQVNfRERJKGRldl9wcml2KSkgewo+ID4gPiA+ IC0JCXJldHVybiBpbnRlbF9kZGlfZHBfcHJlX2VtcGhhc2lzX21heChlbmNvZGVyLAo+ID4gPiA+ IHZvbHRhZ2Vfc3dpbmcpOwo+ID4gPiA+ICsJCXJldHVybiBEUF9UUkFJTl9QUkVfRU1QSF9MRVZF TF8zOwo+ID4gPiAKPiA+ID4gV2UncmUgZ29pbmcgdG8gaGF2ZSB0byBjaGFuZ2UgdGhpcyBmb3Ig YWxsIHBsYXRmb3Jtcy4KPiAKPiBZZXMsIEknbSBnb2luZyB0byBjaGFuZ2UgZm9yIGFsbCBwbGF0 Zm9ybXMgaW4gaW50ZWxfZHBfcHJlX2VtcGhhc2lzX21heAo+IGZ1bmN0aW9uLiBJIHdpbGwgYWxz byBhZGQgdGhlIG1pc3NpbmcgY29uZGl0aW9uOgo+IAllbHNlIGlmIChIQVNfUENIX0NQVChkZXZf cHJpdikgJiYgcG9ydCAhPSBQT1JUX0EpIAo+IHNpbWlsYXIgdG8gaW50ZWxfZHBfdm9sdGFnZV9t YXggZnVuY3Rpb24KPiAKPiA+ID4gCj4gPiA+IEFsc28gd2UgbmVlZCB0byB1cGRhdGUgdGhlIGNv ZGUgdG8gcGljayB0aGUgY29ycmVjdCBzd2luZy9wcmUtCj4gPiA+IGVtcGhhc2lzCj4gPiA+IHdo ZW4gd2UgY2FuJ3QgZG8gd2hhdCBpcyBiZWluZyByZXF1ZXN0ZWQuCj4gPiAKPiA+IFRoaXMgY2hl Y2sgd2lsbCBuZWVkIHRvIGJlIGFkZGVkIGluIGFkanVzdF90cmFpbigpIGZ1bmN0aW9uCj4gCj4g c3VyZSwgSSB3aWxsIGltcGxlbWVudCB0aGlzIGxvZ2ljIGluIGludGVsX2dldF9hZGp1c3RfdHJh aW4KPiA+IAo+ID4gPiAKPiA+ID4gVGhlIHNwZWMgc2F5czoKPiA+ID4gIldoZW4gdGhlIGNvbWJp bmF0aW9uIG9mIHRoZSByZXF1ZXN0ZWQgcHJlLWVtcGhhc2lzIGxldmVsIGFuZAo+ID4gPiB2b2x0 YWdlCj4gPiA+ICBzd2luZyBleGNlZWRzIHRoZSBjYXBhYmlsaXR5IG9mIGEgRFBUWCwgdGhlIERQ VFggc2hhbGwgc2V0IHRoZQo+ID4gPiBwcmUtZW1waGFzaXMKPiA+ID4gIGxldmVsIGFjY29yZGlu ZyB0byB0aGUgcmVxdWVzdCBhbmQgdXNlIHRoZSBoaWdoZXN0IHZvbHRhZ2Ugc3dpbmcKPiA+ID4g aXQgY2FuCj4gPiA+ICBvdXRwdXQgd2l0aCB0aGUgZ2l2ZW4gcHJlLWVtcGhhc2lzIGxldmVsLiIK PiA+ID4gYW5kCj4gPiA+ICJXaGVuIGEgRFBUWCByZWFkcyBhIHJlcXVlc3QgYmV5b25kIHRoZSBs aW1pdHMgb2YgdGhpcyBTdGFuZGFyZCwKPiA+ID4gdGhlCj4gPiA+ICBEUFRYIHNoYWxsIHNldCB0 aGUgcHJlLWVtcGhhc2lzIGxldmVsIGFjY29yZGluZyB0byB0aGUgcmVxdWVzdCBhbmQKPiA+ID4g c2V0Cj4gPiA+ICB0aGUgaGlnaGVzdCB2b2x0YWdlIHN3aW5nIGxldmVsIGl0IGNhbiBvdXRwdXQg d2l0aCB0aGUgZ2l2ZW4gcHJlLQo+ID4gPiBlbXBoYXNpcwo+ID4gPiAgbGV2ZWwuIElmIGEgRFBU WCBpcyByZXF1ZXN0ZWQgZm9yIDkuNWRCIG9mIHByZS1lbXBoYXNpcyBsZXZlbCAobWF5Cj4gPiA+ IGJlIAo+ID4gPiAgc3VwcG9ydGVkIGZvciBhIERQVFgpIGFuZCBjYW5ub3Qgc3VwcG9ydCB0aGF0 IGxldmVsLCBpdCBzaGFsbCBzZXQKPiA+ID4gdGhlCj4gPiA+ICBwcmUtZW1waGFzaXMgbGV2ZWwg dG8gdGhlIG5leHQgaGlnaGVzdCBsZXZlbCwgNmRCLiIKPiA+IAo+ID4gU28gbXkgaW50ZXJwcmV0 YXRpb24gb2YgdGhpcyBpcyA6Cj4gPiAKPiA+IEluIGFkanVzdF90cmFpbigpIGZ1bmN0aW9uOgo+ ID4gCj4gPiB2c3dpbmdfbWF4ID0gaW50ZWxfZHBfdm9sdGFnZV9tYXgoKSB3aGljaCBpcyBzZXQg cGVyIHBsYXRmb3JtCj4gPiBwcmVfZW1waGFzaXNfbWF4ID0gc2V0IHRvIGxldmVsIDMgCj4gIAo+ IAlwcmVfZW1waGFzaXNfbWF4ID0gaW50ZWxfZHBfcHJlX2VtcGhhc2lzX21heCAKPiBiZWNhdXNl IGl0IGlzIHNldCBwZXIgcGxhdGZyb20gYXMgd2VsbCwgc2ltaWxhciB0byB2c3dpbmdfbWF4Cj4g Cj4gPiAgCj4gPiB2ID0gZ2V0X3JlcXVlc3RlZF92b2x0YWdlX3N3aW5nKCkgLSBMaW1pdCB0aGlz IHRvIHZtYXgKPiA+IHAgPSBnZXRfcmVxdWVzdGVkX3ByZV9lbXBoYXNpcygpIC0gTGltaXQgdGhp cyB0byBwbWF4Cj4gPiAKPiA+IE5vdyByZXdyaXRlIHRoZSBpbnRlbF9kZGlfZHBfcHJlX2VtcGhh c2lzX21heCgpIGZ1bmN0aW9uIHRvIGNhbGwgaXQgCj4gCj4gaW50ZWxfZGRpX2RwX3ByZV9lbXBo YXNpc19tYXggaXMgbmVlZGVkIHRvIGRldGVybWluZSB0aGUgbWF4IHByZS0KPiBlbXBoYXNpcyBs ZXZlbCBwZXIgcGxhdGZvcm0uCgpXaGF0IEkgbWVhbnQgd2FzIHRoYXQgZGVmaW5lIGFub3RoZXIg ZnVuY3Rpb24gdGhhdCB3aWxsIHJldHVybiBhIHByZV9lbXBoYXNpc19tYXgKcGVyIHBsYXRmb3Jt IGJ1dCBpbmRlcGVuZGVudCBvZiB0aGUgdnN3aW5nIHZhbHVlcy4KTWFrZXMgc2Vuc2U/CgpNYW5h c2kKCj4gCj4gPiBpbnRlbF9kZGlfZHBfcG9zc2libGVfdnN3aW5nX21heCgpCj4gCj4gSSB0aGlu ayB0aGUgbG9naWMgZm9yIGNob29zaW5nIHRoZSBjb3JyZWN0IHZzd2luZy9lbXBoYXNpcyBjb21i aW5hdGlvbgo+IHNob3VsZCBiZSBpbiBhIGRpZmZlcmVudCBmdW5jdGlvbiwgYXMgeW91IHN1Z2dl c3RlZCBpdCBjYW4gYmUgaW4KPiBpbnRlbF9kZGlfZHBfcG9zc2libGVfdnN3aW5nX21heAo+IAo+ IFRoYW5rcwo+IEtoYWxlZAo+IAo+ID4gd2hlcmUgd2Ugc2V0IHRoZSBwb3NzaWJsZSB2c3dpbmcg bWF4IGJhc2VkIG9uIHJlcXVlc3RlZCBwcmUgZW1waGFzaXMKPiA+IGFuZCB0YWJsZSBpbiB0aGUg YnNwZWMKPiA+IEVnOiBpZiByZXF1ZXN0ZWQgcHJlIGVtcGhhc2lzIGlzIDMsIHRoZSB2c3dpbmcg aXMgMCB3aGljaCBpcyB0aGUgbWF4Cj4gPiB2c3dpbmcgdmFsdWUKPiA+IGl0IGNhbiBvdXB1dCB3 aXRoIHRoYXQgcHJlIGVtcGhhc2lzIGxldmVsIGJhc2VkIG9uIHRoZSBic3BlYyB2c3dpbmcKPiA+ IHByb2dyYW1taW5nIHZhbHVlcwo+ID4gCj4gPiBTZXQgdiA9IHRoYXQgdmFsdWUKPiA+IHAgPSBy ZXF1ZXN0ZWQKPiA+IAo+ID4gTGluayB0cmFpbgo+ID4gCj4gPiBWaWxsZSwgaXMgdGhpcyBsb2dp YyBjb3JyZWN0PyAKPiA+IAo+ID4gUmVnYXJkcwo+ID4gTWFuYXNpCj4gPiAKPiA+IAo+ID4gPiAK PiA+ID4gCj4gPiA+IAo+ID4gPiA+ICAJfSBlbHNlIGlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2 KSB8fCBJU19DSEVSUllWSUVXKGRldl9wcml2KSkKPiA+ID4gPiB7Cj4gPiA+ID4gIAkJc3dpdGNo ICh2b2x0YWdlX3N3aW5nICYgRFBfVFJBSU5fVk9MVEFHRV9TV0lOR19NQVNLKSB7Cj4gPiA+ID4g IAkJY2FzZSBEUF9UUkFJTl9WT0xUQUdFX1NXSU5HX0xFVkVMXzA6Cj4gPiA+ID4gLS0gCj4gPiA+ ID4gMi4xNy4xCj4gPiA+ID4gCj4gPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiA+ID4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiA+ID4g SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiA+IGh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gPiA+IAo+ID4gPiAtLSAK PiA+ID4gVmlsbGUgU3lyasOkbMOkCj4gPiA+IEludGVsCj4gPiA+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+IEludGVsLWdmeCBtYWlsaW5nIGxp c3QKPiA+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiBodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IAo+IApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=