From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B236C04AB6 for ; Fri, 31 May 2019 09:07:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34D012666D for ; Fri, 31 May 2019 09:07:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=yadro.com header.i=@yadro.com header.b="ZWXV53Rs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726992AbfEaJHI (ORCPT ); Fri, 31 May 2019 05:07:08 -0400 Received: from mta-01.yadro.com ([89.207.88.251]:46386 "EHLO mta-01.yadro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbfEaJHI (ORCPT ); Fri, 31 May 2019 05:07:08 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id 3F5C941908; Fri, 31 May 2019 09:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= user-agent:in-reply-to:content-disposition:content-type :content-type:mime-version:references:message-id:subject:subject :from:from:date:date:received:received:received; s=mta-01; t= 1559293624; x=1561108025; bh=V2JYksw1ZpPn49A8Zy8oL1DLxXqIFwPGBxx 0ZykK3RM=; b=ZWXV53Rs0HjRaijj7GccsS27X91FsXvdCKAEkgTbszlF1SNFbNu Recqa8xL9JFDzJdRk3eJxRKLci3VsBho2OKC8FptW7OC7vYdPcFzgSYGEaysKFa/ uK7ox0LWLrCaYusGi/w5tqL6QflmSBAJeZPP3j2nCnQuwBn4Ul8TRqDs= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FeODQLn3iRyt; Fri, 31 May 2019 12:07:04 +0300 (MSK) Received: from T-EXCH-02.corp.yadro.com (t-exch-02.corp.yadro.com [172.17.10.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 7E16D41860; Fri, 31 May 2019 12:07:02 +0300 (MSK) Received: from localhost (172.17.14.115) by T-EXCH-02.corp.yadro.com (172.17.10.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Fri, 31 May 2019 12:07:01 +0300 Date: Fri, 31 May 2019 12:07:01 +0300 From: "Alexander A. Filippov" To: Andrew Jeffery CC: "Alexander A. Filippov" , , , , Joel Stanley , Mark Rutland , Rob Herring , Subject: Re: [PATCH v3] ARM: dts: aspeed: Add YADRO VESNIN BMC Message-ID: <20190531090701.GA12476@bbwork.lan> References: <20190531061207.23079-1-a.filippov@yadro.com> <2966b961-77ca-4371-949c-195b623e344b@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <2966b961-77ca-4371-949c-195b623e344b@www.fastmail.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Originating-IP: [172.17.14.115] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-02.corp.yadro.com (172.17.10.102) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 31, 2019 at 04:02:37PM +0930, Andrew Jeffery wrote: > Hello Alexander, Hi Andrew, > > On Fri, 31 May 2019, at 15:42, Alexander Filippov wrote: > > VESNIN is an OpenPower machine with an Aspeed 2400 BMC SoC manufactured > > by YADRO. > > > > Signed-off-by: Alexander Filippov > > --- > > arch/arm/boot/dts/Makefile | 1 + > > arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts | 234 ++++++++++++++++++++ > > 2 files changed, 235 insertions(+) > > create mode 100644 arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index 834cce80d1b8..09a851a4705c 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -1261,6 +1261,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > > aspeed-bmc-opp-palmetto.dtb \ > > aspeed-bmc-opp-romulus.dtb \ > > aspeed-bmc-opp-swift.dtb \ > > + aspeed-bmc-opp-vesnin.dtb \ > > The patch doesn't apply to upstream - the Swift machine only exists in the > OpenBMC kernel tree. Please rebase the patch onto upstream and resend. Done. > > > aspeed-bmc-opp-witherspoon.dtb \ > > aspeed-bmc-opp-zaius.dtb \ > > aspeed-bmc-portwell-neptune.dtb \ > > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts > > b/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts > > new file mode 100644 > > index 000000000000..20f07f5bb4f4 > > --- /dev/null > > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts > > @@ -0,0 +1,234 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +// Copyright 2019 YADRO > > +/dts-v1/; > > + > > +#include "aspeed-g4.dtsi" > > +#include > > + > > +/ { > > + model = "Vesnin BMC"; > > + compatible = "yadro,vesnin-bmc", "aspeed,ast2400"; > > + > > + chosen { > > + stdout-path = &uart5; > > + bootargs = "console=ttyS4,115200 earlyprintk"; > > + }; > > + > > + memory { > > + reg = <0x40000000 0x20000000>; > > + }; > > + > > + reserved-memory { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + > > + vga_memory: framebuffer@5f000000 { > > + no-map; > > + reg = <0x5f000000 0x01000000>; /* 16MB */ > > + }; > > + flash_memory: region@5c000000 { > > + no-map; > > + reg = <0x5c000000 0x02000000>; /* 32M */ > > + }; > > + }; > > + > > + leds { > > + compatible = "gpio-leds"; > > + > > + heartbeat { > > + gpios = <&gpio ASPEED_GPIO(R, 4) GPIO_ACTIVE_LOW>; > > + }; > > + power_red { > > + gpios = <&gpio ASPEED_GPIO(N, 1) GPIO_ACTIVE_LOW>; > > + }; > > + > > + id_blue { > > + gpios = <&gpio ASPEED_GPIO(O, 0) GPIO_ACTIVE_LOW>; > > + }; > > + > > + alarm_red { > > + gpios = <&gpio ASPEED_GPIO(N, 6) GPIO_ACTIVE_LOW>; > > + }; > > + > > + alarm_yel { > > + gpios = <&gpio ASPEED_GPIO(N, 7) GPIO_ACTIVE_HIGH>; > > + }; > > + }; > > + > > + gpio-keys { > > + compatible = "gpio-keys"; > > + > > + button_checkstop { > > + label = "checkstop"; > > + linux,code = <74>; > > + gpios = <&gpio ASPEED_GPIO(P, 5) GPIO_ACTIVE_LOW>; > > + }; > > + > > + button_identify { > > + label = "identify"; > > + linux,code = <152>; > > + gpios = <&gpio ASPEED_GPIO(O, 7) GPIO_ACTIVE_LOW>; > > + }; > > + }; > > +}; > > + > > +&fmc { > > + status = "okay"; > > + flash@0 { > > + status = "okay"; > > + m25p,fast-read; > > + label = "bmc"; > > +#include "openbmc-flash-layout.dtsi" > > + }; > > +}; > > + > > +&spi { > > + status = "okay"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_spi1debug_default>; > > Is this how the board is strapped? I'm asking in case it's just copy/paste > from Palmetto, which was (unfortunately) strapped this way. Yes, the board is strapped in such manner. I guess it was brought from barreleye which was a prototype for vesnin. Setting this pin to &pinctrl_spi1_default leads to warning: kernel: aspeed-smc 1e630000.spi: Error applying setting, reverse things back > > > + > > + flash@0 { > > + status = "okay"; > > + label = "pnor"; > > + m25p,fast-read; > > + }; > > +}; > > + > > +&mac0 { > > + status = "okay"; > > + > > + use-ncsi; > > + no-hw-checksum; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_rmii1_default>; > > +}; > > + > > + > > +&uart5 { > > + status = "okay"; > > +}; > > + > > +&lpc_ctrl { > > + status = "okay"; > > + memory-region = <&flash_memory>; > > + flash = <&spi>; > > +}; > > + > > +&ibt { > > + status = "okay"; > > +}; > > + > > +&lpc_host { > > + sio_regs: regs { > > + compatible = "aspeed,bmc-misc"; > > The patches for this are not upstream, and won't make it in their current > form. Please drop this node from the patch. > Done. > > + }; > > +}; > > + > > +&mbox { > > + status = "okay"; > > This driver is not upstream either, and we plan on dropping it from the > OpenBMC tree too. Please remove this node from the patch. Done. > > Cheers, > > Andrew > > > +}; > > + > > +&uart3 { > > + status = "okay"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_txd2_default &pinctrl_rxd2_default>; > > +}; > > + > > +&i2c0 { > > + status = "okay"; > > + > > + eeprom@50 { > > + compatible = "atmel,24c256"; > > + reg = <0x50>; > > + pagesize = <64>; > > + }; > > +}; > > + > > +&i2c1 { > > + status = "okay"; > > + > > + tmp75@49 { > > + compatible = "ti,tmp75"; > > + reg = <0x49>; > > + }; > > +}; > > + > > +&i2c2 { > > + status = "okay"; > > +}; > > + > > +&i2c3 { > > + status = "okay"; > > +}; > > + > > +&i2c4 { > > + status = "okay"; > > + > > + occ-hwmon@50 { > > + compatible = "ibm,p8-occ-hwmon"; > > + reg = <0x50>; > > + }; > > +}; > > + > > +&i2c5 { > > + status = "okay"; > > + > > + occ-hwmon@51 { > > + compatible = "ibm,p8-occ-hwmon"; > > + reg = <0x51>; > > + }; > > +}; > > + > > +&i2c6 { > > + status = "okay"; > > + > > + w83795g@2f { > > + compatible = "nuvoton,w83795g"; > > + reg = <0x2f>; > > + }; > > +}; > > + > > +&i2c7 { > > + status = "okay"; > > + > > + occ-hwmon@56 { > > + compatible = "ibm,p8-occ-hwmon"; > > + reg = <0x56>; > > + }; > > +}; > > + > > +&i2c9 { > > + status = "okay"; > > +}; > > + > > +&i2c10 { > > + status = "okay"; > > +}; > > + > > +&i2c11 { > > + status = "okay"; > > + > > + occ-hwmon@57 { > > + compatible = "ibm,p8-occ-hwmon"; > > + reg = <0x57>; > > + }; > > +}; > > + > > +&i2c12 { > > + status = "okay"; > > + > > + rtc@68 { > > + compatible = "maxim,ds3231"; > > + reg = <0x68>; > > + }; > > +}; > > + > > +&i2c13 { > > + status = "okay"; > > +}; > > + > > +&vuart { > > + status = "okay"; > > +}; > > -- > > 2.20.1 > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Alexander A. Filippov" Subject: Re: [PATCH v3] ARM: dts: aspeed: Add YADRO VESNIN BMC Date: Fri, 31 May 2019 12:07:01 +0300 Message-ID: <20190531090701.GA12476@bbwork.lan> References: <20190531061207.23079-1-a.filippov@yadro.com> <2966b961-77ca-4371-949c-195b623e344b@www.fastmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Return-path: Content-Disposition: inline In-Reply-To: <2966b961-77ca-4371-949c-195b623e344b@www.fastmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Jeffery Cc: "Alexander A. Filippov" , linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Joel Stanley , Mark Rutland , Rob Herring , linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Fri, May 31, 2019 at 04:02:37PM +0930, Andrew Jeffery wrote: > Hello Alexander, Hi Andrew, > > On Fri, 31 May 2019, at 15:42, Alexander Filippov wrote: > > VESNIN is an OpenPower machine with an Aspeed 2400 BMC SoC manufactured > > by YADRO. > > > > Signed-off-by: Alexander Filippov > > --- > > arch/arm/boot/dts/Makefile | 1 + > > arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts | 234 ++++++++++++++++++++ > > 2 files changed, 235 insertions(+) > > create mode 100644 arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index 834cce80d1b8..09a851a4705c 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -1261,6 +1261,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > > aspeed-bmc-opp-palmetto.dtb \ > > aspeed-bmc-opp-romulus.dtb \ > > aspeed-bmc-opp-swift.dtb \ > > + aspeed-bmc-opp-vesnin.dtb \ > > The patch doesn't apply to upstream - the Swift machine only exists in the > OpenBMC kernel tree. Please rebase the patch onto upstream and resend. Done. > > > aspeed-bmc-opp-witherspoon.dtb \ > > aspeed-bmc-opp-zaius.dtb \ > > aspeed-bmc-portwell-neptune.dtb \ > > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts > > b/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts > > new file mode 100644 > > index 000000000000..20f07f5bb4f4 > > --- /dev/null > > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts > > @@ -0,0 +1,234 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +// Copyright 2019 YADRO > > +/dts-v1/; > > + > > +#include "aspeed-g4.dtsi" > > +#include > > + > > +/ { > > + model = "Vesnin BMC"; > > + compatible = "yadro,vesnin-bmc", "aspeed,ast2400"; > > + > > + chosen { > > + stdout-path = &uart5; > > + bootargs = "console=ttyS4,115200 earlyprintk"; > > + }; > > + > > + memory { > > + reg = <0x40000000 0x20000000>; > > + }; > > + > > + reserved-memory { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + > > + vga_memory: framebuffer@5f000000 { > > + no-map; > > + reg = <0x5f000000 0x01000000>; /* 16MB */ > > + }; > > + flash_memory: region@5c000000 { > > + no-map; > > + reg = <0x5c000000 0x02000000>; /* 32M */ > > + }; > > + }; > > + > > + leds { > > + compatible = "gpio-leds"; > > + > > + heartbeat { > > + gpios = <&gpio ASPEED_GPIO(R, 4) GPIO_ACTIVE_LOW>; > > + }; > > + power_red { > > + gpios = <&gpio ASPEED_GPIO(N, 1) GPIO_ACTIVE_LOW>; > > + }; > > + > > + id_blue { > > + gpios = <&gpio ASPEED_GPIO(O, 0) GPIO_ACTIVE_LOW>; > > + }; > > + > > + alarm_red { > > + gpios = <&gpio ASPEED_GPIO(N, 6) GPIO_ACTIVE_LOW>; > > + }; > > + > > + alarm_yel { > > + gpios = <&gpio ASPEED_GPIO(N, 7) GPIO_ACTIVE_HIGH>; > > + }; > > + }; > > + > > + gpio-keys { > > + compatible = "gpio-keys"; > > + > > + button_checkstop { > > + label = "checkstop"; > > + linux,code = <74>; > > + gpios = <&gpio ASPEED_GPIO(P, 5) GPIO_ACTIVE_LOW>; > > + }; > > + > > + button_identify { > > + label = "identify"; > > + linux,code = <152>; > > + gpios = <&gpio ASPEED_GPIO(O, 7) GPIO_ACTIVE_LOW>; > > + }; > > + }; > > +}; > > + > > +&fmc { > > + status = "okay"; > > + flash@0 { > > + status = "okay"; > > + m25p,fast-read; > > + label = "bmc"; > > +#include "openbmc-flash-layout.dtsi" > > + }; > > +}; > > + > > +&spi { > > + status = "okay"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_spi1debug_default>; > > Is this how the board is strapped? I'm asking in case it's just copy/paste > from Palmetto, which was (unfortunately) strapped this way. Yes, the board is strapped in such manner. I guess it was brought from barreleye which was a prototype for vesnin. Setting this pin to &pinctrl_spi1_default leads to warning: kernel: aspeed-smc 1e630000.spi: Error applying setting, reverse things back > > > + > > + flash@0 { > > + status = "okay"; > > + label = "pnor"; > > + m25p,fast-read; > > + }; > > +}; > > + > > +&mac0 { > > + status = "okay"; > > + > > + use-ncsi; > > + no-hw-checksum; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_rmii1_default>; > > +}; > > + > > + > > +&uart5 { > > + status = "okay"; > > +}; > > + > > +&lpc_ctrl { > > + status = "okay"; > > + memory-region = <&flash_memory>; > > + flash = <&spi>; > > +}; > > + > > +&ibt { > > + status = "okay"; > > +}; > > + > > +&lpc_host { > > + sio_regs: regs { > > + compatible = "aspeed,bmc-misc"; > > The patches for this are not upstream, and won't make it in their current > form. Please drop this node from the patch. > Done. > > + }; > > +}; > > + > > +&mbox { > > + status = "okay"; > > This driver is not upstream either, and we plan on dropping it from the > OpenBMC tree too. Please remove this node from the patch. Done. > > Cheers, > > Andrew > > > +}; > > + > > +&uart3 { > > + status = "okay"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_txd2_default &pinctrl_rxd2_default>; > > +}; > > + > > +&i2c0 { > > + status = "okay"; > > + > > + eeprom@50 { > > + compatible = "atmel,24c256"; > > + reg = <0x50>; > > + pagesize = <64>; > > + }; > > +}; > > + > > +&i2c1 { > > + status = "okay"; > > + > > + tmp75@49 { > > + compatible = "ti,tmp75"; > > + reg = <0x49>; > > + }; > > +}; > > + > > +&i2c2 { > > + status = "okay"; > > +}; > > + > > +&i2c3 { > > + status = "okay"; > > +}; > > + > > +&i2c4 { > > + status = "okay"; > > + > > + occ-hwmon@50 { > > + compatible = "ibm,p8-occ-hwmon"; > > + reg = <0x50>; > > + }; > > +}; > > + > > +&i2c5 { > > + status = "okay"; > > + > > + occ-hwmon@51 { > > + compatible = "ibm,p8-occ-hwmon"; > > + reg = <0x51>; > > + }; > > +}; > > + > > +&i2c6 { > > + status = "okay"; > > + > > + w83795g@2f { > > + compatible = "nuvoton,w83795g"; > > + reg = <0x2f>; > > + }; > > +}; > > + > > +&i2c7 { > > + status = "okay"; > > + > > + occ-hwmon@56 { > > + compatible = "ibm,p8-occ-hwmon"; > > + reg = <0x56>; > > + }; > > +}; > > + > > +&i2c9 { > > + status = "okay"; > > +}; > > + > > +&i2c10 { > > + status = "okay"; > > +}; > > + > > +&i2c11 { > > + status = "okay"; > > + > > + occ-hwmon@57 { > > + compatible = "ibm,p8-occ-hwmon"; > > + reg = <0x57>; > > + }; > > +}; > > + > > +&i2c12 { > > + status = "okay"; > > + > > + rtc@68 { > > + compatible = "maxim,ds3231"; > > + reg = <0x68>; > > + }; > > +}; > > + > > +&i2c13 { > > + status = "okay"; > > +}; > > + > > +&vuart { > > + status = "okay"; > > +}; > > -- > > 2.20.1 > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD8BEC04AB6 for ; Fri, 31 May 2019 09:07:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1C1E26671 for ; Fri, 31 May 2019 09:07:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NMYgG3sy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=yadro.com header.i=@yadro.com header.b="ZWXV53Rs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1C1E26671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=yadro.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VE+T5J5lrIInRtPcUGzp6qUiEwIIbZSy+RR1vMTNE0A=; b=NMYgG3syvoAHFK a1DNglLIISoRYJ2YWVlq1kgdVYyAL+jxcFigxO68AUsZlF1KqLRGKXnCA/Ol8PAy0nBUBpXo9IPcP BTmEFxMuY8WWBLJctESxYbH8zvAEPGnR2cbgdpYnz/PvGzRGGZDW6b+SG6rRa83OKa7GldX158fbk 4QY9c8CqZgZN3azcJ0sUhRu+Gp6UCiVkC0cf1gHO+stKRdZZy4Kplr+6CjZ+nueMZxymQPqjRtwTp 1RcegndznPzdopKOF6qUBjX97h0K3gvxseckvw7QTZUJvUfDVy4xYKN+PBtzHnvAvcZMHPauWZKeF yxJ52vJJSMm+U2hWf2Yw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWdVH-000766-NJ; Fri, 31 May 2019 09:07:11 +0000 Received: from mta-01.yadro.com ([89.207.88.251]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWdVE-00075R-20 for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 09:07:09 +0000 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id 3F5C941908; Fri, 31 May 2019 09:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= user-agent:in-reply-to:content-disposition:content-type :content-type:mime-version:references:message-id:subject:subject :from:from:date:date:received:received:received; s=mta-01; t= 1559293624; x=1561108025; bh=V2JYksw1ZpPn49A8Zy8oL1DLxXqIFwPGBxx 0ZykK3RM=; b=ZWXV53Rs0HjRaijj7GccsS27X91FsXvdCKAEkgTbszlF1SNFbNu Recqa8xL9JFDzJdRk3eJxRKLci3VsBho2OKC8FptW7OC7vYdPcFzgSYGEaysKFa/ uK7ox0LWLrCaYusGi/w5tqL6QflmSBAJeZPP3j2nCnQuwBn4Ul8TRqDs= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FeODQLn3iRyt; Fri, 31 May 2019 12:07:04 +0300 (MSK) Received: from T-EXCH-02.corp.yadro.com (t-exch-02.corp.yadro.com [172.17.10.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 7E16D41860; Fri, 31 May 2019 12:07:02 +0300 (MSK) Received: from localhost (172.17.14.115) by T-EXCH-02.corp.yadro.com (172.17.10.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Fri, 31 May 2019 12:07:01 +0300 Date: Fri, 31 May 2019 12:07:01 +0300 From: "Alexander A. Filippov" To: Andrew Jeffery Subject: Re: [PATCH v3] ARM: dts: aspeed: Add YADRO VESNIN BMC Message-ID: <20190531090701.GA12476@bbwork.lan> References: <20190531061207.23079-1-a.filippov@yadro.com> <2966b961-77ca-4371-949c-195b623e344b@www.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2966b961-77ca-4371-949c-195b623e344b@www.fastmail.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Originating-IP: [172.17.14.115] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-02.corp.yadro.com (172.17.10.102) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_020708_478018_BF5E11C3 X-CRM114-Status: GOOD ( 23.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring , "Alexander A. Filippov" , linux-arm-kernel@lists.infradead.org, Joel Stanley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 31, 2019 at 04:02:37PM +0930, Andrew Jeffery wrote: > Hello Alexander, Hi Andrew, > > On Fri, 31 May 2019, at 15:42, Alexander Filippov wrote: > > VESNIN is an OpenPower machine with an Aspeed 2400 BMC SoC manufactured > > by YADRO. > > > > Signed-off-by: Alexander Filippov > > --- > > arch/arm/boot/dts/Makefile | 1 + > > arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts | 234 ++++++++++++++++++++ > > 2 files changed, 235 insertions(+) > > create mode 100644 arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index 834cce80d1b8..09a851a4705c 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -1261,6 +1261,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > > aspeed-bmc-opp-palmetto.dtb \ > > aspeed-bmc-opp-romulus.dtb \ > > aspeed-bmc-opp-swift.dtb \ > > + aspeed-bmc-opp-vesnin.dtb \ > > The patch doesn't apply to upstream - the Swift machine only exists in the > OpenBMC kernel tree. Please rebase the patch onto upstream and resend. Done. > > > aspeed-bmc-opp-witherspoon.dtb \ > > aspeed-bmc-opp-zaius.dtb \ > > aspeed-bmc-portwell-neptune.dtb \ > > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts > > b/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts > > new file mode 100644 > > index 000000000000..20f07f5bb4f4 > > --- /dev/null > > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts > > @@ -0,0 +1,234 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +// Copyright 2019 YADRO > > +/dts-v1/; > > + > > +#include "aspeed-g4.dtsi" > > +#include > > + > > +/ { > > + model = "Vesnin BMC"; > > + compatible = "yadro,vesnin-bmc", "aspeed,ast2400"; > > + > > + chosen { > > + stdout-path = &uart5; > > + bootargs = "console=ttyS4,115200 earlyprintk"; > > + }; > > + > > + memory { > > + reg = <0x40000000 0x20000000>; > > + }; > > + > > + reserved-memory { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + > > + vga_memory: framebuffer@5f000000 { > > + no-map; > > + reg = <0x5f000000 0x01000000>; /* 16MB */ > > + }; > > + flash_memory: region@5c000000 { > > + no-map; > > + reg = <0x5c000000 0x02000000>; /* 32M */ > > + }; > > + }; > > + > > + leds { > > + compatible = "gpio-leds"; > > + > > + heartbeat { > > + gpios = <&gpio ASPEED_GPIO(R, 4) GPIO_ACTIVE_LOW>; > > + }; > > + power_red { > > + gpios = <&gpio ASPEED_GPIO(N, 1) GPIO_ACTIVE_LOW>; > > + }; > > + > > + id_blue { > > + gpios = <&gpio ASPEED_GPIO(O, 0) GPIO_ACTIVE_LOW>; > > + }; > > + > > + alarm_red { > > + gpios = <&gpio ASPEED_GPIO(N, 6) GPIO_ACTIVE_LOW>; > > + }; > > + > > + alarm_yel { > > + gpios = <&gpio ASPEED_GPIO(N, 7) GPIO_ACTIVE_HIGH>; > > + }; > > + }; > > + > > + gpio-keys { > > + compatible = "gpio-keys"; > > + > > + button_checkstop { > > + label = "checkstop"; > > + linux,code = <74>; > > + gpios = <&gpio ASPEED_GPIO(P, 5) GPIO_ACTIVE_LOW>; > > + }; > > + > > + button_identify { > > + label = "identify"; > > + linux,code = <152>; > > + gpios = <&gpio ASPEED_GPIO(O, 7) GPIO_ACTIVE_LOW>; > > + }; > > + }; > > +}; > > + > > +&fmc { > > + status = "okay"; > > + flash@0 { > > + status = "okay"; > > + m25p,fast-read; > > + label = "bmc"; > > +#include "openbmc-flash-layout.dtsi" > > + }; > > +}; > > + > > +&spi { > > + status = "okay"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_spi1debug_default>; > > Is this how the board is strapped? I'm asking in case it's just copy/paste > from Palmetto, which was (unfortunately) strapped this way. Yes, the board is strapped in such manner. I guess it was brought from barreleye which was a prototype for vesnin. Setting this pin to &pinctrl_spi1_default leads to warning: kernel: aspeed-smc 1e630000.spi: Error applying setting, reverse things back > > > + > > + flash@0 { > > + status = "okay"; > > + label = "pnor"; > > + m25p,fast-read; > > + }; > > +}; > > + > > +&mac0 { > > + status = "okay"; > > + > > + use-ncsi; > > + no-hw-checksum; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_rmii1_default>; > > +}; > > + > > + > > +&uart5 { > > + status = "okay"; > > +}; > > + > > +&lpc_ctrl { > > + status = "okay"; > > + memory-region = <&flash_memory>; > > + flash = <&spi>; > > +}; > > + > > +&ibt { > > + status = "okay"; > > +}; > > + > > +&lpc_host { > > + sio_regs: regs { > > + compatible = "aspeed,bmc-misc"; > > The patches for this are not upstream, and won't make it in their current > form. Please drop this node from the patch. > Done. > > + }; > > +}; > > + > > +&mbox { > > + status = "okay"; > > This driver is not upstream either, and we plan on dropping it from the > OpenBMC tree too. Please remove this node from the patch. Done. > > Cheers, > > Andrew > > > +}; > > + > > +&uart3 { > > + status = "okay"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_txd2_default &pinctrl_rxd2_default>; > > +}; > > + > > +&i2c0 { > > + status = "okay"; > > + > > + eeprom@50 { > > + compatible = "atmel,24c256"; > > + reg = <0x50>; > > + pagesize = <64>; > > + }; > > +}; > > + > > +&i2c1 { > > + status = "okay"; > > + > > + tmp75@49 { > > + compatible = "ti,tmp75"; > > + reg = <0x49>; > > + }; > > +}; > > + > > +&i2c2 { > > + status = "okay"; > > +}; > > + > > +&i2c3 { > > + status = "okay"; > > +}; > > + > > +&i2c4 { > > + status = "okay"; > > + > > + occ-hwmon@50 { > > + compatible = "ibm,p8-occ-hwmon"; > > + reg = <0x50>; > > + }; > > +}; > > + > > +&i2c5 { > > + status = "okay"; > > + > > + occ-hwmon@51 { > > + compatible = "ibm,p8-occ-hwmon"; > > + reg = <0x51>; > > + }; > > +}; > > + > > +&i2c6 { > > + status = "okay"; > > + > > + w83795g@2f { > > + compatible = "nuvoton,w83795g"; > > + reg = <0x2f>; > > + }; > > +}; > > + > > +&i2c7 { > > + status = "okay"; > > + > > + occ-hwmon@56 { > > + compatible = "ibm,p8-occ-hwmon"; > > + reg = <0x56>; > > + }; > > +}; > > + > > +&i2c9 { > > + status = "okay"; > > +}; > > + > > +&i2c10 { > > + status = "okay"; > > +}; > > + > > +&i2c11 { > > + status = "okay"; > > + > > + occ-hwmon@57 { > > + compatible = "ibm,p8-occ-hwmon"; > > + reg = <0x57>; > > + }; > > +}; > > + > > +&i2c12 { > > + status = "okay"; > > + > > + rtc@68 { > > + compatible = "maxim,ds3231"; > > + reg = <0x68>; > > + }; > > +}; > > + > > +&i2c13 { > > + status = "okay"; > > +}; > > + > > +&vuart { > > + status = "okay"; > > +}; > > -- > > 2.20.1 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel