From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEC81C04AB6 for ; Fri, 31 May 2019 09:30:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8358E266DA for ; Fri, 31 May 2019 09:30:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727008AbfEaJaz (ORCPT ); Fri, 31 May 2019 05:30:55 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:51248 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbfEaJaz (ORCPT ); Fri, 31 May 2019 05:30:55 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 3CE6F80225; Fri, 31 May 2019 11:30:43 +0200 (CEST) Date: Fri, 31 May 2019 11:30:52 +0200 From: Pavel Machek To: Fabien Dessenne Cc: Hugues Fruchet , Mauro Carvalho Chehab , Maxime Coquelin , Alexandre Torgue , Pavel Machek , Hans Verkuil , linux-media@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Sasha Levin Subject: Re: [PATCH] media: stm32-dcmi: fix irq = 0 case Message-ID: <20190531093052.GA23111@amd> References: <1559294295-20573-1-git-send-email-fabien.dessenne@st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline In-Reply-To: <1559294295-20573-1-git-send-email-fabien.dessenne@st.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2019-05-31 11:18:15, Fabien Dessenne wrote: > Manage the irq =3D 0 case, where we shall return an error. >=20 > Fixes: b5b5a27bee58 ("media: stm32-dcmi: return appropriate error codes d= uring probe") > Signed-off-by: Fabien Dessenne Acked-by: Pavel Machek Reported-by: Pavel Machek :-). Pavel > +++ b/drivers/media/platform/stm32/stm32-dcmi.c > @@ -1702,7 +1702,7 @@ static int dcmi_probe(struct platform_device *pdev) > if (irq <=3D 0) { > if (irq !=3D -EPROBE_DEFER) > dev_err(&pdev->dev, "Could not get irq\n"); > - return irq; > + return irq ? irq : -ENXIO; > } > =20 > dcmi->res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlzw9EwACgkQMOfwapXb+vI91gCgrymhw+fLQG9ycygMMLdOh9Mv Ao8AoKLSVLOH71CRZXNcxqg8QDUQpczh =7mwO -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD65DC04AB6 for ; Fri, 31 May 2019 09:31:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91731266DA for ; Fri, 31 May 2019 09:31:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tu4fwFC7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91731266DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wlxpZwx2rr4FL16fYzsucWd35v+fZLzcQU8+ojdI5uE=; b=tu4fwFC7s7QeL5qsxrpZ+MR2Y PzWrjXHX80BLUfeu7sfwnZLJRLNi7IQObHctTCNqU8p8srCb32AC4hFslNmNd2/0/Q2wM+J7V7c48 gNPdJu5/1LMON79lBIU4TITbI6keBD9TMVMHxuE22UGnJLUgUaFW9TK2AQZrYoQLspNXY6pZ38qdv 4pQ1QUufPLL+ZuWF4+xuL+7j8JyaIH6AsbO8g6rmQxF+dJcWqXNkKttWJiRlOsVStm4voIyUluQ0C bL7ZcxDdmIzRHip6ucJ067zi1NDhvhZ8zPa7uPD9p4dMElj86MnZ9rSRrpNxkJ1GfCcf2nr8/gC/m xWUzsw7ww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWdsP-0008FS-9j; Fri, 31 May 2019 09:31:05 +0000 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWdsL-0008EQ-Va for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 09:31:03 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 3CE6F80225; Fri, 31 May 2019 11:30:43 +0200 (CEST) Date: Fri, 31 May 2019 11:30:52 +0200 From: Pavel Machek To: Fabien Dessenne Subject: Re: [PATCH] media: stm32-dcmi: fix irq = 0 case Message-ID: <20190531093052.GA23111@amd> References: <1559294295-20573-1-git-send-email-fabien.dessenne@st.com> MIME-Version: 1.0 In-Reply-To: <1559294295-20573-1-git-send-email-fabien.dessenne@st.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_023102_165461_B36CE9EA X-CRM114-Status: GOOD ( 12.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Alexandre Torgue , Pavel Machek , linux-kernel@vger.kernel.org, Maxime Coquelin , Greg Kroah-Hartman , Hans Verkuil , Hugues Fruchet , Mauro Carvalho Chehab , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: multipart/mixed; boundary="===============1266222202797761500==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1266222202797761500== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2019-05-31 11:18:15, Fabien Dessenne wrote: > Manage the irq =3D 0 case, where we shall return an error. >=20 > Fixes: b5b5a27bee58 ("media: stm32-dcmi: return appropriate error codes d= uring probe") > Signed-off-by: Fabien Dessenne Acked-by: Pavel Machek Reported-by: Pavel Machek :-). Pavel > +++ b/drivers/media/platform/stm32/stm32-dcmi.c > @@ -1702,7 +1702,7 @@ static int dcmi_probe(struct platform_device *pdev) > if (irq <=3D 0) { > if (irq !=3D -EPROBE_DEFER) > dev_err(&pdev->dev, "Could not get irq\n"); > - return irq; > + return irq ? irq : -ENXIO; > } > =20 > dcmi->res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlzw9EwACgkQMOfwapXb+vI91gCgrymhw+fLQG9ycygMMLdOh9Mv Ao8AoKLSVLOH71CRZXNcxqg8QDUQpczh =7mwO -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv-- --===============1266222202797761500== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1266222202797761500==--