From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/netsurf: disallow on archs requiring ABI specific CFLAGS
Date: Fri, 31 May 2019 23:40:52 +0200 [thread overview]
Message-ID: <20190531214052.14297-1-peter@korsgaard.com> (raw)
Fixes:
http://autobuild.buildroot.net/results/67ef520d82ea529a9fe593d83a3aeae5f8b0ee5d/
http://autobuild.buildroot.net/results/eafc3e4be571d5ecee549a11530ac4e508f31782/
http://autobuild.buildroot.net/results/ba7f30833fef54162a82f4b336a72d6599594526/
The netsurf build system mixes up host and target CFLAGS, so it isn't
compatible with architectures where we pass ABI specicif compiler flags (in
TARGET_ABI).
Add a _ARCH_SUPPORTS kconfig variable matching the TARGET_ABI logic we have
in package/Makefile.in, and use it to disallow netsurf for those
architectures.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
package/netsurf/Config.in | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/package/netsurf/Config.in b/package/netsurf/Config.in
index 30b2695309..4f7d5c2713 100644
--- a/package/netsurf/Config.in
+++ b/package/netsurf/Config.in
@@ -1,10 +1,20 @@
+# netsurf mixes up host and target CFLAGS, so it isn't compatible with
+# architectures where we pass ABI specific compiler flags (TARGET_ABI)
+config BR2_PACKAGE_NETSURF_ARCH_SUPPORTS
+ bool
+ default y if !((BR2_arc && BR2_ARC_ATOMIC_EXT) || \
+ BR2_powerpc_8540 || BR2_powerpc_8548 || BR2_powerpc_e500mc || \
+ BR2_xtensa)
+
comment "netsurf needs a toolchain w/ dynamic library"
depends on BR2_STATIC_LIBS
+ depends on BR2_PACKAGE_NETSURF_ARCH_SUPPORTS
config BR2_PACKAGE_NETSURF
bool "netsurf"
# static linking support is broken beyond repair
depends on !BR2_STATIC_LIBS
+ depends on BR2_PACKAGE_NETSURF_ARCH_SUPPORTS
select BR2_PACKAGE_EXPAT
select BR2_PACKAGE_JPEG
select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
--
2.11.0
next reply other threads:[~2019-05-31 21:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 21:40 Peter Korsgaard [this message]
2019-06-01 5:33 ` [Buildroot] [PATCH] package/netsurf: disallow on archs requiring ABI specific CFLAGS Thomas Huth
2019-06-01 7:01 ` Thomas Petazzoni
2019-06-01 7:04 ` Thomas Petazzoni
2019-06-01 8:15 ` Peter Korsgaard
2019-06-06 15:38 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531214052.14297-1-peter@korsgaard.com \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.