From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 1 Jun 2019 14:25:39 +0200 Subject: [Buildroot] [PATCH 1/1] package/libnfc: support pcsc-lite In-Reply-To: <20190527111550.4bbf2dcc@windsurf> References: <20190527111550.4bbf2dcc@windsurf> Message-ID: <20190601142539.423b02a9@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Raul, On Mon, 27 May 2019 11:15:50 +0200 Thomas Petazzoni wrote: > Here as well: please send with git send-email so that we can do a > proper review. > > A few comments though: > > - We need you to use your real name as the patch author and for the > Signed-off-by line > > - Why are you making pcsc-lite a mandatory dependency of libnfc ? > Since libnfc builds fine today with pcsc-lite, it means it should be > an optional dependency. Either add a sub-option to enable the > different libnfc drivers, or automatically add pcsc-lite to the > dependencies if BR2_PACKAGE_PCSC_LITE=y. I just wanted to make sure that you have seen my comments on this patch. I'm marking it as "Changes Requested" in our patch tracking system. Therefore, if you don't send an updated version of the patch, we will forget about it. Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com