From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAC74C282DC for ; Sun, 2 Jun 2019 20:01:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7867279C1 for ; Sun, 2 Jun 2019 20:01:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726899AbfFBUBW (ORCPT ); Sun, 2 Jun 2019 16:01:22 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:47914 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726485AbfFBUBW (ORCPT ); Sun, 2 Jun 2019 16:01:22 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7B8EE1400F7B4; Sun, 2 Jun 2019 13:01:21 -0700 (PDT) Date: Sun, 02 Jun 2019 13:01:18 -0700 (PDT) Message-Id: <20190602.130118.1624703340305098863.davem@davemloft.net> To: biao.huang@mediatek.com Cc: joabreu@synopsys.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, mcoquelin.stm32@gmail.com, matthias.bgg@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, yt.shen@mediatek.com, jianguo.zhang@mediatek.com, boon.leong.ong@intel.com, andrew@lunn.ch Subject: Re: [RESEND, PATCH 1/4] net: stmmac: dwmac-mediatek: enable Ethernet power domain From: David Miller In-Reply-To: <1559209398-3607-2-git-send-email-biao.huang@mediatek.com> References: <1559209398-3607-1-git-send-email-biao.huang@mediatek.com> <1559209398-3607-2-git-send-email-biao.huang@mediatek.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 02 Jun 2019 13:01:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Biao Huang Date: Thu, 30 May 2019 17:43:15 +0800 > @@ -364,6 +371,15 @@ static int mediatek_dwmac_probe(struct platform_device *pdev) > return 0; > } > > +static int mediatek_dwmac_remove(struct platform_device *pdev) > +{ > + int ret; > + > + ret = stmmac_pltfr_remove(pdev); > + > + return ret; > +} > + > static const struct of_device_id mediatek_dwmac_match[] = { > { .compatible = "mediatek,mt2712-gmac", > .data = &mt2712_gmac_variant }, > @@ -374,7 +390,7 @@ static int mediatek_dwmac_probe(struct platform_device *pdev) > > static struct platform_driver mediatek_dwmac_driver = { > .probe = mediatek_dwmac_probe, > - .remove = stmmac_pltfr_remove, > + .remove = mediatek_dwmac_remove, > .driver = { > .name = "dwmac-mediatek", > .pm = &stmmac_pltfr_pm_ops, This half of your patch has no effect and seems completely unnecessary. Please remove it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F6D1C282DC for ; Sun, 2 Jun 2019 20:01:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2CC0279C7 for ; Sun, 2 Jun 2019 20:01:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Vb7rzYoN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2CC0279C7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: From:Subject:To:Message-Id:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R+oA9EHsjk8zmA32doxp30LxYxrtUR63U1SXrUkvMtU=; b=Vb7rzYoNBEEI3E ktzSle2Sj9mNyn3l+LlP7irBWj3aRIwknyAkYYNCM05OCn9KHAS2sc/RLWWfVYD8tk8CLKpmTC3Ke IvBS/bLfrlSY5+8i16q7AdSpFFVDHWdkwTsvfA2EZi4hw9gXahHccqGUgSBcAzdUUPa8Y2H7yiAxh 1T3rNzLQoS4Ets1d6Od6OfDqPgnFK5GFTTO+pt7xyy+D74BFhCRZnFcpXduGInfm7Rt0+W5nUOl2j yxVXYYeGv2P5tPprkaqzPYxxwIvVIfMEYoXYrNRjcpP0u3mMa99bVxpfkQdAw9ben12T1FD2uCGkI pHDaNIuX4vMUjqURiykA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXWfc-0002rc-5v; Sun, 02 Jun 2019 20:01:32 +0000 Received: from shards.monkeyblade.net ([2620:137:e000::1:9]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXWfX-0002qe-0N; Sun, 02 Jun 2019 20:01:30 +0000 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7B8EE1400F7B4; Sun, 2 Jun 2019 13:01:21 -0700 (PDT) Date: Sun, 02 Jun 2019 13:01:18 -0700 (PDT) Message-Id: <20190602.130118.1624703340305098863.davem@davemloft.net> To: biao.huang@mediatek.com Subject: Re: [RESEND, PATCH 1/4] net: stmmac: dwmac-mediatek: enable Ethernet power domain From: David Miller In-Reply-To: <1559209398-3607-2-git-send-email-biao.huang@mediatek.com> References: <1559209398-3607-1-git-send-email-biao.huang@mediatek.com> <1559209398-3607-2-git-send-email-biao.huang@mediatek.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 02 Jun 2019 13:01:22 -0700 (PDT) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190602_130127_080833_430F667D X-CRM114-Status: UNSURE ( 7.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, jianguo.zhang@mediatek.com, alexandre.torgue@st.com, boon.leong.ong@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, yt.shen@mediatek.com, joabreu@synopsys.com, linux-mediatek@lists.infradead.org, mcoquelin.stm32@gmail.com, matthias.bgg@gmail.com, peppe.cavallaro@st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Biao Huang Date: Thu, 30 May 2019 17:43:15 +0800 > @@ -364,6 +371,15 @@ static int mediatek_dwmac_probe(struct platform_device *pdev) > return 0; > } > > +static int mediatek_dwmac_remove(struct platform_device *pdev) > +{ > + int ret; > + > + ret = stmmac_pltfr_remove(pdev); > + > + return ret; > +} > + > static const struct of_device_id mediatek_dwmac_match[] = { > { .compatible = "mediatek,mt2712-gmac", > .data = &mt2712_gmac_variant }, > @@ -374,7 +390,7 @@ static int mediatek_dwmac_probe(struct platform_device *pdev) > > static struct platform_driver mediatek_dwmac_driver = { > .probe = mediatek_dwmac_probe, > - .remove = stmmac_pltfr_remove, > + .remove = mediatek_dwmac_remove, > .driver = { > .name = "dwmac-mediatek", > .pm = &stmmac_pltfr_pm_ops, This half of your patch has no effect and seems completely unnecessary. Please remove it. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel