From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3022BC04AB5 for ; Mon, 3 Jun 2019 22:13:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D49026025 for ; Mon, 3 Jun 2019 22:13:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726642AbfFCWNb (ORCPT ); Mon, 3 Jun 2019 18:13:31 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:36144 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725956AbfFCWNa (ORCPT ); Mon, 3 Jun 2019 18:13:30 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D358F136E16B0; Mon, 3 Jun 2019 15:13:29 -0700 (PDT) Date: Mon, 03 Jun 2019 15:13:29 -0700 (PDT) Message-Id: <20190603.151329.1880364693299986138.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: ssantosh@kernel.org, richardcochran@gmail.com, robh+dt@kernel.org, nsekhar@ti.com, m-karicheri2@ti.com, w-kwok2@ti.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next 04/10] net: ethernet: ti: cpts: add support for rftclk selection From: David Miller In-Reply-To: <20190601104534.25790-5-grygorii.strashko@ti.com> References: <20190601104534.25790-1-grygorii.strashko@ti.com> <20190601104534.25790-5-grygorii.strashko@ti.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Jun 2019 15:13:30 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grygorii Strashko Date: Sat, 1 Jun 2019 13:45:28 +0300 > +static int cpts_of_mux_clk_setup(struct cpts *cpts, struct device_node *node) > +{ > + unsigned int num_parents; > + const char **parent_names; > + struct device_node *refclk_np; > + struct clk_hw *clk_hw; > + u32 *mux_table; > + int ret = -EINVAL; Reverse christmas tree please. Thank you. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D8DC04AB5 for ; Mon, 3 Jun 2019 22:13:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B61E22660C for ; Mon, 3 Jun 2019 22:13:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mIho/J2i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B61E22660C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: From:Subject:To:Message-Id:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qgDSfnyKk+BLiZouxDSF9E26InqOh7XdcSWQvHtedNU=; b=mIho/J2ie8ya66 gqgXxWkLoVgB3mfsa1o8c5yaWeF3ijd0+poWPg7f/i+hIdca5S56/zg08XnWpJuRKS+qysqrsg58R MtDs0ydlcM5GrymqsIWyaVczjUrlGmQUrm9Cdb2O2393WrnSXk87/xEB6F9hgtR1HK+T1Ft7xiolR Cwthm69OwQji39BcF9nQz1Jz26GT/iZhXhDWZOlbBXz6P83xDhzYZN34849luHi34bxbc0+a/Qyp9 SQ35PVV+UcUpzIWxv1TsR994nXw8gmzw+mRgn8KxYeaoKlxny1vXwknAFPZi1+uEd3dctIy4sr939 O+23DmCbshxo5IBfRAmg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXvCv-0005lJ-Oo; Mon, 03 Jun 2019 22:13:33 +0000 Received: from shards.monkeyblade.net ([2620:137:e000::1:9]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXvCs-0005l0-Ls for linux-arm-kernel@lists.infradead.org; Mon, 03 Jun 2019 22:13:31 +0000 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D358F136E16B0; Mon, 3 Jun 2019 15:13:29 -0700 (PDT) Date: Mon, 03 Jun 2019 15:13:29 -0700 (PDT) Message-Id: <20190603.151329.1880364693299986138.davem@davemloft.net> To: grygorii.strashko@ti.com Subject: Re: [PATCH net-next 04/10] net: ethernet: ti: cpts: add support for rftclk selection From: David Miller In-Reply-To: <20190601104534.25790-5-grygorii.strashko@ti.com> References: <20190601104534.25790-1-grygorii.strashko@ti.com> <20190601104534.25790-5-grygorii.strashko@ti.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Jun 2019 15:13:30 -0700 (PDT) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190603_151330_712724_14DE0A8E X-CRM114-Status: UNSURE ( 5.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, w-kwok2@ti.com, netdev@vger.kernel.org, richardcochran@gmail.com, nsekhar@ti.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, m-karicheri2@ti.com, ssantosh@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Grygorii Strashko Date: Sat, 1 Jun 2019 13:45:28 +0300 > +static int cpts_of_mux_clk_setup(struct cpts *cpts, struct device_node *node) > +{ > + unsigned int num_parents; > + const char **parent_names; > + struct device_node *refclk_np; > + struct clk_hw *clk_hw; > + u32 *mux_table; > + int ret = -EINVAL; Reverse christmas tree please. Thank you. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel