All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH net] selftests: set sysctl bc_forwarding properly in router_broadcast.sh
Date: Mon, 03 Jun 2019 15:15:14 -0700 (PDT)	[thread overview]
Message-ID: <20190603.151514.2135792251349356990.davem@davemloft.net> (raw)
In-Reply-To: <e22d53ba6d4dde4de8364f9c903a98061344cbe2.1559473795.git.lucien.xin@gmail.com>

From: Xin Long <lucien.xin@gmail.com>
Date: Sun,  2 Jun 2019 19:09:55 +0800

> sysctl setting bc_forwarding for $rp2 is needed when ping_test_from h2,
> otherwise the bc packets from $rp2 won't be forwarded. This patch is to
> add this setting for $rp2.
> 
> Also, as ping_test_from does grep "$from" only, which could match some
> unexpected output, some test case doesn't really work, like:
> 
>   # ping_test_from $h2 198.51.200.255 198.51.200.2
>     PING 198.51.200.255 from 198.51.100.2 veth3: 56(84) bytes of data.
>     64 bytes from 198.51.100.1: icmp_seq=1 ttl=64 time=0.336 ms
> 
> When doing grep $form (198.51.200.2), the output could still match.
> So change to grep "bytes from $from" instead.
> 
> Fixes: 40f98b9af943 ("selftests: add a selftest for directed broadcast forwarding")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>

Applied.

      reply	other threads:[~2019-06-03 22:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-02 11:09 [PATCH net] selftests: set sysctl bc_forwarding properly in router_broadcast.sh Xin Long
2019-06-03 22:15 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190603.151514.2135792251349356990.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.