From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9092BC282DC for ; Mon, 3 Jun 2019 01:07:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 504AF27A3C for ; Mon, 3 Jun 2019 01:07:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="P9s57QnA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726837AbfFCBHq (ORCPT ); Sun, 2 Jun 2019 21:07:46 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:48736 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726561AbfFCBHq (ORCPT ); Sun, 2 Jun 2019 21:07:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NI8tXjuoHj65qlHBHn/UeywAuQJIOuif1sn3h6uP9Iw=; b=P9s57QnAaUAS/Z6st//IwpNW0u JEmkyPCvqDUEtPv26dfHXOHmCPaVYbNAQdqDJfrEGXbxGfhkaYcMtudmIzW1ytgmcHJ8ZwUB6xiR+ OiUrFrhTrhKmBoYS7yXh05rdDChqfLsMu9UMgCoX/FNo9y91zY5WN1FluEYEw9KLdWyM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hXbRs-0002eJ-9M; Mon, 03 Jun 2019 03:07:40 +0200 Date: Mon, 3 Jun 2019 03:07:40 +0200 From: Andrew Lunn To: Vladimir Oltean Cc: f.fainelli@gmail.com, vivien.didelot@gmail.com, davem@davemloft.net, richardcochran@gmail.com, john.stultz@linaro.org, tglx@linutronix.de, sboyd@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 net-next 02/10] net: dsa: Add teardown callback for drivers Message-ID: <20190603010740.GI19081@lunn.ch> References: <20190602213926.2290-1-olteanv@gmail.com> <20190602213926.2290-3-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190602213926.2290-3-olteanv@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 03, 2019 at 12:39:18AM +0300, Vladimir Oltean wrote: > This is helpful for e.g. draining per-driver (not per-port) tagger > queues. > > Signed-off-by: Vladimir Oltean > --- > Changes in v2: > > Patch is new. > > include/net/dsa.h | 1 + > net/dsa/dsa2.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/include/net/dsa.h b/include/net/dsa.h > index a7f36219904f..4033e0677be4 100644 > --- a/include/net/dsa.h > +++ b/include/net/dsa.h > @@ -361,6 +361,7 @@ struct dsa_switch_ops { > int port); > > int (*setup)(struct dsa_switch *ds); > + void (*teardown)(struct dsa_switch *ds); > u32 (*get_phy_flags)(struct dsa_switch *ds, int port); > > /* > diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c > index b70befe8a3c8..5bd3e9a4c709 100644 > --- a/net/dsa/dsa2.c > +++ b/net/dsa/dsa2.c > @@ -407,6 +407,9 @@ static int dsa_switch_setup(struct dsa_switch *ds) > > static void dsa_switch_teardown(struct dsa_switch *ds) > { > + if (ds->ops->teardown) > + ds->ops->teardown(ds); > + > if (ds->slave_mii_bus && ds->ops->phy_read) > mdiobus_unregister(ds->slave_mii_bus); > Hi Vladimir If we want to keep with symmetric with dsa_switch_setup(), this teardown should be added after dsa_switch_unregister_notifier() and before devlink_unregister(). Andrew