From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DDB4C04AB5 for ; Tue, 4 Jun 2019 02:19:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73CD026368 for ; Tue, 4 Jun 2019 02:19:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qxrXhJqK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726416AbfFDCTS (ORCPT ); Mon, 3 Jun 2019 22:19:18 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:45083 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726076AbfFDCTS (ORCPT ); Mon, 3 Jun 2019 22:19:18 -0400 Received: by mail-qt1-f196.google.com with SMTP id j19so8270680qtr.12 for ; Mon, 03 Jun 2019 19:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Ez3y6TuQoJf9yjasiQe9ev4GHCCFIMlgYUuaXW302N4=; b=qxrXhJqKMzBzlNRSxXgvrTkVPFSaWJE6iEvWfs7QYo0WAqJpHQsY/eM3h28xzDWJ9I C9yqhC5cLeKDmVzqZyX1fsWJUgubTIqkRjDuE4HXdhFq5uXRyUsfiB//JkdJrn1bHJxB elEwM82AnMYo6u8WG51/OvfT3+BKZCVpJ1/R/sdGZ51aiuuPbmVfyrAm3jJR/nYDRTOt hVmRNP9dnDs5VNPVHxGT7kABhfeakPs9vhLGze+DdgMcmedVAHskdFdwhlAQIOxTpuMR xDePK0Kmg3HwsQo+G1N5ZDK0Jf4/Hb20KEzG4sFMex67qFHChzEZoFhmWeIQ4oDwmjiz MXIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Ez3y6TuQoJf9yjasiQe9ev4GHCCFIMlgYUuaXW302N4=; b=GhyutU8ntPgI4D5etcGPBoiavjwJ3UZCluhxoSlfeG7I2lzezG3LX6b/bikWXAJI/9 kBBk9rrYyoCEkB7p7okO1d8AvDsb/lWmkM3PrWBZfU/4D+0QMEnCjKvZJs5WuGXH3o1H cgwxa6rJ3Tnc6WgSK6YVKtiNEQVj/GrnvzS1W9uLIXpTzJx1P3DZixPR+8QFOIiUzGYs LjG01WuyYRy/CgZtYeZjkO41OxxfbE3eGb2l9LrUMZ0FytofxvOVb34yvOdcdRrnpm3x 3AOQ2UHdyCKkMy13RiBBfQO/l9VYBwwUFZULaRdIgAMonLgdKUn9AbkoBL9cBQ5RL5/y bkJA== X-Gm-Message-State: APjAAAVgY2l9pUJkto/0Qp3WzCz7khnV5eQVtE8qSDG6mi7IkA/Ms7KO FXRZeCsK3TGeY1uy9UhwnVI= X-Google-Smtp-Source: APXvYqzMJa/OTHiJ4buNs8M2Z09tyHHkO/HViVZvfzsuOiDUhLAY+LcE7oa0t5ssJcw8nT0SZ/hzOw== X-Received: by 2002:ac8:21dd:: with SMTP id 29mr6203915qtz.340.1559614757401; Mon, 03 Jun 2019 19:19:17 -0700 (PDT) Received: from fabio-Latitude-E5450.am.freescale.net ([2804:14c:482:3c8:56cb:1049:60d2:137b]) by smtp.gmail.com with ESMTPSA id m27sm268398qtc.16.2019.06.03.19.19.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 19:19:16 -0700 (PDT) From: Fabio Estevam To: davem@davemloft.net Cc: fugang.duan@nxp.com, netdev@vger.kernel.org, Fabio Estevam Subject: [PATCH net-next] net: fec: Use netdev_err() instead of pr_err() Date: Mon, 3 Jun 2019 23:19:06 -0300 Message-Id: <20190604021906.17163-1-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org netdev_err() is more appropriate for printing error messages inside network drivers, so switch to netdev_err(). Signed-off-by: Fabio Estevam --- drivers/net/ethernet/freescale/fec_main.c | 8 ++++---- drivers/net/ethernet/freescale/fec_ptp.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 848defa33d3a..887c6cde1b88 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -2452,24 +2452,24 @@ fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec) return -EOPNOTSUPP; if (ec->rx_max_coalesced_frames > 255) { - pr_err("Rx coalesced frames exceed hardware limitation\n"); + netdev_err(ndev, "Rx coalesced frames exceed hardware limitation\n"); return -EINVAL; } if (ec->tx_max_coalesced_frames > 255) { - pr_err("Tx coalesced frame exceed hardware limitation\n"); + netdev_err(ndev, "Tx coalesced frame exceed hardware limitation\n"); return -EINVAL; } cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr); if (cycle > 0xFFFF) { - pr_err("Rx coalesced usec exceed hardware limitation\n"); + netdev_err(ndev, "Rx coalesced usec exceed hardware limitation\n"); return -EINVAL; } cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr); if (cycle > 0xFFFF) { - pr_err("Rx coalesced usec exceed hardware limitation\n"); + netdev_err(ndev, "Rx coalesced usec exceed hardware limitation\n"); return -EINVAL; } diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index 7e892b1cbd3d..1d7ea4604b83 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -617,7 +617,7 @@ void fec_ptp_init(struct platform_device *pdev, int irq_idx) fep->ptp_clock = ptp_clock_register(&fep->ptp_caps, &pdev->dev); if (IS_ERR(fep->ptp_clock)) { fep->ptp_clock = NULL; - pr_err("ptp_clock_register failed\n"); + netdev_err(ndev, "ptp_clock_register failed\n"); } schedule_delayed_work(&fep->time_keep, HZ); -- 2.17.1