All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Peter.Chen@nxp.com, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: chipidea: Use dev_err() instead of pr_err()
Date: Tue, 4 Jun 2019 08:03:24 +0200	[thread overview]
Message-ID: <20190604060324.GF3668@localhost> (raw)
In-Reply-To: <20190604020901.15197-1-festevam@gmail.com>

On Mon, Jun 03, 2019 at 11:09:01PM -0300, Fabio Estevam wrote:
> dev_err() is more appropriate for printing error messages inside
> drivers, so switch to dev_err().
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  drivers/usb/chipidea/core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 27749ace2d93..1b6495829265 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -523,8 +523,9 @@ int hw_device_reset(struct ci_hdrc *ci)
>  	hw_write(ci, OP_USBMODE, USBMODE_SLOM, USBMODE_SLOM);
>  
>  	if (hw_read(ci, OP_USBMODE, USBMODE_CM) != USBMODE_CM_DC) {
> -		pr_err("cannot enter in %s device mode", ci_role(ci)->name);
> -		pr_err("lpm = %i", ci->hw_bank.lpm);
> +		dev_err(ci->dev, "cannot enter in %s device mode",
> +			ci_role(ci)->name);
> +		dev_err(ci->dev, "lpm = %i", ci->hw_bank.lpm);

Please also add the missing newlines '\n' (and check if there are more
instances of that mistake in this driver).

>  		return -ENODEV;
>  	}

Johan

      reply	other threads:[~2019-06-04  6:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04  2:09 [PATCH] usb: chipidea: Use dev_err() instead of pr_err() Fabio Estevam
2019-06-04  6:03 ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190604060324.GF3668@localhost \
    --to=johan@kernel.org \
    --cc=Peter.Chen@nxp.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.