From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D327EC282CE for ; Tue, 4 Jun 2019 16:08:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B301D2075C for ; Tue, 4 Jun 2019 16:08:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728297AbfFDQIn (ORCPT ); Tue, 4 Jun 2019 12:08:43 -0400 Received: from mga01.intel.com ([192.55.52.88]:25369 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728280AbfFDQIm (ORCPT ); Tue, 4 Jun 2019 12:08:42 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 09:08:42 -0700 X-ExtLoop1: 1 Received: from unknown (HELO localhost) ([10.241.225.31]) by fmsmga001.fm.intel.com with ESMTP; 04 Jun 2019 09:08:41 -0700 Date: Tue, 4 Jun 2019 09:08:41 -0700 From: Jesse Brandeburg To: Xue Chaojing Cc: , , , , , , Subject: Re: [PATCH net-next v4] hinic: add LRO support Message-ID: <20190604090841.00007d28@intel.com> In-Reply-To: <20190604011608.26485-1-xuechaojing@huawei.com> References: <20190604011608.26485-1-xuechaojing@huawei.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.30; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Jun 2019 01:16:08 +0000 Xue wrote: > This patch adds LRO support for the HiNIC driver. > > Reported-by: kbuild test robot > Reviewed-by: Jesse Brandeburg > Signed-off-by: Xue Chaojing Hm, you added my reviewed-by tag, but I didn't add it myself, I only commented on your code. This is a no-no. You don't add tags with other people's names just because you think you can/should. If someone EXPLICITLY says: "go ahead and add my reviewed-by after these changes" then you can add it yourself. Also, what did you change in v1:v4? There should be a summary somewhere in the commit log (usually after a ---) FWIW, I looked over the code and my concerns were addressed. Reviewed-by: Jesse Brandeburg