[PATCH 1/1] counter/ftm-quaddec: Add missing dependencies in Kconfig

[PATCH 1/1] counter/ftm-quaddec: Add missing dependencies in Kconfig

[Patrick Havelange]

This driver uses devm_ioremap and of* functions. This fixes a
linking failure with e.g. ARCH=um.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com>
---
 drivers/counter/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
index 233ac305d878..c9e3f5c98484 100644
--- a/drivers/counter/Kconfig
+++ b/drivers/counter/Kconfig
@@ -50,6 +50,7 @@ config STM32_LPTIMER_CNT
 
 config FTM_QUADDEC
 	tristate "Flex Timer Module Quadrature decoder driver"
+	depends on HAS_IOMEM && OF
 	help
 	  Select this option to enable the Flex Timer Quadrature decoder
 	  driver.
-- 
2.19.1

Re: [PATCH 1/1] counter/ftm-quaddec: Add missing dependencies in Kconfig

[William Breathitt Gray]

On Tue, Jun 04, 2019 at 04:03:26PM +0200, Patrick Havelange wrote:
> This driver uses devm_ioremap and of* functions. This fixes a
> linking failure with e.g. ARCH=um.
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com>
> ---
>  drivers/counter/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index 233ac305d878..c9e3f5c98484 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -50,6 +50,7 @@ config STM32_LPTIMER_CNT
>  
>  config FTM_QUADDEC
>  	tristate "Flex Timer Module Quadrature decoder driver"
> +	depends on HAS_IOMEM && OF
>  	help
>  	  Select this option to enable the Flex Timer Quadrature decoder
>  	  driver.
> -- 
> 2.19.1

Fixes: a3b9a99 ("counter: add FlexTimer Module Quadrature decoder counter driver")
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>

Jonathan, would you pick this up through IIO?

Patrick, I noticed the FlexTimer Module Quadrature decoder driver is
missing an entry in MAINTAINERS. Please submit an additional patch to
address that as well so that we'll have a point of contact listed for
this driver.

Thanks,

William Breathit Gray

Re: [PATCH 1/1] counter/ftm-quaddec: Add missing dependencies in Kconfig

[Jonathan Cameron]

On Wed, 5 Jun 2019 00:11:15 +0900
William Breathitt Gray <vilhelm.gray@gmail.com> wrote:

> On Tue, Jun 04, 2019 at 04:03:26PM +0200, Patrick Havelange wrote:
> > This driver uses devm_ioremap and of* functions. This fixes a
> > linking failure with e.g. ARCH=um.
> > 
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com>
> > ---
> >  drivers/counter/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> > index 233ac305d878..c9e3f5c98484 100644
> > --- a/drivers/counter/Kconfig
> > +++ b/drivers/counter/Kconfig
> > @@ -50,6 +50,7 @@ config STM32_LPTIMER_CNT
> >  
> >  config FTM_QUADDEC
> >  	tristate "Flex Timer Module Quadrature decoder driver"
> > +	depends on HAS_IOMEM && OF
> >  	help
> >  	  Select this option to enable the Flex Timer Quadrature decoder
> >  	  driver.
> > -- 
> > 2.19.1  
> 
> Fixes: a3b9a99 ("counter: add FlexTimer Module Quadrature decoder counter driver")
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> 
> Jonathan, would you pick this up through IIO?
Sure,

Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> 
> Patrick, I noticed the FlexTimer Module Quadrature decoder driver is
> missing an entry in MAINTAINERS. Please submit an additional patch to
> address that as well so that we'll have a point of contact listed for
> this driver.
> 
> Thanks,
> 
> William Breathit Gray