From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6A15C282CE for ; Tue, 4 Jun 2019 14:45:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5F6923D16 for ; Tue, 4 Jun 2019 14:45:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727504AbfFDOpg (ORCPT ); Tue, 4 Jun 2019 10:45:36 -0400 Received: from fieldses.org ([173.255.197.46]:47386 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727385AbfFDOpf (ORCPT ); Tue, 4 Jun 2019 10:45:35 -0400 Received: by fieldses.org (Postfix, from userid 2815) id 509F21C9D; Tue, 4 Jun 2019 10:45:35 -0400 (EDT) Date: Tue, 4 Jun 2019 10:45:35 -0400 From: Bruce Fields To: Chuck Lever Cc: Dave Wysochanski , Linux NFS Mailing List Subject: Re: [PATCH 3/3] SUNRPC: Count ops completing with tk_status < 0 Message-ID: <20190604144535.GA19422@fieldses.org> References: <20190523201351.12232-1-dwysocha@redhat.com> <20190523201351.12232-3-dwysocha@redhat.com> <20190530213857.GA24802@fieldses.org> <9B9F0C9B-C493-44F5-ABD1-6B2B4BAA2F08@oracle.com> <20190530223314.GA25368@fieldses.org> <5CE8A68E-F5C2-4321-8F57-451F5E5AF789@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5CE8A68E-F5C2-4321-8F57-451F5E5AF789@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Jun 03, 2019 at 02:56:29PM -0400, Chuck Lever wrote: > > On Jun 3, 2019, at 2:53 PM, Dave Wysochanski wrote: > > On Fri, 2019-05-31 at 09:25 -0400, Chuck Lever wrote: > >>> On May 30, 2019, at 6:33 PM, Bruce Fields > >>> wrote: > >>> On Thu, May 30, 2019 at 06:19:54PM -0400, Chuck Lever wrote: > >>>> We now have trace points that can do that too. > >>> > >>> You mean, that can report every error (and its value)? > >> > >> Yes, the nfs_xdr_status trace point reports the error by value and > >> symbolic name. > > > > The tracepoint is very useful I agree. I don't think it will show: > > a) the mount > > b) the opcode > > > > Or am I mistaken and there's a way to get those with a filter or > > another tracepoint? > > The opcode can be exposed by another trace point, but the link between > the two trace points is tenuous and could be improved. > > I don't believe any of the NFS trace points expose the mount. My testing > is largely on a single mount so my imagination stopped there. Dumb question: is it possible to add more fields to tracepoints without breaking some kind of backwards compatibility? I wonder if adding, say, an xid and an xprt pointer to tracepoints when available would help with this kind of thing. In any case, I think Dave's stats will still be handy if only because they're on all the time. --b.