From: Maxime Ripard <maxime.ripard@bootlin.com> To: Luca Weiss <luca@z3ntu.xyz> Cc: Hans de Goede <hdegoede@redhat.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>, "open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER" <linux-input@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "moderated list:ARM/Allwinner sunXi SoC support" <linux-arm-kernel@lists.infradead.org>, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Date: Tue, 4 Jun 2019 16:59:07 +0200 [thread overview] Message-ID: <20190604145907.j3fp52gxupd3bkih@flea> (raw) In-Reply-To: <20190604144252.26965-1-luca@z3ntu.xyz> [-- Attachment #1: Type: text/plain, Size: 2046 bytes --] Hi Luca, On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote: > Add a node describing the KEYADC on the A64. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> You should have a changelog detailing which changes you made to your patch with the previous version, and why you made those changes (for example because we looked at the a83t datasheet and found the two controllers to be very similar). > --- > .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > index 496125c6bfb7..507b737612ea 100644 > --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > @@ -5,6 +5,7 @@ Required properties: > - compatible: should be one of the following string: > "allwinner,sun4i-a10-lradc-keys" > "allwinner,sun8i-a83t-r-lradc" > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" > - reg: mmio address range of the chip > - interrupts: interrupt to which the chip is connected > - vref-supply: powersupply for the lradc reference voltage > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 7734f70e1057..3a42352b5c9f 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -704,6 +704,14 @@ > status = "disabled"; > }; > > + lradc: lradc@1c21800 { > + compatible = "allwinner,sun50i-a64-lradc", > + "allwinner,sun8i-a83t-r-lradc"; > + reg = <0x01c21800 0x400>; > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + The bindings and the dt changes should be two different patches as well. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com> To: Luca Weiss <luca@z3ntu.xyz> Cc: Mark Rutland <mark.rutland@arm.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, open list <linux-kernel@vger.kernel.org>, Hans de Goede <hdegoede@redhat.com>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>, "open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER" <linux-input@vger.kernel.org>, "moderated list:ARM/Allwinner sunXi SoC support" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Date: Tue, 4 Jun 2019 16:59:07 +0200 [thread overview] Message-ID: <20190604145907.j3fp52gxupd3bkih@flea> (raw) In-Reply-To: <20190604144252.26965-1-luca@z3ntu.xyz> [-- Attachment #1.1: Type: text/plain, Size: 2046 bytes --] Hi Luca, On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote: > Add a node describing the KEYADC on the A64. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> You should have a changelog detailing which changes you made to your patch with the previous version, and why you made those changes (for example because we looked at the a83t datasheet and found the two controllers to be very similar). > --- > .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > index 496125c6bfb7..507b737612ea 100644 > --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > @@ -5,6 +5,7 @@ Required properties: > - compatible: should be one of the following string: > "allwinner,sun4i-a10-lradc-keys" > "allwinner,sun8i-a83t-r-lradc" > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" > - reg: mmio address range of the chip > - interrupts: interrupt to which the chip is connected > - vref-supply: powersupply for the lradc reference voltage > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 7734f70e1057..3a42352b5c9f 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -704,6 +704,14 @@ > status = "disabled"; > }; > > + lradc: lradc@1c21800 { > + compatible = "allwinner,sun50i-a64-lradc", > + "allwinner,sun8i-a83t-r-lradc"; > + reg = <0x01c21800 0x400>; > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + The bindings and the dt changes should be two different patches as well. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-04 14:59 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-04 14:42 [PATCH] arm64: dts: allwinner: a64: Add lradc node Luca Weiss 2019-06-04 14:42 ` Luca Weiss 2019-06-04 14:42 ` Luca Weiss 2019-06-04 14:59 ` Maxime Ripard [this message] 2019-06-04 14:59 ` Maxime Ripard 2019-06-04 14:59 ` Maxime Ripard 2019-06-04 15:07 ` Luca Weiss 2019-06-04 15:07 ` Luca Weiss 2019-06-04 15:07 ` Luca Weiss -- strict thread matches above, loose matches on Subject: below -- 2019-05-18 17:09 Luca Weiss 2019-05-18 17:09 ` Luca Weiss 2019-05-18 17:09 ` Luca Weiss 2019-05-20 11:07 ` Maxime Ripard 2019-05-20 11:07 ` Maxime Ripard 2019-05-20 11:07 ` Maxime Ripard 2019-05-21 6:43 ` luca 2019-05-21 6:43 ` luca 2019-05-21 6:43 ` luca 2019-05-21 13:09 ` Maxime Ripard 2019-05-21 13:09 ` Maxime Ripard 2019-05-21 13:09 ` Maxime Ripard 2019-05-21 13:52 ` luca 2019-05-21 13:52 ` luca 2019-05-21 13:52 ` luca 2019-05-21 14:25 ` Maxime Ripard 2019-05-21 14:25 ` Maxime Ripard 2019-05-21 14:25 ` Maxime Ripard 2019-05-24 8:35 ` Luca Weiss 2019-05-24 8:35 ` Luca Weiss 2019-05-24 8:35 ` Luca Weiss 2019-05-24 9:20 ` Maxime Ripard 2019-05-24 9:20 ` Maxime Ripard 2019-05-24 9:20 ` Maxime Ripard 2019-05-31 10:27 ` Luca Weiss 2019-05-31 10:27 ` Luca Weiss 2019-05-31 10:27 ` Luca Weiss 2019-06-03 7:42 ` Maxime Ripard 2019-06-03 7:42 ` Maxime Ripard 2019-06-03 7:42 ` Maxime Ripard 2019-06-03 15:20 ` Luca Weiss 2019-06-03 15:20 ` Luca Weiss 2019-06-03 15:20 ` Luca Weiss 2019-06-04 8:28 ` Maxime Ripard 2019-06-04 8:28 ` Maxime Ripard 2019-06-04 8:28 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190604145907.j3fp52gxupd3bkih@flea \ --to=maxime.ripard@bootlin.com \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=hdegoede@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luca@z3ntu.xyz \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.