From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3BF5C282CE for ; Tue, 4 Jun 2019 22:37:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7CE922067C for ; Tue, 4 Jun 2019 22:37:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rB6ebIAv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726305AbfFDWhD (ORCPT ); Tue, 4 Jun 2019 18:37:03 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:40086 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbfFDWhD (ORCPT ); Tue, 4 Jun 2019 18:37:03 -0400 Received: by mail-pg1-f194.google.com with SMTP id d30so11182306pgm.7 for ; Tue, 04 Jun 2019 15:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=q3LYolv9HS8m3O9LEPPo+AYNjPUFnZ39lcs8VPIoY7Y=; b=rB6ebIAvraBr3OkVvfCrDmvlEKBZzTdiegPVzW+a9Mp/EQswhhTU6Fke3ruVWDYx4S UpJS8sapWXy50/ISJ4Xr9DyiQGrIgHPoP/ir/U7XQEKbJrpmSAKES9u15fms3X9Nwepo abRM00W1dy0ncnCbHsztuaGXBoBHHmEHVNx0RcpgS4i6/1m/1Tf4tEsPxPNphrkinks0 UFjA341cRsyEdx6HxcVXe3vnf4YVnY06xJPFrGGdHm2yxQh+TCUfEePfUYkeH/D5tDxp WyxqLUmZSP/UpKPaeZypRh9nI0UKMt1uB+AB3XVc3HOogo042WGitH/d/+LxSKqwyUK3 S8Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=q3LYolv9HS8m3O9LEPPo+AYNjPUFnZ39lcs8VPIoY7Y=; b=LkP9DYamVk1hYfBHkdKCTUh+fMDqWWkkg1+k3iOi7nNzQh7Wb1GO0E/NVU5ClyLuO2 zc7Z9xAbXWXRR/1fx/MpimhZPO2JMrdWAmA855m/SRBPPQ78eIzvqfzBN6L6BJPmtsT5 uERspk7JLDEkrI7MdQloXI0f+4A8CfToRBWDDZJL5gLXzazhvMZ/KbZt7QNlhjmAD7aa YSq0Qdm7V5ibFOQnzvFIe7Z9lTCZfxIU/ArqQ4/aInWjX6SMryAwpLUyXDTzWTamHWTu TBLuDURac+9UKnsVYNg3JelncC3O55WR27Eq/qnHACnchinDc9+ozvR79XHU1w6yj5cG opmg== X-Gm-Message-State: APjAAAX68pealJE2FuoF6SgKcUQtx86cLz921StgcUOmLn381R1DqxZC uDFyMZWqRQrVpc9XldRD2HUIzQ== X-Google-Smtp-Source: APXvYqyBR8kVfo5UG11Mff9yGDhpHlpTueoxyePcbFTPSVifGJSFF+exudIdxNVt5jQnwyblXLDmlA== X-Received: by 2002:a63:1c59:: with SMTP id c25mr182601pgm.395.1559687822780; Tue, 04 Jun 2019 15:37:02 -0700 (PDT) Received: from minitux (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id h15sm471630pfr.44.2019.06.04.15.37.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Jun 2019 15:37:02 -0700 (PDT) Date: Tue, 4 Jun 2019 15:37:00 -0700 From: Bjorn Andersson To: Stephen Boyd Cc: Andy Gross , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Sibi Sankar Subject: Re: [PATCH] arm64: dts: sdm845: Add iommus property to qup1 Message-ID: <20190604223700.GE4814@minitux> References: <20190604222939.195471-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190604222939.195471-1-swboyd@chromium.org> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 04 Jun 15:29 PDT 2019, Stephen Boyd wrote: > The SMMU that sits in front of the QUP needs to be programmed properly > so that the i2c geni driver can allocate DMA descriptors. Failure to do > this leads to faults when using devices such as an i2c touchscreen where > the transaction is larger than 32 bytes and we use a DMA buffer. > I'm pretty sure I've run into this problem, but before we marked the smmu bypass_disable and as such didn't get the fault, thanks. > arm-smmu 15000000.iommu: Unexpected global fault, this could be serious > arm-smmu 15000000.iommu: GFSR 0x00000002, GFSYNR0 0x00000002, GFSYNR1 0x000006c0, GFSYNR2 0x00000000 > > Add the right SID and mask so this works. > > Cc: Sibi Sankar > Signed-off-by: Stephen Boyd > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index fcb93300ca62..2e57e861e17c 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -900,6 +900,7 @@ > #address-cells = <2>; > #size-cells = <2>; > ranges; > + iommus = <&apps_smmu 0x6c0 0x3>; According to the docs this stream belongs to TZ, the HLOS stream should be 0x6c3. Regards, Bjorn > status = "disabled"; > > i2c8: i2c@a80000 { > -- > Sent by a computer through tubes >